[INFO] updating cached repository mzumi/github-search-repository [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mzumi/github-search-repository [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mzumi/github-search-repository" "work/ex/clippy-test-run/sources/stable/gh/mzumi/github-search-repository"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mzumi/github-search-repository'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mzumi/github-search-repository" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mzumi/github-search-repository"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mzumi/github-search-repository'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 166fbefcadb6634da0a3c3890ac17986efed307c [INFO] sha for GitHub repo mzumi/github-search-repository: 166fbefcadb6634da0a3c3890ac17986efed307c [INFO] validating manifest of mzumi/github-search-repository on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mzumi/github-search-repository on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mzumi/github-search-repository [INFO] finished frobbing mzumi/github-search-repository [INFO] frobbed toml for mzumi/github-search-repository written to work/ex/clippy-test-run/sources/stable/gh/mzumi/github-search-repository/Cargo.toml [INFO] started frobbing mzumi/github-search-repository [INFO] finished frobbing mzumi/github-search-repository [INFO] frobbed toml for mzumi/github-search-repository written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mzumi/github-search-repository/Cargo.toml [INFO] crate mzumi/github-search-repository has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mzumi/github-search-repository against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mzumi/github-search-repository:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ce8f562ff476ddc979ea768531f3bea6a1f426e3e9011bc1691b855266bc71ef [INFO] running `"docker" "start" "-a" "ce8f562ff476ddc979ea768531f3bea6a1f426e3e9011bc1691b855266bc71ef"` [INFO] [stderr] Compiling openssl v0.9.7 [INFO] [stderr] Compiling openssl-sys v0.9.7 [INFO] [stderr] Checking mime v0.2.2 [INFO] [stderr] Checking serde_urlencoded v0.4.2 [INFO] [stderr] Checking hyper v0.10.5 [INFO] [stderr] Checking native-tls v0.1.1 [INFO] [stderr] Checking hyper-native-tls v0.2.2 [INFO] [stderr] Checking reqwest v0.4.0 [INFO] [stderr] Checking github-search-repository v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:49:30 [INFO] [stderr] | [INFO] [stderr] 49 | SearchRepositories { keyword: keyword } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `keyword` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | SearchUsers { keyword: keyword } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `keyword` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:49:30 [INFO] [stderr] | [INFO] [stderr] 49 | SearchRepositories { keyword: keyword } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `keyword` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request/mod.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | SearchUsers { keyword: keyword } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `keyword` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/request/mod.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | fn response(&self, buf: &String) -> Result, GitHubClientError>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/request/mod.rs:69:36 [INFO] [stderr] | [INFO] [stderr] 69 | json::decode(&buf).map_err(|e| From::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/request/mod.rs:99:36 [INFO] [stderr] | [INFO] [stderr] 99 | json::decode(&buf).map_err(|e| From::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GitHubClient` [INFO] [stderr] --> src/lib.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> GitHubClient { [INFO] [stderr] 19 | | GitHubClient {} [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/request/mod.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | fn response(&self, buf: &String) -> Result, GitHubClientError>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/request/mod.rs:69:36 [INFO] [stderr] | [INFO] [stderr] 69 | json::decode(&buf).map_err(|e| From::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/request/mod.rs:99:36 [INFO] [stderr] | [INFO] [stderr] 99 | json::decode(&buf).map_err(|e| From::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GitHubClient` [INFO] [stderr] --> src/lib.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> GitHubClient { [INFO] [stderr] 19 | | GitHubClient {} [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.95s [INFO] running `"docker" "inspect" "ce8f562ff476ddc979ea768531f3bea6a1f426e3e9011bc1691b855266bc71ef"` [INFO] running `"docker" "rm" "-f" "ce8f562ff476ddc979ea768531f3bea6a1f426e3e9011bc1691b855266bc71ef"` [INFO] [stdout] ce8f562ff476ddc979ea768531f3bea6a1f426e3e9011bc1691b855266bc71ef