[INFO] updating cached repository mzumi/circleci-checker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mzumi/circleci-checker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mzumi/circleci-checker" "work/ex/clippy-test-run/sources/stable/gh/mzumi/circleci-checker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mzumi/circleci-checker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mzumi/circleci-checker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mzumi/circleci-checker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mzumi/circleci-checker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 37aed163716a97c2f76cfcd0ce94d2541c114cce [INFO] sha for GitHub repo mzumi/circleci-checker: 37aed163716a97c2f76cfcd0ce94d2541c114cce [INFO] validating manifest of mzumi/circleci-checker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mzumi/circleci-checker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mzumi/circleci-checker [INFO] finished frobbing mzumi/circleci-checker [INFO] frobbed toml for mzumi/circleci-checker written to work/ex/clippy-test-run/sources/stable/gh/mzumi/circleci-checker/Cargo.toml [INFO] started frobbing mzumi/circleci-checker [INFO] finished frobbing mzumi/circleci-checker [INFO] frobbed toml for mzumi/circleci-checker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mzumi/circleci-checker/Cargo.toml [INFO] crate mzumi/circleci-checker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mzumi/circleci-checker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mzumi/circleci-checker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6e1c1308ba5083b24efba9134b8d2bc107b90ff62fca7f68c037be86557a2048 [INFO] running `"docker" "start" "-a" "6e1c1308ba5083b24efba9134b8d2bc107b90ff62fca7f68c037be86557a2048"` [INFO] [stderr] Compiling openssl v0.9.8 [INFO] [stderr] Compiling openssl-sys v0.9.8 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking mockito v0.2.5 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking dotenv v0.8.0 [INFO] [stderr] Checking native-tls v0.1.1 [INFO] [stderr] Checking hyper-native-tls v0.2.2 [INFO] [stderr] Checking circleci-checker v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/service.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | const URL: &'static str = "https://circleci.com"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/service.rs:40:33 [INFO] [stderr] | [INFO] [stderr] 40 | json::decode(&body).map_err(|e| From::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/service.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | const URL: &'static str = mockito::SERVER_URL; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/service.rs:40:33 [INFO] [stderr] | [INFO] [stderr] 40 | json::decode(&body).map_err(|e| From::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/service.rs:80:17 [INFO] [stderr] | [INFO] [stderr] 80 | let ref project = projects[0]; [INFO] [stderr] | ----^^^^^^^^^^^--------------- help: try: `let project = &projects[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/service.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | let branch = project.branches.get("master").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&project.branches["master"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/service.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | let ref recent_build = recent_builds[0]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^-------------------- help: try: `let recent_build = &recent_builds[0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:30:37 [INFO] [stderr] | [INFO] [stderr] 30 | Some(ref builds) if builds.len() > 0 => &builds[0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!builds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:30:37 [INFO] [stderr] | [INFO] [stderr] 30 | Some(ref builds) if builds.len() > 0 => &builds[0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!builds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.43s [INFO] running `"docker" "inspect" "6e1c1308ba5083b24efba9134b8d2bc107b90ff62fca7f68c037be86557a2048"` [INFO] running `"docker" "rm" "-f" "6e1c1308ba5083b24efba9134b8d2bc107b90ff62fca7f68c037be86557a2048"` [INFO] [stdout] 6e1c1308ba5083b24efba9134b8d2bc107b90ff62fca7f68c037be86557a2048