[INFO] updating cached repository mythmon/classify-client [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mythmon/classify-client [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mythmon/classify-client" "work/ex/clippy-test-run/sources/stable/gh/mythmon/classify-client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mythmon/classify-client'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mythmon/classify-client" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mythmon/classify-client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mythmon/classify-client'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ab14b7009f3bf87c76bd1326abe16094f2a6face [INFO] sha for GitHub repo mythmon/classify-client: ab14b7009f3bf87c76bd1326abe16094f2a6face [INFO] validating manifest of mythmon/classify-client on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mythmon/classify-client on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mythmon/classify-client [INFO] finished frobbing mythmon/classify-client [INFO] frobbed toml for mythmon/classify-client written to work/ex/clippy-test-run/sources/stable/gh/mythmon/classify-client/Cargo.toml [INFO] started frobbing mythmon/classify-client [INFO] finished frobbing mythmon/classify-client [INFO] frobbed toml for mythmon/classify-client written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mythmon/classify-client/Cargo.toml [INFO] crate mythmon/classify-client has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mythmon/classify-client against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mythmon/classify-client:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f58d17783a4409603a5dca8f2f5f867322ca8a74312effbc2893a9d079e9b6b7 [INFO] running `"docker" "start" "-a" "f58d17783a4409603a5dca8f2f5f867322ca8a74312effbc2893a9d079e9b6b7"` [INFO] [stderr] Compiling actix-web v0.7.15 [INFO] [stderr] Checking crossbeam-utils v0.6.2 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Checking hostname v0.1.5 [INFO] [stderr] Compiling rand v0.5.5 [INFO] [stderr] Checking backtrace-sys v0.1.24 [INFO] [stderr] Checking brotli-sys v0.3.2 [INFO] [stderr] Checking ring v0.13.5 [INFO] [stderr] Checking miniz-sys v0.1.11 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking resolv-conf v0.6.1 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling serde_derive v1.0.81 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking tokio-timer v0.2.8 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking h2 v0.1.14 [INFO] [stderr] Checking crossbeam-deque v0.6.2 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking config v0.9.1 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Checking crossbeam-channel v0.3.3 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking trust-dns-resolver v0.10.0 [INFO] [stderr] Checking maxminddb v0.11.0 [INFO] [stderr] Checking actix v0.7.8 [INFO] [stderr] Checking actix-net v0.2.4 [INFO] [stderr] Checking classify-client v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:219:62 [INFO] [stderr] | [INFO] [stderr] 219 | .and_then(|iso_code| Some(Ok(iso_code == "US".to_string()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"US"` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(clippy::all)] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::cmp_owned)] implied by #[deny(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:225:32 [INFO] [stderr] | [INFO] [stderr] 225 | let mut resp = match res { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 226 | | true => HttpResponse::Ok(), [INFO] [stderr] 227 | | false => HttpResponse::ServiceUnavailable(), [INFO] [stderr] 228 | | }; [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if res { HttpResponse::Ok() } else { HttpResponse::ServiceUnavailable() }` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(clippy::all)] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::match_bool)] implied by #[deny(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `classify-client`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:219:62 [INFO] [stderr] | [INFO] [stderr] 219 | .and_then(|iso_code| Some(Ok(iso_code == "US".to_string()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"US"` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(clippy::all)] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::cmp_owned)] implied by #[deny(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:225:32 [INFO] [stderr] | [INFO] [stderr] 225 | let mut resp = match res { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 226 | | true => HttpResponse::Ok(), [INFO] [stderr] 227 | | false => HttpResponse::ServiceUnavailable(), [INFO] [stderr] 228 | | }; [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if res { HttpResponse::Ok() } else { HttpResponse::ServiceUnavailable() }` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(clippy::all)] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::match_bool)] implied by #[deny(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `classify-client`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f58d17783a4409603a5dca8f2f5f867322ca8a74312effbc2893a9d079e9b6b7"` [INFO] running `"docker" "rm" "-f" "f58d17783a4409603a5dca8f2f5f867322ca8a74312effbc2893a9d079e9b6b7"` [INFO] [stdout] f58d17783a4409603a5dca8f2f5f867322ca8a74312effbc2893a9d079e9b6b7