[INFO] updating cached repository mynz/raytracer-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mynz/raytracer-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mynz/raytracer-rust" "work/ex/clippy-test-run/sources/stable/gh/mynz/raytracer-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mynz/raytracer-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mynz/raytracer-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mynz/raytracer-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mynz/raytracer-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 32598c17a730561b012d81be0eca0745ce7e2e2b [INFO] sha for GitHub repo mynz/raytracer-rust: 32598c17a730561b012d81be0eca0745ce7e2e2b [INFO] validating manifest of mynz/raytracer-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mynz/raytracer-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mynz/raytracer-rust [INFO] finished frobbing mynz/raytracer-rust [INFO] frobbed toml for mynz/raytracer-rust written to work/ex/clippy-test-run/sources/stable/gh/mynz/raytracer-rust/Cargo.toml [INFO] started frobbing mynz/raytracer-rust [INFO] finished frobbing mynz/raytracer-rust [INFO] frobbed toml for mynz/raytracer-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mynz/raytracer-rust/Cargo.toml [INFO] crate mynz/raytracer-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mynz/raytracer-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mynz/raytracer-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be4a02534790e378d14738360b63ff1a9f1fad2b836fbf2ece9a11962f400ecd [INFO] running `"docker" "start" "-a" "be4a02534790e378d14738360b63ff1a9f1fad2b836fbf2ece9a11962f400ecd"` [INFO] [stderr] Checking inflate v0.3.4 [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking raytracer-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | mat: mat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:306:21 [INFO] [stderr] | [INFO] [stderr] 306 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:316:21 [INFO] [stderr] | [INFO] [stderr] 316 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:309:21 [INFO] [stderr] | [INFO] [stderr] 309 | p: p, [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:319:21 [INFO] [stderr] | [INFO] [stderr] 319 | p: p, [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | mat: mat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:306:21 [INFO] [stderr] | [INFO] [stderr] 306 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:316:21 [INFO] [stderr] | [INFO] [stderr] 316 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:309:21 [INFO] [stderr] | [INFO] [stderr] 309 | p: p, [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:319:21 [INFO] [stderr] | [INFO] [stderr] 319 | p: p, [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | / let cosine; [INFO] [stderr] 236 | | [INFO] [stderr] 237 | | if Vec3::dot(&r.direction(), &rec.normal) > 0.0 { [INFO] [stderr] 238 | | outward_normal = -rec.normal; [INFO] [stderr] ... | [INFO] [stderr] 244 | | cosine = -Vec3::dot(&r.direction(), &rec.normal) / r.direction().length(); [INFO] [stderr] 245 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let cosine = if Vec3::dot(&r.direction(), &rec.normal) > 0.0 { ..; self.ref_idx * Vec3::dot(&r.direction(), &rec.normal) / r.direction().length() } else { ..; -Vec3::dot(&r.direction(), &rec.normal) / r.direction().length() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/main.rs:437:12 [INFO] [stderr] | [INFO] [stderr] 437 | if !(p.dot(&p) >= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | / let cosine; [INFO] [stderr] 236 | | [INFO] [stderr] 237 | | if Vec3::dot(&r.direction(), &rec.normal) > 0.0 { [INFO] [stderr] 238 | | outward_normal = -rec.normal; [INFO] [stderr] ... | [INFO] [stderr] 244 | | cosine = -Vec3::dot(&r.direction(), &rec.normal) / r.direction().length(); [INFO] [stderr] 245 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let cosine = if Vec3::dot(&r.direction(), &rec.normal) > 0.0 { ..; self.ref_idx * Vec3::dot(&r.direction(), &rec.normal) / r.direction().length() } else { ..; -Vec3::dot(&r.direction(), &rec.normal) / r.direction().length() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/main.rs:437:12 [INFO] [stderr] | [INFO] [stderr] 437 | if !(p.dot(&p) >= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.67s [INFO] running `"docker" "inspect" "be4a02534790e378d14738360b63ff1a9f1fad2b836fbf2ece9a11962f400ecd"` [INFO] running `"docker" "rm" "-f" "be4a02534790e378d14738360b63ff1a9f1fad2b836fbf2ece9a11962f400ecd"` [INFO] [stdout] be4a02534790e378d14738360b63ff1a9f1fad2b836fbf2ece9a11962f400ecd