[INFO] updating cached repository myfreeweb/dcml [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/myfreeweb/dcml [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/myfreeweb/dcml" "work/ex/clippy-test-run/sources/stable/gh/myfreeweb/dcml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/myfreeweb/dcml'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/myfreeweb/dcml" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/myfreeweb/dcml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/myfreeweb/dcml'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4b5fda1fd6b741de053f2e5e3c07b22639b56acf [INFO] sha for GitHub repo myfreeweb/dcml: 4b5fda1fd6b741de053f2e5e3c07b22639b56acf [INFO] validating manifest of myfreeweb/dcml on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of myfreeweb/dcml on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing myfreeweb/dcml [INFO] finished frobbing myfreeweb/dcml [INFO] frobbed toml for myfreeweb/dcml written to work/ex/clippy-test-run/sources/stable/gh/myfreeweb/dcml/Cargo.toml [INFO] started frobbing myfreeweb/dcml [INFO] finished frobbing myfreeweb/dcml [INFO] frobbed toml for myfreeweb/dcml written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/myfreeweb/dcml/Cargo.toml [INFO] crate myfreeweb/dcml has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting myfreeweb/dcml against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/myfreeweb/dcml:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec57b4cba3b8aa22d39235a7b727d6f532d151e050356e1cbc2796de1fa9bf89 [INFO] running `"docker" "start" "-a" "ec57b4cba3b8aa22d39235a7b727d6f532d151e050356e1cbc2796de1fa9bf89"` [INFO] [stderr] Checking im v4.1.0 [INFO] [stderr] Checking serde v1.0.9 [INFO] [stderr] Checking num-integer v0.1.34 [INFO] [stderr] Checking num-complex v0.1.38 [INFO] [stderr] Checking combine v2.3.2 [INFO] [stderr] Compiling serde_derive v1.0.9 [INFO] [stderr] Checking num-bigint v0.1.39 [INFO] [stderr] Checking num-iter v0.1.33 [INFO] [stderr] Checking num-rational v0.1.38 [INFO] [stderr] Checking num v0.1.39 [INFO] [stderr] Checking combine-language v2.0.0 [INFO] [stderr] Checking dcml v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | Deserializer { input: input } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | Deserializer { input: input } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 28 | | if cfg!(test) { [INFO] [stderr] 29 | | panic!("BigInt parse"); [INFO] [stderr] 30 | | } else { [INFO] [stderr] 31 | | Value::Void [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | } else if cfg!(test) { [INFO] [stderr] 28 | panic!("BigInt parse"); [INFO] [stderr] 29 | } else { [INFO] [stderr] 30 | Value::Void [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 58 | | if cfg!(test) { [INFO] [stderr] 59 | | panic!("float parse"); [INFO] [stderr] 60 | | } else { [INFO] [stderr] 61 | | Value::Void [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 57 | } else if cfg!(test) { [INFO] [stderr] 58 | panic!("float parse"); [INFO] [stderr] 59 | } else { [INFO] [stderr] 60 | Value::Void [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 51 | | if cfg!(test) { [INFO] [stderr] 52 | | panic!("BigRational from float"); [INFO] [stderr] 53 | | } else { [INFO] [stderr] 54 | | Value::Void [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 50 | } else if cfg!(test) { [INFO] [stderr] 51 | panic!("BigRational from float"); [INFO] [stderr] 52 | } else { [INFO] [stderr] 53 | Value::Void [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 28 | | if cfg!(test) { [INFO] [stderr] 29 | | panic!("BigInt parse"); [INFO] [stderr] 30 | | } else { [INFO] [stderr] 31 | | Value::Void [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | } else if cfg!(test) { [INFO] [stderr] 28 | panic!("BigInt parse"); [INFO] [stderr] 29 | } else { [INFO] [stderr] 30 | Value::Void [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 58 | | if cfg!(test) { [INFO] [stderr] 59 | | panic!("float parse"); [INFO] [stderr] 60 | | } else { [INFO] [stderr] 61 | | Value::Void [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 57 | } else if cfg!(test) { [INFO] [stderr] 58 | panic!("float parse"); [INFO] [stderr] 59 | } else { [INFO] [stderr] 60 | Value::Void [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 51 | | if cfg!(test) { [INFO] [stderr] 52 | | panic!("BigRational from float"); [INFO] [stderr] 53 | | } else { [INFO] [stderr] 54 | | Value::Void [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 50 | } else if cfg!(test) { [INFO] [stderr] 51 | panic!("BigRational from float"); [INFO] [stderr] 52 | } else { [INFO] [stderr] 53 | Value::Void [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:87:47 [INFO] [stderr] | [INFO] [stderr] 87 | (*x).to_integer().to_i8().ok_or(VError::invalid_value( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 88 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 89 | | &"a number that fits into i8", [INFO] [stderr] 90 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | (*x).to_integer().to_i8().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 88 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 89 | &"a number that fits into i8", [INFO] [stderr] 90 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:103:48 [INFO] [stderr] | [INFO] [stderr] 103 | (*x).to_integer().to_i16().ok_or(VError::invalid_value( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 104 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 105 | | &"a number that fits into i16", [INFO] [stderr] 106 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | (*x).to_integer().to_i16().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 104 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 105 | &"a number that fits into i16", [INFO] [stderr] 106 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:119:48 [INFO] [stderr] | [INFO] [stderr] 119 | (*x).to_integer().to_i32().ok_or(VError::invalid_value( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 120 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 121 | | &"a number that fits into i32", [INFO] [stderr] 122 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | (*x).to_integer().to_i32().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 120 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 121 | &"a number that fits into i32", [INFO] [stderr] 122 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:135:48 [INFO] [stderr] | [INFO] [stderr] 135 | (*x).to_integer().to_i64().ok_or(VError::invalid_value( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 136 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 137 | | &"a number that fits into i64", [INFO] [stderr] 138 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | (*x).to_integer().to_i64().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 136 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 137 | &"a number that fits into i64", [INFO] [stderr] 138 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:151:47 [INFO] [stderr] | [INFO] [stderr] 151 | (*x).to_integer().to_u8().ok_or(VError::invalid_value( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 152 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 153 | | &"a number that fits into u8", [INFO] [stderr] 154 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 151 | (*x).to_integer().to_u8().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 152 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 153 | &"a number that fits into u8", [INFO] [stderr] 154 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:167:48 [INFO] [stderr] | [INFO] [stderr] 167 | (*x).to_integer().to_u16().ok_or(VError::invalid_value( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 168 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 169 | | &"a number that fits into u16", [INFO] [stderr] 170 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 167 | (*x).to_integer().to_u16().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 168 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 169 | &"a number that fits into u16", [INFO] [stderr] 170 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:183:48 [INFO] [stderr] | [INFO] [stderr] 183 | (*x).to_integer().to_u32().ok_or(VError::invalid_value( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 184 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 185 | | &"a number that fits into u32", [INFO] [stderr] 186 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 183 | (*x).to_integer().to_u32().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 184 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 185 | &"a number that fits into u32", [INFO] [stderr] 186 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:199:48 [INFO] [stderr] | [INFO] [stderr] 199 | (*x).to_integer().to_u64().ok_or(VError::invalid_value( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 200 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 201 | | &"a number that fits into u64", [INFO] [stderr] 202 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 199 | (*x).to_integer().to_u64().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 200 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 201 | &"a number that fits into u64", [INFO] [stderr] 202 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:215:43 [INFO] [stderr] | [INFO] [stderr] 215 | (*x).numer().to_f32().ok_or(VError::invalid_value( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 216 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 217 | | &"a number that is valid as f32", [INFO] [stderr] 218 | | ))? / [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 215 | (*x).numer().to_f32().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 216 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 217 | &"a number that is valid as f32", [INFO] [stderr] 218 | ))? / [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:219:43 [INFO] [stderr] | [INFO] [stderr] 219 | (*x).denom().to_f32().ok_or(VError::invalid_value( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 220 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 221 | | &"a number that is valid as f32", [INFO] [stderr] 222 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 219 | (*x).denom().to_f32().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 220 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 221 | &"a number that is valid as f32", [INFO] [stderr] 222 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:235:43 [INFO] [stderr] | [INFO] [stderr] 235 | (*x).numer().to_f64().ok_or(VError::invalid_value( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 236 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 237 | | &"a number that is valid as f64", [INFO] [stderr] 238 | | ))? / [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 235 | (*x).numer().to_f64().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 236 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 237 | &"a number that is valid as f64", [INFO] [stderr] 238 | ))? / [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:239:43 [INFO] [stderr] | [INFO] [stderr] 239 | (*x).denom().to_f64().ok_or(VError::invalid_value( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 240 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 241 | | &"a number that is valid as f64", [INFO] [stderr] 242 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 239 | (*x).denom().to_f64().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 240 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 241 | &"a number that is valid as f64", [INFO] [stderr] 242 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:87:47 [INFO] [stderr] | [INFO] [stderr] 87 | (*x).to_integer().to_i8().ok_or(VError::invalid_value( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 88 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 89 | | &"a number that fits into i8", [INFO] [stderr] 90 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | (*x).to_integer().to_i8().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 88 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 89 | &"a number that fits into i8", [INFO] [stderr] 90 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:103:48 [INFO] [stderr] | [INFO] [stderr] 103 | (*x).to_integer().to_i16().ok_or(VError::invalid_value( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 104 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 105 | | &"a number that fits into i16", [INFO] [stderr] 106 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | (*x).to_integer().to_i16().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 104 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 105 | &"a number that fits into i16", [INFO] [stderr] 106 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:119:48 [INFO] [stderr] | [INFO] [stderr] 119 | (*x).to_integer().to_i32().ok_or(VError::invalid_value( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 120 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 121 | | &"a number that fits into i32", [INFO] [stderr] 122 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | (*x).to_integer().to_i32().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 120 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 121 | &"a number that fits into i32", [INFO] [stderr] 122 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:135:48 [INFO] [stderr] | [INFO] [stderr] 135 | (*x).to_integer().to_i64().ok_or(VError::invalid_value( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 136 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 137 | | &"a number that fits into i64", [INFO] [stderr] 138 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | (*x).to_integer().to_i64().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 136 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 137 | &"a number that fits into i64", [INFO] [stderr] 138 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:151:47 [INFO] [stderr] | [INFO] [stderr] 151 | (*x).to_integer().to_u8().ok_or(VError::invalid_value( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 152 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 153 | | &"a number that fits into u8", [INFO] [stderr] 154 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 151 | (*x).to_integer().to_u8().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 152 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 153 | &"a number that fits into u8", [INFO] [stderr] 154 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:167:48 [INFO] [stderr] | [INFO] [stderr] 167 | (*x).to_integer().to_u16().ok_or(VError::invalid_value( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 168 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 169 | | &"a number that fits into u16", [INFO] [stderr] 170 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 167 | (*x).to_integer().to_u16().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 168 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 169 | &"a number that fits into u16", [INFO] [stderr] 170 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:183:48 [INFO] [stderr] | [INFO] [stderr] 183 | (*x).to_integer().to_u32().ok_or(VError::invalid_value( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 184 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 185 | | &"a number that fits into u32", [INFO] [stderr] 186 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 183 | (*x).to_integer().to_u32().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 184 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 185 | &"a number that fits into u32", [INFO] [stderr] 186 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:199:48 [INFO] [stderr] | [INFO] [stderr] 199 | (*x).to_integer().to_u64().ok_or(VError::invalid_value( [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 200 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 201 | | &"a number that fits into u64", [INFO] [stderr] 202 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 199 | (*x).to_integer().to_u64().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 200 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 201 | &"a number that fits into u64", [INFO] [stderr] 202 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:215:43 [INFO] [stderr] | [INFO] [stderr] 215 | (*x).numer().to_f32().ok_or(VError::invalid_value( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 216 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 217 | | &"a number that is valid as f32", [INFO] [stderr] 218 | | ))? / [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 215 | (*x).numer().to_f32().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 216 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 217 | &"a number that is valid as f32", [INFO] [stderr] 218 | ))? / [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:219:43 [INFO] [stderr] | [INFO] [stderr] 219 | (*x).denom().to_f32().ok_or(VError::invalid_value( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 220 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 221 | | &"a number that is valid as f32", [INFO] [stderr] 222 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 219 | (*x).denom().to_f32().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 220 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 221 | &"a number that is valid as f32", [INFO] [stderr] 222 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:235:43 [INFO] [stderr] | [INFO] [stderr] 235 | (*x).numer().to_f64().ok_or(VError::invalid_value( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 236 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 237 | | &"a number that is valid as f64", [INFO] [stderr] 238 | | ))? / [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 235 | (*x).numer().to_f64().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 236 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 237 | &"a number that is valid as f64", [INFO] [stderr] 238 | ))? / [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:239:43 [INFO] [stderr] | [INFO] [stderr] 239 | (*x).denom().to_f64().ok_or(VError::invalid_value( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 240 | | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 241 | | &"a number that is valid as f64", [INFO] [stderr] 242 | | ))?, [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 239 | (*x).denom().to_f64().ok_or_else(|| VError::invalid_value( [INFO] [stderr] 240 | Deserializer::unexpected(Number((*x).clone())), [INFO] [stderr] 241 | &"a number that is valid as f64", [INFO] [stderr] 242 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/de.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | assert_eq!(2.5, from_value::(rat(b"5", b"2", 10)).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/de.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | assert_eq!(2.5, from_value::(rat(b"5", b"2", 10)).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `dcml`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ec57b4cba3b8aa22d39235a7b727d6f532d151e050356e1cbc2796de1fa9bf89"` [INFO] running `"docker" "rm" "-f" "ec57b4cba3b8aa22d39235a7b727d6f532d151e050356e1cbc2796de1fa9bf89"` [INFO] [stdout] ec57b4cba3b8aa22d39235a7b727d6f532d151e050356e1cbc2796de1fa9bf89