[INFO] updating cached repository mxtthias/paco [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mxtthias/paco [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mxtthias/paco" "work/ex/clippy-test-run/sources/stable/gh/mxtthias/paco"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mxtthias/paco'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mxtthias/paco" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mxtthias/paco"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mxtthias/paco'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fb74e6cb1e6cdd02110b22ea17217fd9e9657dbb [INFO] sha for GitHub repo mxtthias/paco: fb74e6cb1e6cdd02110b22ea17217fd9e9657dbb [INFO] validating manifest of mxtthias/paco on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mxtthias/paco on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mxtthias/paco [INFO] finished frobbing mxtthias/paco [INFO] frobbed toml for mxtthias/paco written to work/ex/clippy-test-run/sources/stable/gh/mxtthias/paco/Cargo.toml [INFO] started frobbing mxtthias/paco [INFO] finished frobbing mxtthias/paco [INFO] frobbed toml for mxtthias/paco written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mxtthias/paco/Cargo.toml [INFO] crate mxtthias/paco has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mxtthias/paco against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mxtthias/paco:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f204714a74504bd97f00562a0d5f272e911ba77a336643d9f64d67669b6892b8 [INFO] running `"docker" "start" "-a" "f204714a74504bd97f00562a0d5f272e911ba77a336643d9f64d67669b6892b8"` [INFO] [stderr] Checking serde v1.0.12 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Compiling structopt-derive v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.12 [INFO] [stderr] Checking csv-core v0.1.3 [INFO] [stderr] Checking csv v1.0.0-beta.4 [INFO] [stderr] Checking paco v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:47:41 [INFO] [stderr] | [INFO] [stderr] 47 | let pairs = counts.entry(count).or_insert(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | println!("{}:\t{:?}", key, counts.get(key).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&counts[key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:47:41 [INFO] [stderr] | [INFO] [stderr] 47 | let pairs = counts.entry(count).or_insert(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | println!("{}:\t{:?}", key, counts.get(key).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&counts[key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.32s [INFO] running `"docker" "inspect" "f204714a74504bd97f00562a0d5f272e911ba77a336643d9f64d67669b6892b8"` [INFO] running `"docker" "rm" "-f" "f204714a74504bd97f00562a0d5f272e911ba77a336643d9f64d67669b6892b8"` [INFO] [stdout] f204714a74504bd97f00562a0d5f272e911ba77a336643d9f64d67669b6892b8