[INFO] updating cached repository mwc10/sd3norm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mwc10/sd3norm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mwc10/sd3norm" "work/ex/clippy-test-run/sources/stable/gh/mwc10/sd3norm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mwc10/sd3norm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mwc10/sd3norm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mwc10/sd3norm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mwc10/sd3norm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0b56e682c664e46a9947cfb7257934102b6b9e41 [INFO] sha for GitHub repo mwc10/sd3norm: 0b56e682c664e46a9947cfb7257934102b6b9e41 [INFO] validating manifest of mwc10/sd3norm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mwc10/sd3norm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mwc10/sd3norm [INFO] finished frobbing mwc10/sd3norm [INFO] frobbed toml for mwc10/sd3norm written to work/ex/clippy-test-run/sources/stable/gh/mwc10/sd3norm/Cargo.toml [INFO] started frobbing mwc10/sd3norm [INFO] finished frobbing mwc10/sd3norm [INFO] frobbed toml for mwc10/sd3norm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mwc10/sd3norm/Cargo.toml [INFO] crate mwc10/sd3norm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mwc10/sd3norm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mwc10/sd3norm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b28abb7edcd2aab736faa78a975935a4b096468a3281a7ba776a3cd2d5cb6b51 [INFO] running `"docker" "start" "-a" "b28abb7edcd2aab736faa78a975935a4b096468a3281a7ba776a3cd2d5cb6b51"` [INFO] [stderr] Compiling miniz_oxide_c_api v0.1.3 [INFO] [stderr] Checking miniz_oxide v0.1.3 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Compiling serde_derive v1.0.69 [INFO] [stderr] Checking flexi_logger v0.8.4 [INFO] [stderr] Checking quick-xml v0.12.1 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking zip v0.3.3 [INFO] [stderr] Checking calamine v0.14.1 [INFO] [stderr] Checking sd3norm v0.5.2 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sd3.rs:167:18 [INFO] [stderr] | [INFO] [stderr] 167 | val: 484321.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `484_321.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sd3.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | 1835.801527, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1_835.801_527` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sd3.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | 61722160.0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `61_722_160.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sd3.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | 21931516981.0, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `21_931_516_981.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sd3.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | 380965.0582, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `380_965.058_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sd3.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | 1.494886037, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1.494_886_037` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sd3.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | 0.060278, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.060_278` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/si.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | fn unit_type(&self) -> UnitType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/si.rs:70:15 [INFO] [stderr] | [INFO] [stderr] 70 | fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/si.rs:97:18 [INFO] [stderr] | [INFO] [stderr] 97 | fn si_factor(&self) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/utils.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / if diff <= (largest * tol / 100.0) [INFO] [stderr] 11 | | { true } else { false } [INFO] [stderr] | |___________________________^ help: you can reduce it to: `diff <= (largest * tol / 100.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match ::std::env::var("RUST_BACKTRACE").as_ref().map(|s| s.as_str()) { [INFO] [stderr] 61 | | Ok("1") => error!("Backtrace:\n{}", e.backtrace()), [INFO] [stderr] 62 | | _ => (), [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok("1") = ::std::env::var("RUST_BACKTRACE").as_ref().map(|s| s.as_str()) { error!("Backtrace:\n{}", e.backtrace()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | / !file.as_ref() [INFO] [stderr] 231 | | .file_stem() [INFO] [stderr] 232 | | .filter(|s| s.to_string_lossy().starts_with("~")) [INFO] [stderr] 233 | | .is_some() [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 230 | file.as_ref() [INFO] [stderr] 231 | .file_stem() [INFO] [stderr] 232 | .filter(|s| s.to_string_lossy().starts_with("~")).is_none() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:232:53 [INFO] [stderr] | [INFO] [stderr] 232 | .filter(|s| s.to_string_lossy().starts_with("~")) [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:242:14 [INFO] [stderr] | [INFO] [stderr] 242 | .ok_or(format_err!("the input was not a file"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("the input was not a file"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/si.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | fn unit_type(&self) -> UnitType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/si.rs:70:15 [INFO] [stderr] | [INFO] [stderr] 70 | fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/si.rs:97:18 [INFO] [stderr] | [INFO] [stderr] 97 | fn si_factor(&self) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match ::std::env::var("RUST_BACKTRACE").as_ref().map(|s| s.as_str()) { [INFO] [stderr] 61 | | Ok("1") => error!("Backtrace:\n{}", e.backtrace()), [INFO] [stderr] 62 | | _ => (), [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok("1") = ::std::env::var("RUST_BACKTRACE").as_ref().map(|s| s.as_str()) { error!("Backtrace:\n{}", e.backtrace()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | / !file.as_ref() [INFO] [stderr] 231 | | .file_stem() [INFO] [stderr] 232 | | .filter(|s| s.to_string_lossy().starts_with("~")) [INFO] [stderr] 233 | | .is_some() [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 230 | file.as_ref() [INFO] [stderr] 231 | .file_stem() [INFO] [stderr] 232 | .filter(|s| s.to_string_lossy().starts_with("~")).is_none() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:232:53 [INFO] [stderr] | [INFO] [stderr] 232 | .filter(|s| s.to_string_lossy().starts_with("~")) [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:242:14 [INFO] [stderr] | [INFO] [stderr] 242 | .ok_or(format_err!("the input was not a file"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("the input was not a file"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.56s [INFO] running `"docker" "inspect" "b28abb7edcd2aab736faa78a975935a4b096468a3281a7ba776a3cd2d5cb6b51"` [INFO] running `"docker" "rm" "-f" "b28abb7edcd2aab736faa78a975935a4b096468a3281a7ba776a3cd2d5cb6b51"` [INFO] [stdout] b28abb7edcd2aab736faa78a975935a4b096468a3281a7ba776a3cd2d5cb6b51