[INFO] updating cached repository mwalczyk/gray_code_rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mwalczyk/gray_code_rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mwalczyk/gray_code_rs" "work/ex/clippy-test-run/sources/stable/gh/mwalczyk/gray_code_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mwalczyk/gray_code_rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mwalczyk/gray_code_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mwalczyk/gray_code_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mwalczyk/gray_code_rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5f2f1d79e5be46f0bb24344cc18bdaa3d4d54a2d [INFO] sha for GitHub repo mwalczyk/gray_code_rs: 5f2f1d79e5be46f0bb24344cc18bdaa3d4d54a2d [INFO] validating manifest of mwalczyk/gray_code_rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mwalczyk/gray_code_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mwalczyk/gray_code_rs [INFO] finished frobbing mwalczyk/gray_code_rs [INFO] frobbed toml for mwalczyk/gray_code_rs written to work/ex/clippy-test-run/sources/stable/gh/mwalczyk/gray_code_rs/Cargo.toml [INFO] started frobbing mwalczyk/gray_code_rs [INFO] finished frobbing mwalczyk/gray_code_rs [INFO] frobbed toml for mwalczyk/gray_code_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mwalczyk/gray_code_rs/Cargo.toml [INFO] crate mwalczyk/gray_code_rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mwalczyk/gray_code_rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mwalczyk/gray_code_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a1e3942a71f4b5b8a83531c50cba6a02edc0748322e034e636af0e2d80e4c888 [INFO] running `"docker" "start" "-a" "a1e3942a71f4b5b8a83531c50cba6a02edc0748322e034e636af0e2d80e4c888"` [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking num-bigint v0.1.40 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking rust-test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `orientation` [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | let orientation = length; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_orientation` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | for (x, y, pixel) in image_buffer.enumerate_pixels_mut() { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `HORIZONTAL` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | HORIZONTAL [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | let subdivisions = (length as f64).log(2.0).ceil() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | let ref mut fout = File::create(&Path::new(&file_name)).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------------------- help: try: `let fout = &mut File::create(&Path::new(&file_name)).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `orientation` [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | let orientation = length; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_orientation` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | for (x, y, pixel) in image_buffer.enumerate_pixels_mut() { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `HORIZONTAL` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | HORIZONTAL [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | let subdivisions = (length as f64).log(2.0).ceil() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | let ref mut fout = File::create(&Path::new(&file_name)).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------------------- help: try: `let fout = &mut File::create(&Path::new(&file_name)).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.92s [INFO] running `"docker" "inspect" "a1e3942a71f4b5b8a83531c50cba6a02edc0748322e034e636af0e2d80e4c888"` [INFO] running `"docker" "rm" "-f" "a1e3942a71f4b5b8a83531c50cba6a02edc0748322e034e636af0e2d80e4c888"` [INFO] [stdout] a1e3942a71f4b5b8a83531c50cba6a02edc0748322e034e636af0e2d80e4c888