[INFO] updating cached repository mvlabat/rust_mnist_gradient_descent [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mvlabat/rust_mnist_gradient_descent [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mvlabat/rust_mnist_gradient_descent" "work/ex/clippy-test-run/sources/stable/gh/mvlabat/rust_mnist_gradient_descent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mvlabat/rust_mnist_gradient_descent'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mvlabat/rust_mnist_gradient_descent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mvlabat/rust_mnist_gradient_descent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mvlabat/rust_mnist_gradient_descent'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b26648827dd1873edf9ec7002b4ad8773e5db0be [INFO] sha for GitHub repo mvlabat/rust_mnist_gradient_descent: b26648827dd1873edf9ec7002b4ad8773e5db0be [INFO] validating manifest of mvlabat/rust_mnist_gradient_descent on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mvlabat/rust_mnist_gradient_descent on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mvlabat/rust_mnist_gradient_descent [INFO] finished frobbing mvlabat/rust_mnist_gradient_descent [INFO] frobbed toml for mvlabat/rust_mnist_gradient_descent written to work/ex/clippy-test-run/sources/stable/gh/mvlabat/rust_mnist_gradient_descent/Cargo.toml [INFO] started frobbing mvlabat/rust_mnist_gradient_descent [INFO] finished frobbing mvlabat/rust_mnist_gradient_descent [INFO] frobbed toml for mvlabat/rust_mnist_gradient_descent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mvlabat/rust_mnist_gradient_descent/Cargo.toml [INFO] crate mvlabat/rust_mnist_gradient_descent has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mvlabat/rust_mnist_gradient_descent against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mvlabat/rust_mnist_gradient_descent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3b7821da1da91ca2c2f608faed800e4877f078e0bf89dd60d1bf8b57ac3799ae [INFO] running `"docker" "start" "-a" "3b7821da1da91ca2c2f608faed800e4877f078e0bf89dd60d1bf8b57ac3799ae"` [INFO] [stderr] Checking mnist v0.4.0 [INFO] [stderr] Checking alga v0.5.2 [INFO] [stderr] Checking nalgebra v0.13.1 [INFO] [stderr] Checking rust_mnist_gradient_descent v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `hypothesis` [INFO] [stderr] --> src/main.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | fn hypothesis(weigts: &WeightVector, image: &Image) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_i` [INFO] [stderr] --> src/main.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | fn print_i(image: &WeightVector) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `image` [INFO] [stderr] --> src/main.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | for i in 1..image.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 36 | for (i, ) in image.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | fn weight(examples: &Vec<(u32, WeightVector)>, number_learning: u32) -> WeightVector { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(u32, WeightVector)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | let label = trn_lbl[i] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(trn_lbl[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:103:80 [INFO] [stderr] | [INFO] [stderr] 103 | let iter = trn_img[i * 28 * 28..(i + 1) * 28 * 28].iter().map(|&x| x as f32 / 255.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:110:80 [INFO] [stderr] | [INFO] [stderr] 110 | let iter = tst_img[i * 28 * 28..(i + 1) * 28 * 28].iter().map(|&x| x as f32 / 255.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: function is never used: `hypothesis` [INFO] [stderr] --> src/main.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | fn hypothesis(weigts: &WeightVector, image: &Image) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_i` [INFO] [stderr] --> src/main.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | fn print_i(image: &WeightVector) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `image` [INFO] [stderr] --> src/main.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | for i in 1..image.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 36 | for (i, ) in image.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | fn weight(examples: &Vec<(u32, WeightVector)>, number_learning: u32) -> WeightVector { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(u32, WeightVector)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | let label = trn_lbl[i] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(trn_lbl[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:103:80 [INFO] [stderr] | [INFO] [stderr] 103 | let iter = trn_img[i * 28 * 28..(i + 1) * 28 * 28].iter().map(|&x| x as f32 / 255.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:110:80 [INFO] [stderr] | [INFO] [stderr] 110 | let iter = tst_img[i * 28 * 28..(i + 1) * 28 * 28].iter().map(|&x| x as f32 / 255.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.05s [INFO] running `"docker" "inspect" "3b7821da1da91ca2c2f608faed800e4877f078e0bf89dd60d1bf8b57ac3799ae"` [INFO] running `"docker" "rm" "-f" "3b7821da1da91ca2c2f608faed800e4877f078e0bf89dd60d1bf8b57ac3799ae"` [INFO] [stdout] 3b7821da1da91ca2c2f608faed800e4877f078e0bf89dd60d1bf8b57ac3799ae