[INFO] updating cached repository musically-ut/tz_cli.rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/musically-ut/tz_cli.rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/musically-ut/tz_cli.rs" "work/ex/clippy-test-run/sources/stable/gh/musically-ut/tz_cli.rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/musically-ut/tz_cli.rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/musically-ut/tz_cli.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/musically-ut/tz_cli.rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/musically-ut/tz_cli.rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d519ee4b10024f6cb1750b85e979ecbb5a9ffa71
[INFO] sha for GitHub repo musically-ut/tz_cli.rs: d519ee4b10024f6cb1750b85e979ecbb5a9ffa71
[INFO] validating manifest of musically-ut/tz_cli.rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of musically-ut/tz_cli.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing musically-ut/tz_cli.rs
[INFO] finished frobbing musically-ut/tz_cli.rs
[INFO] frobbed toml for musically-ut/tz_cli.rs written to work/ex/clippy-test-run/sources/stable/gh/musically-ut/tz_cli.rs/Cargo.toml
[INFO] started frobbing musically-ut/tz_cli.rs
[INFO] finished frobbing musically-ut/tz_cli.rs
[INFO] frobbed toml for musically-ut/tz_cli.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/musically-ut/tz_cli.rs/Cargo.toml
[INFO] crate musically-ut/tz_cli.rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting musically-ut/tz_cli.rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/musically-ut/tz_cli.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6307087bf51fb377a03da79dc86f4f75e7e625bba1b5af811e743f3889c35211
[INFO] running `"docker" "start" "-a" "6307087bf51fb377a03da79dc86f4f75e7e625bba1b5af811e743f3889c35211"`
[INFO] [stderr]    Compiling regex-syntax v0.3.9
[INFO] [stderr]    Compiling utf8-ranges v0.1.3
[INFO] [stderr]    Compiling memchr v0.1.11
[INFO] [stderr]    Compiling thread-id v2.0.0
[INFO] [stderr]    Compiling thread_local v0.2.7
[INFO] [stderr]    Compiling aho-corasick v0.5.3
[INFO] [stderr]    Compiling regex v0.1.80
[INFO] [stderr]    Compiling parse-zoneinfo v0.1.0
[INFO] [stderr]    Compiling chrono-tz v0.3.0
[INFO] [stderr]     Checking tz_cli v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         return Ok(PathBuf::from(&args[1]));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(PathBuf::from(&args[1]))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 | /         return match opt_home {
[INFO] [stderr] 23 | |                    &Some(ref home) => {
[INFO] [stderr] 24 | |                         let mut abs_path = home.clone();
[INFO] [stderr] 25 | |                         abs_path.push(PathBuf::from(".tz.rc"));
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |                    &None => Err("No home directory!".to_string()),
[INFO] [stderr] 29 | |                };
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 22 |         match opt_home {
[INFO] [stderr] 23 |                    &Some(ref home) => {
[INFO] [stderr] 24 |                         let mut abs_path = home.clone();
[INFO] [stderr] 25 |                         abs_path.push(PathBuf::from(".tz.rc"));
[INFO] [stderr] 26 |                         Ok(abs_path)
[INFO] [stderr] 27 |                    }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:61:20
[INFO] [stderr]    |
[INFO] [stderr] 61 |     let opt_home = env::home_dir();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:16:30
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub fn get_tz_file<'a>(args: &'a Vec<String>,
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:22:16
[INFO] [stderr]    |
[INFO] [stderr] 22 |           return match opt_home {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 23 | |                    &Some(ref home) => {
[INFO] [stderr] 24 | |                         let mut abs_path = home.clone();
[INFO] [stderr] 25 | |                         abs_path.push(PathBuf::from(".tz.rc"));
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |                    &None => Err("No home directory!".to_string()),
[INFO] [stderr] 29 | |                };
[INFO] [stderr]    | |________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 22 |         return match *opt_home {
[INFO] [stderr] 23 |                    Some(ref home) => {
[INFO] [stderr] 24 |                         let mut abs_path = home.clone();
[INFO] [stderr] 25 |                         abs_path.push(PathBuf::from(".tz.rc"));
[INFO] [stderr] 26 |                         Ok(abs_path)
[INFO] [stderr] 27 |                    }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:52:23
[INFO] [stderr]    |
[INFO] [stderr] 52 | pub fn pad_to_size(s: &String, desired_len: usize) -> String {
[INFO] [stderr]    |                       ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 52 | pub fn pad_to_size(s: &str, desired_len: usize) -> String {
[INFO] [stderr]    |                       ^^^^
[INFO] [stderr] help: change `s.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 53 |     let mut s2 = s.to_string();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         return Ok(PathBuf::from(&args[1]));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(PathBuf::from(&args[1]))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 | /         return match opt_home {
[INFO] [stderr] 23 | |                    &Some(ref home) => {
[INFO] [stderr] 24 | |                         let mut abs_path = home.clone();
[INFO] [stderr] 25 | |                         abs_path.push(PathBuf::from(".tz.rc"));
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |                    &None => Err("No home directory!".to_string()),
[INFO] [stderr] 29 | |                };
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 22 |         match opt_home {
[INFO] [stderr] 23 |                    &Some(ref home) => {
[INFO] [stderr] 24 |                         let mut abs_path = home.clone();
[INFO] [stderr] 25 |                         abs_path.push(PathBuf::from(".tz.rc"));
[INFO] [stderr] 26 |                         Ok(abs_path)
[INFO] [stderr] 27 |                    }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:61:20
[INFO] [stderr]    |
[INFO] [stderr] 61 |     let opt_home = env::home_dir();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:16:30
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub fn get_tz_file<'a>(args: &'a Vec<String>,
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:22:16
[INFO] [stderr]    |
[INFO] [stderr] 22 |           return match opt_home {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 23 | |                    &Some(ref home) => {
[INFO] [stderr] 24 | |                         let mut abs_path = home.clone();
[INFO] [stderr] 25 | |                         abs_path.push(PathBuf::from(".tz.rc"));
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |                    &None => Err("No home directory!".to_string()),
[INFO] [stderr] 29 | |                };
[INFO] [stderr]    | |________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 22 |         return match *opt_home {
[INFO] [stderr] 23 |                    Some(ref home) => {
[INFO] [stderr] 24 |                         let mut abs_path = home.clone();
[INFO] [stderr] 25 |                         abs_path.push(PathBuf::from(".tz.rc"));
[INFO] [stderr] 26 |                         Ok(abs_path)
[INFO] [stderr] 27 |                    }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:52:23
[INFO] [stderr]    |
[INFO] [stderr] 52 | pub fn pad_to_size(s: &String, desired_len: usize) -> String {
[INFO] [stderr]    |                       ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 52 | pub fn pad_to_size(s: &str, desired_len: usize) -> String {
[INFO] [stderr]    |                       ^^^^
[INFO] [stderr] help: change `s.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 53 |     let mut s2 = s.to_string();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 31.70s
[INFO] running `"docker" "inspect" "6307087bf51fb377a03da79dc86f4f75e7e625bba1b5af811e743f3889c35211"`
[INFO] running `"docker" "rm" "-f" "6307087bf51fb377a03da79dc86f4f75e7e625bba1b5af811e743f3889c35211"`
[INFO] [stdout] 6307087bf51fb377a03da79dc86f4f75e7e625bba1b5af811e743f3889c35211