[INFO] updating cached repository murphym18/huffman_code [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/murphym18/huffman_code [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/murphym18/huffman_code" "work/ex/clippy-test-run/sources/stable/gh/murphym18/huffman_code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/murphym18/huffman_code'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/murphym18/huffman_code" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/murphym18/huffman_code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/murphym18/huffman_code'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f3ea7042d973b2b4d28d24284e0d37efc1867cb3 [INFO] sha for GitHub repo murphym18/huffman_code: f3ea7042d973b2b4d28d24284e0d37efc1867cb3 [INFO] validating manifest of murphym18/huffman_code on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of murphym18/huffman_code on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing murphym18/huffman_code [INFO] finished frobbing murphym18/huffman_code [INFO] frobbed toml for murphym18/huffman_code written to work/ex/clippy-test-run/sources/stable/gh/murphym18/huffman_code/Cargo.toml [INFO] started frobbing murphym18/huffman_code [INFO] finished frobbing murphym18/huffman_code [INFO] frobbed toml for murphym18/huffman_code written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/murphym18/huffman_code/Cargo.toml [INFO] crate murphym18/huffman_code has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting murphym18/huffman_code against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/murphym18/huffman_code:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a83235dd6c85d091ed503d511382a3e4581655f71af6f9f2497d3ae509353f19 [INFO] running `"docker" "start" "-a" "a83235dd6c85d091ed503d511382a3e4581655f71af6f9f2497d3ae509353f19"` [INFO] [stderr] Checking huffman_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/lib.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Cursor` [INFO] [stderr] --> src/lib.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{Read, Write, Cursor}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/lib.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Cursor` [INFO] [stderr] --> src/lib.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{Read, Write, Cursor}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `left` [INFO] [stderr] --> src/lib.rs:171:26 [INFO] [stderr] | [INFO] [stderr] 171 | Node {count, ref left, ref right} => count, [INFO] [stderr] | ^^^^ help: try ignoring the field: `left: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `right` [INFO] [stderr] --> src/lib.rs:171:36 [INFO] [stderr] | [INFO] [stderr] 171 | Node {count, ref left, ref right} => count, [INFO] [stderr] | ^^^^^ help: try ignoring the field: `right: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/lib.rs:172:22 [INFO] [stderr] | [INFO] [stderr] 172 | Leaf {count, value} => count [INFO] [stderr] | ^^^^^ help: try ignoring the field: `value: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/lib.rs:178:15 [INFO] [stderr] | [INFO] [stderr] 178 | Node {count, ref left, ref right} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `count: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/lib.rs:235:19 [INFO] [stderr] | [INFO] [stderr] 235 | Leaf {count, value} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `count: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/lib.rs:240:19 [INFO] [stderr] | [INFO] [stderr] 240 | Node {count, ref left, ref right} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `count: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/lib.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | let p = 97 as u8; [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/lib.rs:346:26 [INFO] [stderr] | [INFO] [stderr] 346 | Leaf {count, value} => size = size + count, [INFO] [stderr] | ^^^^^ help: try ignoring the field: `value: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/lib.rs:395:15 [INFO] [stderr] | [INFO] [stderr] 395 | Node {count, ref left, ref right} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `count: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/lib.rs:403:15 [INFO] [stderr] | [INFO] [stderr] 403 | Leaf {count, value} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `count: _` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | let mut tree = make_tree(table_vec); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | let mut tree = make_tree(v); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | let mut buf: [u8; 8] = unsafe { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:388:9 [INFO] [stderr] | [INFO] [stderr] 388 | let mut bits = BitString::new(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:393:29 [INFO] [stderr] | [INFO] [stderr] 393 | fn traverse(current: &Tree, mut bits: BitString, table: &mut HashMap) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `byte_string` [INFO] [stderr] --> src/lib.rs:138:1 [INFO] [stderr] | [INFO] [stderr] 138 | fn byte_string(data: u8, num_bits: u8) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: item `BitString` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / impl BitString { [INFO] [stderr] 32 | | pub fn new() -> BitString { [INFO] [stderr] 33 | | BitString { data: Vec::new() } [INFO] [stderr] 34 | | } [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `BitString` [INFO] [stderr] --> src/lib.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> BitString { [INFO] [stderr] 33 | | BitString { data: Vec::new() } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | self.next_byte = self.next_byte | (bits.get(i) << self.next_bit_index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next_byte |= (bits.get(i) << self.next_bit_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | self.output.write(&a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | self.next_bit = self.next_bit + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next_bit += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | output.write(&[value]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:237:17 [INFO] [stderr] | [INFO] [stderr] 237 | num_written = num_written + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_written += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | f.seek(SeekFrom::Start(0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:321:5 [INFO] [stderr] | [INFO] [stderr] 321 | output.write_all(&list_len_buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:334:17 [INFO] [stderr] | [INFO] [stderr] 334 | output.write_all(&buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:346:36 [INFO] [stderr] | [INFO] [stderr] 346 | Leaf {count, value} => size = size + count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `size += count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:353:5 [INFO] [stderr] | [INFO] [stderr] 353 | output.write_all(&buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:437:9 [INFO] [stderr] | [INFO] [stderr] 437 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `left` [INFO] [stderr] --> src/lib.rs:171:26 [INFO] [stderr] | [INFO] [stderr] 171 | Node {count, ref left, ref right} => count, [INFO] [stderr] | ^^^^ help: try ignoring the field: `left: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `right` [INFO] [stderr] --> src/lib.rs:171:36 [INFO] [stderr] | [INFO] [stderr] 171 | Node {count, ref left, ref right} => count, [INFO] [stderr] | ^^^^^ help: try ignoring the field: `right: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/lib.rs:172:22 [INFO] [stderr] | [INFO] [stderr] 172 | Leaf {count, value} => count [INFO] [stderr] | ^^^^^ help: try ignoring the field: `value: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/lib.rs:178:15 [INFO] [stderr] | [INFO] [stderr] 178 | Node {count, ref left, ref right} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `count: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/lib.rs:235:19 [INFO] [stderr] | [INFO] [stderr] 235 | Leaf {count, value} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `count: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/lib.rs:240:19 [INFO] [stderr] | [INFO] [stderr] 240 | Node {count, ref left, ref right} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `count: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/lib.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | let p = 97 as u8; [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/lib.rs:346:26 [INFO] [stderr] | [INFO] [stderr] 346 | Leaf {count, value} => size = size + count, [INFO] [stderr] | ^^^^^ help: try ignoring the field: `value: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/lib.rs:395:15 [INFO] [stderr] | [INFO] [stderr] 395 | Node {count, ref left, ref right} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `count: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/lib.rs:403:15 [INFO] [stderr] | [INFO] [stderr] 403 | Leaf {count, value} => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `count: _` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | let mut tree = make_tree(table_vec); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | let mut tree = make_tree(v); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | let mut buf: [u8; 8] = unsafe { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:388:9 [INFO] [stderr] | [INFO] [stderr] 388 | let mut bits = BitString::new(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:393:29 [INFO] [stderr] | [INFO] [stderr] 393 | fn traverse(current: &Tree, mut bits: BitString, table: &mut HashMap) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `byte_string` [INFO] [stderr] --> src/lib.rs:138:1 [INFO] [stderr] | [INFO] [stderr] 138 | fn byte_string(data: u8, num_bits: u8) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: item `BitString` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / impl BitString { [INFO] [stderr] 32 | | pub fn new() -> BitString { [INFO] [stderr] 33 | | BitString { data: Vec::new() } [INFO] [stderr] 34 | | } [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `BitString` [INFO] [stderr] --> src/lib.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> BitString { [INFO] [stderr] 33 | | BitString { data: Vec::new() } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | self.next_byte = self.next_byte | (bits.get(i) << self.next_bit_index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next_byte |= (bits.get(i) << self.next_bit_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | self.output.write(&a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | self.next_bit = self.next_bit + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next_bit += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | output.write(&[value]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:237:17 [INFO] [stderr] | [INFO] [stderr] 237 | num_written = num_written + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_written += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | f.seek(SeekFrom::Start(0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:321:5 [INFO] [stderr] | [INFO] [stderr] 321 | output.write_all(&list_len_buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:334:17 [INFO] [stderr] | [INFO] [stderr] 334 | output.write_all(&buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:346:36 [INFO] [stderr] | [INFO] [stderr] 346 | Leaf {count, value} => size = size + count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `size += count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:353:5 [INFO] [stderr] | [INFO] [stderr] 353 | output.write_all(&buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:437:9 [INFO] [stderr] | [INFO] [stderr] 437 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.24s [INFO] running `"docker" "inspect" "a83235dd6c85d091ed503d511382a3e4581655f71af6f9f2497d3ae509353f19"` [INFO] running `"docker" "rm" "-f" "a83235dd6c85d091ed503d511382a3e4581655f71af6f9f2497d3ae509353f19"` [INFO] [stdout] a83235dd6c85d091ed503d511382a3e4581655f71af6f9f2497d3ae509353f19