[INFO] updating cached repository murnux/roffee [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/murnux/roffee [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/murnux/roffee" "work/ex/clippy-test-run/sources/stable/gh/murnux/roffee"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/murnux/roffee'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/murnux/roffee" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/murnux/roffee"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/murnux/roffee'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7f9754c7f6d29069dfd3c1566eb9fc42a5e9a78e [INFO] sha for GitHub repo murnux/roffee: 7f9754c7f6d29069dfd3c1566eb9fc42a5e9a78e [INFO] validating manifest of murnux/roffee on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of murnux/roffee on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing murnux/roffee [INFO] finished frobbing murnux/roffee [INFO] frobbed toml for murnux/roffee written to work/ex/clippy-test-run/sources/stable/gh/murnux/roffee/Cargo.toml [INFO] started frobbing murnux/roffee [INFO] finished frobbing murnux/roffee [INFO] frobbed toml for murnux/roffee written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/murnux/roffee/Cargo.toml [INFO] crate murnux/roffee has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting murnux/roffee against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/murnux/roffee:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5d1f6d9312f3c37cbc35df3e66e7e3cbf080fce9f6274b4a01d445aace2695e [INFO] running `"docker" "start" "-a" "d5d1f6d9312f3c37cbc35df3e66e7e3cbf080fce9f6274b4a01d445aace2695e"` [INFO] [stderr] Compiling libsqlite3-sys v0.9.1 [INFO] [stderr] Checking rusqlite v0.13.0 [INFO] [stderr] Checking roffee v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `f` [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let f = File::create(path).expect("Error creating DB."); [INFO] [stderr] | ^ help: consider using `_f` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f` [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let f = File::create(path).expect("Error creating DB."); [INFO] [stderr] | ^ help: consider using `_f` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | x = x + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:96:8 [INFO] [stderr] | [INFO] [stderr] 96 | if Path::new(db_path).exists() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!Path::new(db_path).exists()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | x = x + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:96:8 [INFO] [stderr] | [INFO] [stderr] 96 | if Path::new(db_path).exists() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!Path::new(db_path).exists()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.65s [INFO] running `"docker" "inspect" "d5d1f6d9312f3c37cbc35df3e66e7e3cbf080fce9f6274b4a01d445aace2695e"` [INFO] running `"docker" "rm" "-f" "d5d1f6d9312f3c37cbc35df3e66e7e3cbf080fce9f6274b4a01d445aace2695e"` [INFO] [stdout] d5d1f6d9312f3c37cbc35df3e66e7e3cbf080fce9f6274b4a01d445aace2695e