[INFO] updating cached repository murarth/freecell-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/murarth/freecell-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/murarth/freecell-rs" "work/ex/clippy-test-run/sources/stable/gh/murarth/freecell-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/murarth/freecell-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/murarth/freecell-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/murarth/freecell-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/murarth/freecell-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5533bba2fc61fbad84e8687c85c80ed04e26a266
[INFO] sha for GitHub repo murarth/freecell-rs: 5533bba2fc61fbad84e8687c85c80ed04e26a266
[INFO] validating manifest of murarth/freecell-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of murarth/freecell-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing murarth/freecell-rs
[INFO] finished frobbing murarth/freecell-rs
[INFO] frobbed toml for murarth/freecell-rs written to work/ex/clippy-test-run/sources/stable/gh/murarth/freecell-rs/Cargo.toml
[INFO] started frobbing murarth/freecell-rs
[INFO] finished frobbing murarth/freecell-rs
[INFO] frobbed toml for murarth/freecell-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/murarth/freecell-rs/Cargo.toml
[INFO] crate murarth/freecell-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting murarth/freecell-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/murarth/freecell-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1735d9bbd1e03410dfe3afda491368f54b946fe64efca02793b0f2edb439374d
[INFO] running `"docker" "start" "-a" "1735d9bbd1e03410dfe3afda491368f54b946fe64efca02793b0f2edb439374d"`
[INFO] [stderr]     Checking phf_shared v0.7.22
[INFO] [stderr]     Checking memchr v1.0.2
[INFO] [stderr]     Checking smallvec v0.6.3
[INFO] [stderr]    Compiling terminfo v0.5.0
[INFO] [stderr]     Checking nix v0.7.0
[INFO] [stderr]     Checking nom v3.2.1
[INFO] [stderr]     Checking phf v0.7.22
[INFO] [stderr]     Checking smallstr v0.1.0
[INFO] [stderr]     Checking mortal v0.1.3
[INFO] [stderr]     Checking freecell v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/freecell.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             suit: suit,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `suit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/freecell.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             value: value,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/freecell_game.rs:197:13
[INFO] [stderr]     |
[INFO] [stderr] 197 |             stats: stats,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `stats`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/game.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             title: title,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/game.rs:138:13
[INFO] [stderr]     |
[INFO] [stderr] 138 |             duration: duration,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/freecell.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             suit: suit,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `suit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/freecell.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             value: value,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/freecell_game.rs:197:13
[INFO] [stderr]     |
[INFO] [stderr] 197 |             stats: stats,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `stats`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/game.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             title: title,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/game.rs:138:13
[INFO] [stderr]     |
[INFO] [stderr] 138 |             duration: duration,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/freecell_game.rs:16:19
[INFO] [stderr]    |
[INFO] [stderr] 16 | const HELP_TEXT: &'static str = "\
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/freecell_game.rs:613:16
[INFO] [stderr]     |
[INFO] [stderr] 613 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 614 | |             if self.fc.reserve_free() {
[INFO] [stderr] 615 | |                 self.push_undo();
[INFO] [stderr] 616 | |                 let c = self.fc.pop_tableau(a as usize);
[INFO] [stderr] ...   |
[INFO] [stderr] 620 | |             }
[INFO] [stderr] 621 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 613 |         } else if self.fc.reserve_free() {
[INFO] [stderr] 614 |     self.push_undo();
[INFO] [stderr] 615 |     let c = self.fc.pop_tableau(a as usize);
[INFO] [stderr] 616 |     self.fc.add_to_reserve(c);
[INFO] [stderr] 617 | } else {
[INFO] [stderr] 618 |     game.set_message("No free reserve slots", one_sec());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/freecell_game.rs:119:16
[INFO] [stderr]     |
[INFO] [stderr] 119 |     let home = home_dir().expect("cannot find home dir");
[INFO] [stderr]     |                ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/freecell_game.rs:118:9
[INFO] [stderr]     |
[INFO] [stderr] 118 |     use std::env::home_dir;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/freecell_game.rs:16:19
[INFO] [stderr]    |
[INFO] [stderr] 16 | const HELP_TEXT: &'static str = "\
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/freecell_game.rs:613:16
[INFO] [stderr]     |
[INFO] [stderr] 613 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 614 | |             if self.fc.reserve_free() {
[INFO] [stderr] 615 | |                 self.push_undo();
[INFO] [stderr] 616 | |                 let c = self.fc.pop_tableau(a as usize);
[INFO] [stderr] ...   |
[INFO] [stderr] 620 | |             }
[INFO] [stderr] 621 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 613 |         } else if self.fc.reserve_free() {
[INFO] [stderr] 614 |     self.push_undo();
[INFO] [stderr] 615 |     let c = self.fc.pop_tableau(a as usize);
[INFO] [stderr] 616 |     self.fc.add_to_reserve(c);
[INFO] [stderr] 617 | } else {
[INFO] [stderr] 618 |     game.set_message("No free reserve slots", one_sec());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/freecell_game.rs:119:16
[INFO] [stderr]     |
[INFO] [stderr] 119 |     let home = home_dir().expect("cannot find home dir");
[INFO] [stderr]     |                ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/freecell_game.rs:118:9
[INFO] [stderr]     |
[INFO] [stderr] 118 |     use std::env::home_dir;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/freecell.rs:31:21
[INFO] [stderr]    |
[INFO] [stderr] 31 |     pub fn is_lower(&self, other: Card) -> bool {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/freecell.rs:36:20
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn can_top(&self, other: Card) -> bool {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/freecell.rs:42:24
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn can_succeed(&self, other: Option<Card>) -> bool {
[INFO] [stderr]    |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/freecell.rs:80:23
[INFO] [stderr]    |
[INFO] [stderr] 80 |     pub fn term_color(&self) -> Option<TermColor> {
[INFO] [stderr]    |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/freecell.rs:99:21
[INFO] [stderr]    |
[INFO] [stderr] 99 |     pub fn as_index(&self) -> usize {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/freecell.rs:108:18
[INFO] [stderr]     |
[INFO] [stderr] 108 |     pub fn color(&self) -> Color {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/freecell.rs:115:17
[INFO] [stderr]     |
[INFO] [stderr] 115 |     pub fn char(&self) -> char {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `freecell::FreeCell`
[INFO] [stderr]    --> src/freecell.rs:158:5
[INFO] [stderr]     |
[INFO] [stderr] 158 | /     pub fn new() -> FreeCell {
[INFO] [stderr] 159 | |         FreeCell{
[INFO] [stderr] 160 | |             reserve: [None; RESERVE_SLOTS],
[INFO] [stderr] 161 | |             foundation: [None; FOUNDATION_SLOTS],
[INFO] [stderr] 162 | |             tableau: fill_tableau(new_deck()),
[INFO] [stderr] 163 | |         }
[INFO] [stderr] 164 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 151 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/freecell.rs:248:23
[INFO] [stderr]     |
[INFO] [stderr] 248 |         for (n, r) in self.reserve.clone().iter().cloned().enumerate() {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reserve`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `freecell_game::FreeCellGame`
[INFO] [stderr]    --> src/freecell_game.rs:189:5
[INFO] [stderr]     |
[INFO] [stderr] 189 | /     pub fn new() -> FreeCellGame {
[INFO] [stderr] 190 | |         let stats = match load_stats() {
[INFO] [stderr] 191 | |             Ok(stats) => stats,
[INFO] [stderr] 192 | |             Err(e) => panic!("failed to load stats: {}", e)
[INFO] [stderr] ...   |
[INFO] [stderr] 207 | |         }
[INFO] [stderr] 208 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 188 | impl Default for freecell_game::FreeCellGame {
[INFO] [stderr] 189 |     fn default() -> Self {
[INFO] [stderr] 190 |         Self::new()
[INFO] [stderr] 191 |     }
[INFO] [stderr] 192 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/freecell_game.rs:635:30
[INFO] [stderr]     |
[INFO] [stderr] 635 |                     for i in 1..size + 1 {
[INFO] [stderr]     |                              ^^^^^^^^^^^ help: use: `1..=size`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/freecell.rs:31:21
[INFO] [stderr]    |
[INFO] [stderr] 31 |     pub fn is_lower(&self, other: Card) -> bool {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/freecell.rs:36:20
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn can_top(&self, other: Card) -> bool {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/freecell.rs:42:24
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn can_succeed(&self, other: Option<Card>) -> bool {
[INFO] [stderr]    |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/freecell.rs:80:23
[INFO] [stderr]    |
[INFO] [stderr] 80 |     pub fn term_color(&self) -> Option<TermColor> {
[INFO] [stderr]    |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/freecell.rs:99:21
[INFO] [stderr]    |
[INFO] [stderr] 99 |     pub fn as_index(&self) -> usize {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/freecell.rs:108:18
[INFO] [stderr]     |
[INFO] [stderr] 108 |     pub fn color(&self) -> Color {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/freecell.rs:115:17
[INFO] [stderr]     |
[INFO] [stderr] 115 |     pub fn char(&self) -> char {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `freecell::FreeCell`
[INFO] [stderr]    --> src/freecell.rs:158:5
[INFO] [stderr]     |
[INFO] [stderr] 158 | /     pub fn new() -> FreeCell {
[INFO] [stderr] 159 | |         FreeCell{
[INFO] [stderr] 160 | |             reserve: [None; RESERVE_SLOTS],
[INFO] [stderr] 161 | |             foundation: [None; FOUNDATION_SLOTS],
[INFO] [stderr] 162 | |             tableau: fill_tableau(new_deck()),
[INFO] [stderr] 163 | |         }
[INFO] [stderr] 164 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 151 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/freecell.rs:248:23
[INFO] [stderr]     |
[INFO] [stderr] 248 |         for (n, r) in self.reserve.clone().iter().cloned().enumerate() {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reserve`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `freecell_game::FreeCellGame`
[INFO] [stderr]    --> src/freecell_game.rs:189:5
[INFO] [stderr]     |
[INFO] [stderr] 189 | /     pub fn new() -> FreeCellGame {
[INFO] [stderr] 190 | |         let stats = match load_stats() {
[INFO] [stderr] 191 | |             Ok(stats) => stats,
[INFO] [stderr] 192 | |             Err(e) => panic!("failed to load stats: {}", e)
[INFO] [stderr] ...   |
[INFO] [stderr] 207 | |         }
[INFO] [stderr] 208 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 188 | impl Default for freecell_game::FreeCellGame {
[INFO] [stderr] 189 |     fn default() -> Self {
[INFO] [stderr] 190 |         Self::new()
[INFO] [stderr] 191 |     }
[INFO] [stderr] 192 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/freecell_game.rs:635:30
[INFO] [stderr]     |
[INFO] [stderr] 635 |                     for i in 1..size + 1 {
[INFO] [stderr]     |                              ^^^^^^^^^^^ help: use: `1..=size`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 23.24s
[INFO] running `"docker" "inspect" "1735d9bbd1e03410dfe3afda491368f54b946fe64efca02793b0f2edb439374d"`
[INFO] running `"docker" "rm" "-f" "1735d9bbd1e03410dfe3afda491368f54b946fe64efca02793b0f2edb439374d"`
[INFO] [stdout] 1735d9bbd1e03410dfe3afda491368f54b946fe64efca02793b0f2edb439374d