[INFO] updating cached repository muchomacho/diplearn [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/muchomacho/diplearn [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/muchomacho/diplearn" "work/ex/clippy-test-run/sources/stable/gh/muchomacho/diplearn"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/muchomacho/diplearn'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/muchomacho/diplearn" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/muchomacho/diplearn"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/muchomacho/diplearn'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 985bce61eb23f4a2687fdd0cddbccaa46137bf82 [INFO] sha for GitHub repo muchomacho/diplearn: 985bce61eb23f4a2687fdd0cddbccaa46137bf82 [INFO] validating manifest of muchomacho/diplearn on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of muchomacho/diplearn on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing muchomacho/diplearn [INFO] finished frobbing muchomacho/diplearn [INFO] frobbed toml for muchomacho/diplearn written to work/ex/clippy-test-run/sources/stable/gh/muchomacho/diplearn/Cargo.toml [INFO] started frobbing muchomacho/diplearn [INFO] finished frobbing muchomacho/diplearn [INFO] frobbed toml for muchomacho/diplearn written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/muchomacho/diplearn/Cargo.toml [INFO] crate muchomacho/diplearn has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting muchomacho/diplearn against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/muchomacho/diplearn:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5e271b9499d4bed9885a62d2e4c62a61a54f198e884d24a629748b031712f7a [INFO] running `"docker" "start" "-a" "f5e271b9499d4bed9885a62d2e4c62a61a54f198e884d24a629748b031712f7a"` [INFO] [stderr] Checking diplearn v1.27.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mlp.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | dims: dims, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dims` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mlp.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | dims: dims, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dims` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mlp.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | static CONVERGE: f64 = 0.000000001; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mlp.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | return node_vals.into_iter().nth(self.layer_num - 1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node_vals.into_iter().nth(self.layer_num - 1).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mlp.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return node_vals; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node_vals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mlp.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | return error_grad; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `error_grad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numrs.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | return NumMatrix::new(trans); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NumMatrix::new(trans)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numrs.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numrs.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numrs.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numrs.rs:440:9 [INFO] [stderr] | [INFO] [stderr] 440 | return NumMatrix::new(out); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NumMatrix::new(out)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numrs.rs:453:9 [INFO] [stderr] | [INFO] [stderr] 453 | return NumMatrix::new(matrix); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NumMatrix::new(matrix)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mlp.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | static CONVERGE: f64 = 0.000000001; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mlp.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | return node_vals.into_iter().nth(self.layer_num - 1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node_vals.into_iter().nth(self.layer_num - 1).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mlp.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return node_vals; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node_vals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mlp.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | return error_grad; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `error_grad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numrs.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | return NumMatrix::new(trans); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NumMatrix::new(trans)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numrs.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numrs.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numrs.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numrs.rs:440:9 [INFO] [stderr] | [INFO] [stderr] 440 | return NumMatrix::new(out); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NumMatrix::new(out)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numrs.rs:453:9 [INFO] [stderr] | [INFO] [stderr] 453 | return NumMatrix::new(matrix); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NumMatrix::new(matrix)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `matrix`. [INFO] [stderr] --> src/mlp.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | for j in 0..dims[i] { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 36 | for in matrix.iter_mut().take(dims[i]) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `result`. [INFO] [stderr] --> src/mlp.rs:181:22 [INFO] [stderr] | [INFO] [stderr] 181 | for j in 0..x.shape().0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 181 | for in result.iter_mut().take(x.shape().0) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mlp.rs:196:56 [INFO] [stderr] | [INFO] [stderr] 196 | fn back_prop(&self, values: &NumMatrix, node_vals: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[NumMatrix]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: item `numrs::NumVector` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/numrs.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / impl NumVector { [INFO] [stderr] 22 | | // construct a new vector [INFO] [stderr] 23 | | pub fn new(array: Vec) -> NumVector { [INFO] [stderr] 24 | | // panic if input vector is empty [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/numrs.rs:152:18 [INFO] [stderr] | [INFO] [stderr] 152 | for i in 0..row { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 152 | for in array.iter().take(row) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `trans` [INFO] [stderr] --> src/numrs.rs:191:22 [INFO] [stderr] | [INFO] [stderr] 191 | for j in 0..self.column { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 191 | for (j, ) in trans.iter_mut().enumerate().take(self.column) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `rhs` [INFO] [stderr] --> src/numrs.rs:434:26 [INFO] [stderr] | [INFO] [stderr] 434 | for k in 0..self.shape().1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 434 | for (k, ) in rhs.iter().enumerate().take(self.shape().1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `matrix`. [INFO] [stderr] --> src/mlp.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | for j in 0..dims[i] { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 36 | for in matrix.iter_mut().take(dims[i]) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `result`. [INFO] [stderr] --> src/mlp.rs:181:22 [INFO] [stderr] | [INFO] [stderr] 181 | for j in 0..x.shape().0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 181 | for in result.iter_mut().take(x.shape().0) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mlp.rs:196:56 [INFO] [stderr] | [INFO] [stderr] 196 | fn back_prop(&self, values: &NumMatrix, node_vals: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[NumMatrix]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: item `numrs::NumVector` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/numrs.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / impl NumVector { [INFO] [stderr] 22 | | // construct a new vector [INFO] [stderr] 23 | | pub fn new(array: Vec) -> NumVector { [INFO] [stderr] 24 | | // panic if input vector is empty [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/numrs.rs:152:18 [INFO] [stderr] | [INFO] [stderr] 152 | for i in 0..row { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 152 | for in array.iter().take(row) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `trans` [INFO] [stderr] --> src/numrs.rs:191:22 [INFO] [stderr] | [INFO] [stderr] 191 | for j in 0..self.column { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 191 | for (j, ) in trans.iter_mut().enumerate().take(self.column) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `rhs` [INFO] [stderr] --> src/numrs.rs:434:26 [INFO] [stderr] | [INFO] [stderr] 434 | for k in 0..self.shape().1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 434 | for (k, ) in rhs.iter().enumerate().take(self.shape().1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | static REG_COEF: f64 = 0.0000000001; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:114:16 [INFO] [stderr] | [INFO] [stderr] 114 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 115 | | if negative_count <= (positive as f64 * SAMPLE_BIAS) as usize { [INFO] [stderr] 116 | | train_vectors.push(vectors[random_index[i]].clone()); [INFO] [stderr] 117 | | train_values.push(values[random_index[i]].clone()); [INFO] [stderr] 118 | | negative_count += 1; [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 114 | } else if negative_count <= (positive as f64 * SAMPLE_BIAS) as usize { [INFO] [stderr] 115 | train_vectors.push(vectors[random_index[i]].clone()); [INFO] [stderr] 116 | train_values.push(values[random_index[i]].clone()); [INFO] [stderr] 117 | negative_count += 1; [INFO] [stderr] 118 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | static REG_COEF: f64 = 0.0000000001; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:114:16 [INFO] [stderr] | [INFO] [stderr] 114 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 115 | | if negative_count <= (positive as f64 * SAMPLE_BIAS) as usize { [INFO] [stderr] 116 | | train_vectors.push(vectors[random_index[i]].clone()); [INFO] [stderr] 117 | | train_values.push(values[random_index[i]].clone()); [INFO] [stderr] 118 | | negative_count += 1; [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 114 | } else if negative_count <= (positive as f64 * SAMPLE_BIAS) as usize { [INFO] [stderr] 115 | train_vectors.push(vectors[random_index[i]].clone()); [INFO] [stderr] 116 | train_values.push(values[random_index[i]].clone()); [INFO] [stderr] 117 | negative_count += 1; [INFO] [stderr] 118 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | if values[random_index[i]][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(values[random_index[i]][0] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | if values[random_index[i]][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:111:12 [INFO] [stderr] | [INFO] [stderr] 111 | if values[random_index[i]][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(values[random_index[i]][0] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:111:12 [INFO] [stderr] | [INFO] [stderr] 111 | if values[random_index[i]][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `out_prob`. [INFO] [stderr] --> src/main.rs:152:14 [INFO] [stderr] | [INFO] [stderr] 152 | for i in 0..test_sample_size { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 152 | for in out_prob.iter().take(test_sample_size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `answer` [INFO] [stderr] --> src/main.rs:153:18 [INFO] [stderr] | [INFO] [stderr] 153 | for j in 0..PROB_NUM { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 153 | for (j, ) in answer.iter_mut().enumerate().take(PROB_NUM) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:172:12 [INFO] [stderr] | [INFO] [stderr] 172 | if test_values[i][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(test_values[i][0] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:172:12 [INFO] [stderr] | [INFO] [stderr] 172 | if test_values[i][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:180:16 [INFO] [stderr] | [INFO] [stderr] 180 | if answer[j][i] == test_values[i][0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(answer[j][i] - test_values[i][0]).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:180:16 [INFO] [stderr] | [INFO] [stderr] 180 | if answer[j][i] == test_values[i][0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:182:20 [INFO] [stderr] | [INFO] [stderr] 182 | if test_values[i][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(test_values[i][0] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:182:20 [INFO] [stderr] | [INFO] [stderr] 182 | if test_values[i][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:191:25 [INFO] [stderr] | [INFO] [stderr] 191 | positive_mean / positive as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(positive)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:192:25 [INFO] [stderr] | [INFO] [stderr] 192 | negative_mean / negative as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(negative)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | correct_answer[i] as f64 / test_sample_size as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(correct_answer[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | true_positive[i] as f64 / positive as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(true_positive[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:200:39 [INFO] [stderr] | [INFO] [stderr] 200 | true_positive[i] as f64 / positive as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(positive)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `diplearn`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | if values[random_index[i]][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(values[random_index[i]][0] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | if values[random_index[i]][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:111:12 [INFO] [stderr] | [INFO] [stderr] 111 | if values[random_index[i]][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(values[random_index[i]][0] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:111:12 [INFO] [stderr] | [INFO] [stderr] 111 | if values[random_index[i]][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `out_prob`. [INFO] [stderr] --> src/main.rs:152:14 [INFO] [stderr] | [INFO] [stderr] 152 | for i in 0..test_sample_size { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 152 | for in out_prob.iter().take(test_sample_size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `answer` [INFO] [stderr] --> src/main.rs:153:18 [INFO] [stderr] | [INFO] [stderr] 153 | for j in 0..PROB_NUM { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 153 | for (j, ) in answer.iter_mut().enumerate().take(PROB_NUM) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:172:12 [INFO] [stderr] | [INFO] [stderr] 172 | if test_values[i][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(test_values[i][0] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:172:12 [INFO] [stderr] | [INFO] [stderr] 172 | if test_values[i][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:180:16 [INFO] [stderr] | [INFO] [stderr] 180 | if answer[j][i] == test_values[i][0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(answer[j][i] - test_values[i][0]).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:180:16 [INFO] [stderr] | [INFO] [stderr] 180 | if answer[j][i] == test_values[i][0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:182:20 [INFO] [stderr] | [INFO] [stderr] 182 | if test_values[i][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(test_values[i][0] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:182:20 [INFO] [stderr] | [INFO] [stderr] 182 | if test_values[i][0] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:191:25 [INFO] [stderr] | [INFO] [stderr] 191 | positive_mean / positive as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(positive)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:192:25 [INFO] [stderr] | [INFO] [stderr] 192 | negative_mean / negative as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(negative)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | correct_answer[i] as f64 / test_sample_size as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(correct_answer[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | true_positive[i] as f64 / positive as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(true_positive[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:200:39 [INFO] [stderr] | [INFO] [stderr] 200 | true_positive[i] as f64 / positive as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(positive)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `diplearn`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f5e271b9499d4bed9885a62d2e4c62a61a54f198e884d24a629748b031712f7a"` [INFO] running `"docker" "rm" "-f" "f5e271b9499d4bed9885a62d2e4c62a61a54f198e884d24a629748b031712f7a"` [INFO] [stdout] f5e271b9499d4bed9885a62d2e4c62a61a54f198e884d24a629748b031712f7a