[INFO] updating cached repository mubiquity/Rust-Nature-of-Code [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mubiquity/Rust-Nature-of-Code [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mubiquity/Rust-Nature-of-Code" "work/ex/clippy-test-run/sources/stable/gh/mubiquity/Rust-Nature-of-Code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mubiquity/Rust-Nature-of-Code'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mubiquity/Rust-Nature-of-Code" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mubiquity/Rust-Nature-of-Code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mubiquity/Rust-Nature-of-Code'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0d8e8ca56c9914340affa09702295cd160d7d1f5 [INFO] sha for GitHub repo mubiquity/Rust-Nature-of-Code: 0d8e8ca56c9914340affa09702295cd160d7d1f5 [INFO] validating manifest of mubiquity/Rust-Nature-of-Code on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mubiquity/Rust-Nature-of-Code on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mubiquity/Rust-Nature-of-Code [INFO] finished frobbing mubiquity/Rust-Nature-of-Code [INFO] frobbed toml for mubiquity/Rust-Nature-of-Code written to work/ex/clippy-test-run/sources/stable/gh/mubiquity/Rust-Nature-of-Code/Cargo.toml [INFO] started frobbing mubiquity/Rust-Nature-of-Code [INFO] finished frobbing mubiquity/Rust-Nature-of-Code [INFO] frobbed toml for mubiquity/Rust-Nature-of-Code written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mubiquity/Rust-Nature-of-Code/Cargo.toml [INFO] crate mubiquity/Rust-Nature-of-Code has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mubiquity/Rust-Nature-of-Code against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mubiquity/Rust-Nature-of-Code:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 01d5c414c7e2c1b8b90ac14642c081c4a51cc1468c7a2154d116292b4195521c [INFO] running `"docker" "start" "-a" "01d5c414c7e2c1b8b90ac14642c081c4a51cc1468c7a2154d116292b4195521c"` [INFO] [stderr] Checking rand_core v0.1.0-pre.0 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling proc-macro2 v0.3.1 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Compiling x11-dl v2.17.5 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Checking tempfile v3.0.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Compiling gl_generator v0.8.0 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking rand v0.5.0-pre.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking rulinalg v0.4.2 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Compiling quote v0.5.1 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Compiling syn v0.13.1 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Compiling glutin v0.12.2 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Compiling serde_derive_internals v0.23.0 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Compiling serde_derive v1.0.37 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking noise v0.5.1 [INFO] [stderr] Checking piston2d-opengl_graphics v0.52.0 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.45.3 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking nature_of_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/random_walker.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | fn random(size: &window::Size) -> Walker { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `window::Size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/random_walker.rs:56:36 [INFO] [stderr] | [INFO] [stderr] 56 | let x = rng.gen_range(0.0, size.width as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/random_walker.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | let y = rng.gen_range(0.0, size.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/random_walker.rs:70:16 [INFO] [stderr] | [INFO] [stderr] 70 | if let Some(_) = e.update_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 71 | | match Direction::random() { [INFO] [stderr] 72 | | Direction::Left => self.x += -1.0, [INFO] [stderr] 73 | | Direction::Right => self.x += 1.0, [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________- help: try this: `if e.update_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/noise_walker.rs:72:37 [INFO] [stderr] | [INFO] [stderr] 72 | let mut x = perlin.get([xt, seed as f64]); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(seed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/noise_walker.rs:73:33 [INFO] [stderr] | [INFO] [stderr] 73 | let mut y = perlin.get([seed as f64, yt]); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(seed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/noise_walker.rs:75:52 [INFO] [stderr] | [INFO] [stderr] 75 | utils::map_to_range(&mut x, 0.0, 1.0, 0.0, size.width as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/noise_walker.rs:76:52 [INFO] [stderr] | [INFO] [stderr] 76 | utils::map_to_range(&mut y, 0.0, 1.0, 0.0, size.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/noise_walker.rs:96:43 [INFO] [stderr] | [INFO] [stderr] 96 | self.x = perlin.get([self.xt, self.seed as f64]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.seed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/noise_walker.rs:97:34 [INFO] [stderr] | [INFO] [stderr] 97 | self.y = perlin.get([self.seed as f64, self.yt]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.seed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/random_walker.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | fn random(size: &window::Size) -> Walker { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `window::Size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/random_walker.rs:56:36 [INFO] [stderr] | [INFO] [stderr] 56 | let x = rng.gen_range(0.0, size.width as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/random_walker.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | let y = rng.gen_range(0.0, size.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/random_walker.rs:70:16 [INFO] [stderr] | [INFO] [stderr] 70 | if let Some(_) = e.update_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 71 | | match Direction::random() { [INFO] [stderr] 72 | | Direction::Left => self.x += -1.0, [INFO] [stderr] 73 | | Direction::Right => self.x += 1.0, [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________- help: try this: `if e.update_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/noise_walker.rs:72:37 [INFO] [stderr] | [INFO] [stderr] 72 | let mut x = perlin.get([xt, seed as f64]); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(seed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/noise_walker.rs:73:33 [INFO] [stderr] | [INFO] [stderr] 73 | let mut y = perlin.get([seed as f64, yt]); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(seed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/noise_walker.rs:75:52 [INFO] [stderr] | [INFO] [stderr] 75 | utils::map_to_range(&mut x, 0.0, 1.0, 0.0, size.width as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/noise_walker.rs:76:52 [INFO] [stderr] | [INFO] [stderr] 76 | utils::map_to_range(&mut y, 0.0, 1.0, 0.0, size.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/noise_walker.rs:96:43 [INFO] [stderr] | [INFO] [stderr] 96 | self.x = perlin.get([self.xt, self.seed as f64]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.seed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/noise_walker.rs:97:34 [INFO] [stderr] | [INFO] [stderr] 97 | self.y = perlin.get([self.seed as f64, self.yt]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.seed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 16s [INFO] running `"docker" "inspect" "01d5c414c7e2c1b8b90ac14642c081c4a51cc1468c7a2154d116292b4195521c"` [INFO] running `"docker" "rm" "-f" "01d5c414c7e2c1b8b90ac14642c081c4a51cc1468c7a2154d116292b4195521c"` [INFO] [stdout] 01d5c414c7e2c1b8b90ac14642c081c4a51cc1468c7a2154d116292b4195521c