[INFO] updating cached repository mtwtkman/solami [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mtwtkman/solami [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mtwtkman/solami" "work/ex/clippy-test-run/sources/stable/gh/mtwtkman/solami"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mtwtkman/solami'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mtwtkman/solami" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtwtkman/solami"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtwtkman/solami'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8e34da8317c928ab6a066225cbf16bbf7ef79d00 [INFO] sha for GitHub repo mtwtkman/solami: 8e34da8317c928ab6a066225cbf16bbf7ef79d00 [INFO] validating manifest of mtwtkman/solami on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mtwtkman/solami on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mtwtkman/solami [INFO] finished frobbing mtwtkman/solami [INFO] frobbed toml for mtwtkman/solami written to work/ex/clippy-test-run/sources/stable/gh/mtwtkman/solami/Cargo.toml [INFO] started frobbing mtwtkman/solami [INFO] finished frobbing mtwtkman/solami [INFO] frobbed toml for mtwtkman/solami written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtwtkman/solami/Cargo.toml [INFO] crate mtwtkman/solami has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mtwtkman/solami against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mtwtkman/solami:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b85b4ed0cbd5b2ebbba739908596df09d2014516c850b18548cd7097165a52fe [INFO] running `"docker" "start" "-a" "b85b4ed0cbd5b2ebbba739908596df09d2014516c850b18548cd7097165a52fe"` [INFO] [stderr] Compiling typenum v1.5.2 [INFO] [stderr] Compiling openssl v0.9.14 [INFO] [stderr] Checking constant_time_eq v0.1.2 [INFO] [stderr] Compiling derive_builder v0.5.0 [INFO] [stderr] Compiling openssl-sys v0.9.14 [INFO] [stderr] Checking unicode-bidi v0.2.6 [INFO] [stderr] Checking utf-8 v0.7.1 [INFO] [stderr] Checking num_cpus v1.5.1 [INFO] [stderr] Checking nodrop v0.1.9 [INFO] [stderr] Checking encoding_rs v0.6.11 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking idna v0.1.2 [INFO] [stderr] Checking backtrace-sys v0.1.12 [INFO] [stderr] Compiling derive_builder_core v0.1.7 [INFO] [stderr] Checking stringprep v0.1.0 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking url v1.4.1 [INFO] [stderr] Checking generic-array v0.7.2 [INFO] [stderr] Checking digest-buffer v0.3.1 [INFO] [stderr] Checking digest v0.5.2 [INFO] [stderr] Checking crypto-mac v0.3.0 [INFO] [stderr] Checking sha2 v0.5.3 [INFO] [stderr] Checking hmac v0.1.1 [INFO] [stderr] Checking hyper v0.10.12 [INFO] [stderr] Checking serde_urlencoded v0.4.3 [INFO] [stderr] Checking quick-xml v0.7.3 [INFO] [stderr] Checking postgres-protocol v0.3.0 [INFO] [stderr] Checking postgres-shared v0.3.0 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking rss v0.7.0 [INFO] [stderr] Checking tungstenite v0.2.4 [INFO] [stderr] Checking postgres v0.14.2 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking reqwest v0.4.0 [INFO] [stderr] Checking slack_api v0.17.0 [INFO] [stderr] Checking slack v0.18.0 [INFO] [stderr] Checking solami v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | users: users, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `users` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | users: users, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `users` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `Sender` [INFO] [stderr] --> src/main.rs:8:46 [INFO] [stderr] | [INFO] [stderr] 8 | use slack::{Event, RtmClient, Message, User, Sender}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::rust_rss::Channel` [INFO] [stderr] --> src/handlers/rss.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use self::rust_rss::Channel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Sender` [INFO] [stderr] --> src/main.rs:8:46 [INFO] [stderr] | [INFO] [stderr] 8 | use slack::{Event, RtmClient, Message, User, Sender}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::rust_rss::Channel` [INFO] [stderr] --> src/handlers/rss.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use self::rust_rss::Channel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pg` [INFO] [stderr] --> src/handlers/rss.rs:8:67 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn handle<'a>(p: &SolamiHandler, cmd: &'a str, rest: &'a str, pg: &Connection) { [INFO] [stderr] | ^^ help: consider using `_pg` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cli` [INFO] [stderr] --> src/main.rs:93:28 [INFO] [stderr] | [INFO] [stderr] 93 | fn on_close(&mut self, cli: &RtmClient) { [INFO] [stderr] | ^^^ help: consider using `_cli` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cli` [INFO] [stderr] --> src/main.rs:97:30 [INFO] [stderr] | [INFO] [stderr] 97 | fn on_connect(&mut self, cli: &RtmClient) { [INFO] [stderr] | ^^^ help: consider using `_cli` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pg` [INFO] [stderr] --> src/handlers/rss.rs:8:67 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn handle<'a>(p: &SolamiHandler, cmd: &'a str, rest: &'a str, pg: &Connection) { [INFO] [stderr] | ^^ help: consider using `_pg` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cli` [INFO] [stderr] --> src/main.rs:93:28 [INFO] [stderr] | [INFO] [stderr] 93 | fn on_close(&mut self, cli: &RtmClient) { [INFO] [stderr] | ^^^ help: consider using `_cli` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cli` [INFO] [stderr] --> src/main.rs:97:30 [INFO] [stderr] | [INFO] [stderr] 97 | fn on_connect(&mut self, cli: &RtmClient) { [INFO] [stderr] | ^^^ help: consider using `_cli` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `users` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | users: Users, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/handlers/inc.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | / p.send( [INFO] [stderr] 25 | | format!("{}さんの徳は現在{}です。", target, obj.count).as_str() [INFO] [stderr] 26 | | ).map_err(|e| { [INFO] [stderr] 27 | | println!("[inc] error occurred with `send_with_body`! ERROR: {}", e); [INFO] [stderr] 28 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/handlers/echo.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | p.send(b.as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/handlers/echo.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / fn formatter<'a>(text: &'a str) -> String { [INFO] [stderr] 100 | | let re = regex::Regex::new(r"<(https?://[^>]+?)>").unwrap(); [INFO] [stderr] 101 | | match re.captures(text) { [INFO] [stderr] 102 | | Some(caps) => String::from(&caps[1]), [INFO] [stderr] 103 | | None => String::from(text), [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_^ [INFO] [stderr] warning: field is never used: `users` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | users: Users, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/handlers/rss.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | p.send(b.as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/handlers/inc.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | / p.send( [INFO] [stderr] 25 | | format!("{}さんの徳は現在{}です。", target, obj.count).as_str() [INFO] [stderr] 26 | | ).map_err(|e| { [INFO] [stderr] 27 | | println!("[inc] error occurred with `send_with_body`! ERROR: {}", e); [INFO] [stderr] 28 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/handlers/echo.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | p.send(b.as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/handlers/echo.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / fn formatter<'a>(text: &'a str) -> String { [INFO] [stderr] 100 | | let re = regex::Regex::new(r"<(https?://[^>]+?)>").unwrap(); [INFO] [stderr] 101 | | match re.captures(text) { [INFO] [stderr] 102 | | Some(caps) => String::from(&caps[1]), [INFO] [stderr] 103 | | None => String::from(text), [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:24:44 [INFO] [stderr] | [INFO] [stderr] 24 | fn message_filter(p: &SolamiHandler, text: &String, pg: &Connection) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | p.send(response.as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/handlers/rss.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | p.send(b.as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:24:44 [INFO] [stderr] | [INFO] [stderr] 24 | fn message_filter(p: &SolamiHandler, text: &String, pg: &Connection) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | p.send(response.as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:123:64 [INFO] [stderr] | [INFO] [stderr] 123 | for user in start_response.users.as_ref().unwrap().into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | client.run(&mut handler); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:123:64 [INFO] [stderr] | [INFO] [stderr] 123 | for user in start_response.users.as_ref().unwrap().into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | client.run(&mut handler); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `"docker" "inspect" "b85b4ed0cbd5b2ebbba739908596df09d2014516c850b18548cd7097165a52fe"` [INFO] running `"docker" "rm" "-f" "b85b4ed0cbd5b2ebbba739908596df09d2014516c850b18548cd7097165a52fe"` [INFO] [stdout] b85b4ed0cbd5b2ebbba739908596df09d2014516c850b18548cd7097165a52fe