[INFO] updating cached repository mtn/tangerine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mtn/tangerine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mtn/tangerine" "work/ex/clippy-test-run/sources/stable/gh/mtn/tangerine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mtn/tangerine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mtn/tangerine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtn/tangerine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtn/tangerine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8fc821e08ee17f0710c27eede390d6891ba4f5c7 [INFO] sha for GitHub repo mtn/tangerine: 8fc821e08ee17f0710c27eede390d6891ba4f5c7 [INFO] validating manifest of mtn/tangerine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mtn/tangerine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mtn/tangerine [INFO] finished frobbing mtn/tangerine [INFO] frobbed toml for mtn/tangerine written to work/ex/clippy-test-run/sources/stable/gh/mtn/tangerine/Cargo.toml [INFO] started frobbing mtn/tangerine [INFO] finished frobbing mtn/tangerine [INFO] frobbed toml for mtn/tangerine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtn/tangerine/Cargo.toml [INFO] crate mtn/tangerine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mtn/tangerine against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mtn/tangerine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2856d573627d3d65b0029153f79f95ae1fdba29ec3594d78b860594b147173ed [INFO] running `"docker" "start" "-a" "2856d573627d3d65b0029153f79f95ae1fdba29ec3594d78b860594b147173ed"` [INFO] [stderr] Checking tangerine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/parser.rs:194:41 [INFO] [stderr] | [INFO] [stderr] 194 | ast = if let ASTNode::Application { lhs: _, rhs: ref r } = ast { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Application { rhs: ref r, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/parser.rs:194:41 [INFO] [stderr] | [INFO] [stderr] 194 | ast = if let ASTNode::Application { lhs: _, rhs: ref r } = ast { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Application { rhs: ref r, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match self { [INFO] [stderr] 23 | | &ASTNode::Abstraction { [INFO] [stderr] 24 | | ref param, [INFO] [stderr] 25 | | ref body, [INFO] [stderr] ... | [INFO] [stderr] 29 | | &ASTNode::Epsilon => write!(f, "ε"), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *self { [INFO] [stderr] 23 | ASTNode::Abstraction { [INFO] [stderr] 24 | ref param, [INFO] [stderr] 25 | ref body, [INFO] [stderr] 26 | } => write!(f, "λ{}.{}", param, body), [INFO] [stderr] 27 | ASTNode::Application { ref lhs, ref rhs } => write!(f, "({} {})", lhs, rhs), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / match self { [INFO] [stderr] 37 | | &ASTNode::Abstraction { [INFO] [stderr] 38 | | ref param, [INFO] [stderr] 39 | | ref body, [INFO] [stderr] ... | [INFO] [stderr] 84 | | &ASTNode::Epsilon => (*self).clone(), [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | match *self { [INFO] [stderr] 37 | ASTNode::Abstraction { [INFO] [stderr] 38 | ref param, [INFO] [stderr] 39 | ref body, [INFO] [stderr] 40 | } => { [INFO] [stderr] 41 | let mut new = env.clone(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match self { [INFO] [stderr] 90 | | &ASTNode::Abstraction { [INFO] [stderr] 91 | | ref param, [INFO] [stderr] 92 | | ref body, [INFO] [stderr] ... | [INFO] [stderr] 96 | | _ => false, [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | match *self { [INFO] [stderr] 90 | ASTNode::Abstraction { [INFO] [stderr] 91 | ref param, [INFO] [stderr] 92 | ref body, [INFO] [stderr] 93 | } => *atom != **param && body.free_in(atom), [INFO] [stderr] 94 | ASTNode::Application { ref lhs, ref rhs } => lhs.free_in(atom) || rhs.free_in(atom), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match self { [INFO] [stderr] 23 | | &ASTNode::Abstraction { [INFO] [stderr] 24 | | ref param, [INFO] [stderr] 25 | | ref body, [INFO] [stderr] ... | [INFO] [stderr] 29 | | &ASTNode::Epsilon => write!(f, "ε"), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *self { [INFO] [stderr] 23 | ASTNode::Abstraction { [INFO] [stderr] 24 | ref param, [INFO] [stderr] 25 | ref body, [INFO] [stderr] 26 | } => write!(f, "λ{}.{}", param, body), [INFO] [stderr] 27 | ASTNode::Application { ref lhs, ref rhs } => write!(f, "({} {})", lhs, rhs), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / match self { [INFO] [stderr] 37 | | &ASTNode::Abstraction { [INFO] [stderr] 38 | | ref param, [INFO] [stderr] 39 | | ref body, [INFO] [stderr] ... | [INFO] [stderr] 84 | | &ASTNode::Epsilon => (*self).clone(), [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | match *self { [INFO] [stderr] 37 | ASTNode::Abstraction { [INFO] [stderr] 38 | ref param, [INFO] [stderr] 39 | ref body, [INFO] [stderr] 40 | } => { [INFO] [stderr] 41 | let mut new = env.clone(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match self { [INFO] [stderr] 90 | | &ASTNode::Abstraction { [INFO] [stderr] 91 | | ref param, [INFO] [stderr] 92 | | ref body, [INFO] [stderr] ... | [INFO] [stderr] 96 | | _ => false, [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | match *self { [INFO] [stderr] 90 | ASTNode::Abstraction { [INFO] [stderr] 91 | ref param, [INFO] [stderr] 92 | ref body, [INFO] [stderr] 93 | } => *atom != **param && body.free_in(atom), [INFO] [stderr] 94 | ASTNode::Application { ref lhs, ref rhs } => lhs.free_in(atom) || rhs.free_in(atom), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.59s [INFO] running `"docker" "inspect" "2856d573627d3d65b0029153f79f95ae1fdba29ec3594d78b860594b147173ed"` [INFO] running `"docker" "rm" "-f" "2856d573627d3d65b0029153f79f95ae1fdba29ec3594d78b860594b147173ed"` [INFO] [stdout] 2856d573627d3d65b0029153f79f95ae1fdba29ec3594d78b860594b147173ed