[INFO] updating cached repository mtn/silver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mtn/silver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mtn/silver" "work/ex/clippy-test-run/sources/stable/gh/mtn/silver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mtn/silver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mtn/silver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtn/silver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtn/silver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 895c666723d96cf42655ef713ff9893b25f10b3c [INFO] sha for GitHub repo mtn/silver: 895c666723d96cf42655ef713ff9893b25f10b3c [INFO] validating manifest of mtn/silver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mtn/silver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mtn/silver [INFO] finished frobbing mtn/silver [INFO] frobbed toml for mtn/silver written to work/ex/clippy-test-run/sources/stable/gh/mtn/silver/Cargo.toml [INFO] started frobbing mtn/silver [INFO] finished frobbing mtn/silver [INFO] frobbed toml for mtn/silver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtn/silver/Cargo.toml [INFO] crate mtn/silver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mtn/silver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mtn/silver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 16a8a15ffca5667d3580d9bdfadc869a6f3eb784915846ef22e9a8a4f1d18546 [INFO] running `"docker" "start" "-a" "16a8a15ffca5667d3580d9bdfadc869a6f3eb784915846ef22e9a8a4f1d18546"` [INFO] [stderr] Checking silver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | let mut lexer = lexer::Lexer::new(inp); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:344:13 [INFO] [stderr] | [INFO] [stderr] 344 | let mut lexer = lexer::Lexer::new(inp); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:366:13 [INFO] [stderr] | [INFO] [stderr] 366 | let mut lexer = lexer::Lexer::new(inp); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | let mut lexer = lexer::Lexer::new(inp); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | let mut lexer = lexer::Lexer::new(inp); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:430:13 [INFO] [stderr] | [INFO] [stderr] 430 | let mut lexer = lexer::Lexer::new(inp); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:451:13 [INFO] [stderr] | [INFO] [stderr] 451 | let mut lexer = lexer::Lexer::new(inp); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:487:13 [INFO] [stderr] | [INFO] [stderr] 487 | let mut lexer = lexer::Lexer::new(inp); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lexer.rs:55:16 [INFO] [stderr] | [INFO] [stderr] 55 | if let Some(_) = self.peeked { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 56 | | ret = Ok(self.peeked.clone().unwrap()); [INFO] [stderr] 57 | | self.peeked = None; [INFO] [stderr] 58 | | return ret; [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________- help: try this: `if self.peeked.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lexer.rs:81:16 [INFO] [stderr] | [INFO] [stderr] 81 | if let None = self.peeked { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 82 | | self.peeked = Some(self.get_token()?); [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________- help: try this: `if self.peeked.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lexer.rs:55:16 [INFO] [stderr] | [INFO] [stderr] 55 | if let Some(_) = self.peeked { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 56 | | ret = Ok(self.peeked.clone().unwrap()); [INFO] [stderr] 57 | | self.peeked = None; [INFO] [stderr] 58 | | return ret; [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________- help: try this: `if self.peeked.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lexer.rs:81:16 [INFO] [stderr] | [INFO] [stderr] 81 | if let None = self.peeked { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 82 | | self.peeked = Some(self.get_token()?); [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________- help: try this: `if self.peeked.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | name: Box>, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | body: Box, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | fn emit_invocation(func: Box, args: Vec) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | else_body: Box>, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | if_body: Box, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | cond: Box, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:117:46 [INFO] [stderr] | [INFO] [stderr] 117 | fn emit_binary(op: Token, lhs: Box, rhs: Box) -> Result { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:117:27 [INFO] [stderr] | [INFO] [stderr] 117 | fn emit_binary(op: Token, lhs: Box, rhs: Box) -> Result { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:12:33 [INFO] [stderr] | [INFO] [stderr] 12 | fn process_input_file(filename: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser.rs:444:20 [INFO] [stderr] | [INFO] [stderr] 444 | panic!(format!("Simple binary failed to parse")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Simple binary failed to parse".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser.rs:473:20 [INFO] [stderr] | [INFO] [stderr] 473 | panic!(format!("Simple binary failed to parse")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Simple binary failed to parse".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | name: Box>, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | body: Box, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | fn emit_invocation(func: Box, args: Vec) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | else_body: Box>, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | if_body: Box, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | cond: Box, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:117:46 [INFO] [stderr] | [INFO] [stderr] 117 | fn emit_binary(op: Token, lhs: Box, rhs: Box) -> Result { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/emitter.rs:117:27 [INFO] [stderr] | [INFO] [stderr] 117 | fn emit_binary(op: Token, lhs: Box, rhs: Box) -> Result { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:12:33 [INFO] [stderr] | [INFO] [stderr] 12 | fn process_input_file(filename: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.58s [INFO] running `"docker" "inspect" "16a8a15ffca5667d3580d9bdfadc869a6f3eb784915846ef22e9a8a4f1d18546"` [INFO] running `"docker" "rm" "-f" "16a8a15ffca5667d3580d9bdfadc869a6f3eb784915846ef22e9a8a4f1d18546"` [INFO] [stdout] 16a8a15ffca5667d3580d9bdfadc869a6f3eb784915846ef22e9a8a4f1d18546