[INFO] updating cached repository mtharrison/wasmparse [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mtharrison/wasmparse [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mtharrison/wasmparse" "work/ex/clippy-test-run/sources/stable/gh/mtharrison/wasmparse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mtharrison/wasmparse'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mtharrison/wasmparse" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtharrison/wasmparse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtharrison/wasmparse'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8d16e8222a415ec215abeb33b04c5a05180cb027 [INFO] sha for GitHub repo mtharrison/wasmparse: 8d16e8222a415ec215abeb33b04c5a05180cb027 [INFO] validating manifest of mtharrison/wasmparse on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mtharrison/wasmparse on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mtharrison/wasmparse [INFO] finished frobbing mtharrison/wasmparse [INFO] frobbed toml for mtharrison/wasmparse written to work/ex/clippy-test-run/sources/stable/gh/mtharrison/wasmparse/Cargo.toml [INFO] started frobbing mtharrison/wasmparse [INFO] finished frobbing mtharrison/wasmparse [INFO] frobbed toml for mtharrison/wasmparse written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtharrison/wasmparse/Cargo.toml [INFO] crate mtharrison/wasmparse has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mtharrison/wasmparse against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mtharrison/wasmparse:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 79090812939f262715849736ad3e811ce53bfcfbfa8c8e864c3d519a1bddc7a1 [INFO] running `"docker" "start" "-a" "79090812939f262715849736ad3e811ce53bfcfbfa8c8e864c3d519a1bddc7a1"` [INFO] [stderr] Compiling serde_derive v1.0.45 [INFO] [stderr] Checking wasmparse v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:13:33 [INFO] [stderr] | [INFO] [stderr] 13 | static WASM_MAGIC_NUMBER: u32 = 0x6d736100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6d73_6100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | return Ok(module); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(module)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/leb128.rs:74:28 [INFO] [stderr] | [INFO] [stderr] 74 | assert_eq!(number, 624485); [INFO] [stderr] | ^^^^^^ help: consider: `624_485` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/leb128.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | assert_eq!(number, -624485); [INFO] [stderr] | ^^^^^^ help: consider: `624_485` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:13:33 [INFO] [stderr] | [INFO] [stderr] 13 | static WASM_MAGIC_NUMBER: u32 = 0x6d736100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6d73_6100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | return Ok(module); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(module)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/leb128.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | let ceil_bytes = (n as f64 / 7.0).ceil() as usize; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/leb128.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | reader.read(&mut buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/leb128.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | let low_order_7 = (0b0111_1111 & byte) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(0b0111_1111 & byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/leb128.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | let ceil_bytes = (n as f64 / 7.0).ceil() as usize; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/leb128.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | reader.read(&mut buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/leb128.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | let low_order_7 = (0b0111_1111 & byte) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(0b0111_1111 & byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | reader.read(&mut n).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: the `t @ _` pattern can be written as just `t` [INFO] [stderr] --> src/lib.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | t @ _ => panic!("Uknown value type {}", t), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | reader.read(&mut n).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: the `t @ _` pattern can be written as just `t` [INFO] [stderr] --> src/lib.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | t @ _ => panic!("Uknown value type {}", t), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasmparse`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasmparse`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "79090812939f262715849736ad3e811ce53bfcfbfa8c8e864c3d519a1bddc7a1"` [INFO] running `"docker" "rm" "-f" "79090812939f262715849736ad3e811ce53bfcfbfa8c8e864c3d519a1bddc7a1"` [INFO] [stdout] 79090812939f262715849736ad3e811ce53bfcfbfa8c8e864c3d519a1bddc7a1