[INFO] updating cached repository mskwarek/rustchain
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mskwarek/rustchain
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mskwarek/rustchain" "work/ex/clippy-test-run/sources/stable/gh/mskwarek/rustchain"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mskwarek/rustchain'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mskwarek/rustchain" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mskwarek/rustchain"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mskwarek/rustchain'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1e61d8cf5eee396f10c47870bbf1ef733740ca69
[INFO] sha for GitHub repo mskwarek/rustchain: 1e61d8cf5eee396f10c47870bbf1ef733740ca69
[INFO] validating manifest of mskwarek/rustchain on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mskwarek/rustchain on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mskwarek/rustchain
[INFO] finished frobbing mskwarek/rustchain
[INFO] frobbed toml for mskwarek/rustchain written to work/ex/clippy-test-run/sources/stable/gh/mskwarek/rustchain/Cargo.toml
[INFO] started frobbing mskwarek/rustchain
[INFO] finished frobbing mskwarek/rustchain
[INFO] frobbed toml for mskwarek/rustchain written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mskwarek/rustchain/Cargo.toml
[INFO] crate mskwarek/rustchain has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mskwarek/rustchain against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mskwarek/rustchain:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 503a7f47689dee402cc883288d41a66c1a2a7bc1f24055bf9a7049b9e372ea68
[INFO] running `"docker" "start" "-a" "503a7f47689dee402cc883288d41a66c1a2a7bc1f24055bf9a7049b9e372ea68"`
[INFO] [stderr]     Checking atty v0.2.10
[INFO] [stderr]     Checking net2 v0.2.32
[INFO] [stderr]     Checking log v0.4.5
[INFO] [stderr]     Checking crossbeam-epoch v0.5.2
[INFO] [stderr]     Checking bytes v0.4.10
[INFO] [stderr]     Checking futures-cpupool v0.1.8
[INFO] [stderr]     Checking aho-corasick v0.6.4
[INFO] [stderr]     Checking rand v0.3.22
[INFO] [stderr]     Checking uuid v0.6.3
[INFO] [stderr]     Checking tokio-current-thread v0.1.1
[INFO] [stderr]     Checking tokio-timer v0.2.6
[INFO] [stderr]     Checking want v0.0.6
[INFO] [stderr]     Checking crossbeam-deque v0.6.1
[INFO] [stderr]     Checking rust-crypto v0.2.36
[INFO] [stderr]     Checking mio v0.6.14
[INFO] [stderr]     Checking regex v1.0.0
[INFO] [stderr]     Checking tokio-io v0.1.8
[INFO] [stderr]     Checking http v0.1.13
[INFO] [stderr]     Checking tokio-threadpool v0.1.6
[INFO] [stderr]     Checking tokio-codec v0.1.0
[INFO] [stderr]     Checking tokio-reactor v0.1.1
[INFO] [stderr]     Checking mio-uds v0.6.7
[INFO] [stderr]     Checking tokio-fs v0.1.3
[INFO] [stderr]     Checking tokio-tcp v0.1.0
[INFO] [stderr]     Checking tokio-udp v0.1.0
[INFO] [stderr]     Checking tokio-uds v0.2.1
[INFO] [stderr]     Checking env_logger v0.5.10
[INFO] [stderr]     Checking tokio v0.1.8
[INFO] [stderr]     Checking pretty_env_logger v0.2.4
[INFO] [stderr]     Checking h2 v0.1.12
[INFO] [stderr]     Checking hyper v0.12.10
[INFO] [stderr]     Checking rustchain v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:99:13
[INFO] [stderr]    |
[INFO] [stderr] 99 |             previous_hash: previous_hash,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_hash`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             proof: proof,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `proof`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:99:13
[INFO] [stderr]    |
[INFO] [stderr] 99 |             previous_hash: previous_hash,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_hash`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             proof: proof,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `proof`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:78:24
[INFO] [stderr]    |
[INFO] [stderr] 78 |             timestamp: 333037375,
[INFO] [stderr]    |                        ^^^^^^^^^ help: consider: `333_037_375`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:78:24
[INFO] [stderr]    |
[INFO] [stderr] 78 |             timestamp: 333037375,
[INFO] [stderr]    |                        ^^^^^^^^^ help: consider: `333_037_375`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:477:24
[INFO] [stderr]     |
[INFO] [stderr] 477 |             timestamp: 333037375,
[INFO] [stderr]     |                        ^^^^^^^^^ help: consider: `333_037_375`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `error`
[INFO] [stderr]    --> src/main.rs:190:13
[INFO] [stderr]     |
[INFO] [stderr] 190 |         Err(error) => {
[INFO] [stderr]     |             ^^^^^ help: consider using `_error` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `error`
[INFO] [stderr]    --> src/main.rs:190:13
[INFO] [stderr]     |
[INFO] [stderr] 190 |         Err(error) => {
[INFO] [stderr]     |             ^^^^^ help: consider using `_error` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:109:34
[INFO] [stderr]     |
[INFO] [stderr] 109 |     pub fn calculate_hash(input: &String) -> String {
[INFO] [stderr]     |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:130:15
[INFO] [stderr]     |
[INFO] [stderr] 130 |         while Blockchain::valid_proof(proof, last_proof) == false {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!Blockchain::valid_proof(proof, last_proof)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:256:41
[INFO] [stderr]     |
[INFO] [stderr] 256 |                             "message" : format!("Nodes will be registered"), 
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Nodes will be registered".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:109:34
[INFO] [stderr]     |
[INFO] [stderr] 109 |     pub fn calculate_hash(input: &String) -> String {
[INFO] [stderr]     |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:285:71
[INFO] [stderr]     |
[INFO] [stderr] 285 |     let result = GLOBAL_NODES_SET.lock().unwrap().iter().position(|r| r.to_string() == address);
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^ help: try: `r`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:130:15
[INFO] [stderr]     |
[INFO] [stderr] 130 |         while Blockchain::valid_proof(proof, last_proof) == false {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!Blockchain::valid_proof(proof, last_proof)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:256:41
[INFO] [stderr]     |
[INFO] [stderr] 256 |                             "message" : format!("Nodes will be registered"), 
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Nodes will be registered".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:285:71
[INFO] [stderr]     |
[INFO] [stderr] 285 |     let result = GLOBAL_NODES_SET.lock().unwrap().iter().position(|r| r.to_string() == address);
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^ help: try: `r`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/main.rs:467:20
[INFO] [stderr]     |
[INFO] [stderr] 467 |         assert_eq!("foobar".as_bytes().to_hex(), "666f6f626172");
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foobar"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 25.45s
[INFO] running `"docker" "inspect" "503a7f47689dee402cc883288d41a66c1a2a7bc1f24055bf9a7049b9e372ea68"`
[INFO] running `"docker" "rm" "-f" "503a7f47689dee402cc883288d41a66c1a2a7bc1f24055bf9a7049b9e372ea68"`
[INFO] [stdout] 503a7f47689dee402cc883288d41a66c1a2a7bc1f24055bf9a7049b9e372ea68