[INFO] updating cached repository msifd/cronis-csf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/msifd/cronis-csf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/msifd/cronis-csf" "work/ex/clippy-test-run/sources/stable/gh/msifd/cronis-csf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/msifd/cronis-csf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/msifd/cronis-csf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msifd/cronis-csf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msifd/cronis-csf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 40e24cc3a2fe25b4f4b956c70531a7a0ec57c2b9 [INFO] sha for GitHub repo msifd/cronis-csf: 40e24cc3a2fe25b4f4b956c70531a7a0ec57c2b9 [INFO] validating manifest of msifd/cronis-csf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of msifd/cronis-csf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing msifd/cronis-csf [INFO] finished frobbing msifd/cronis-csf [INFO] frobbed toml for msifd/cronis-csf written to work/ex/clippy-test-run/sources/stable/gh/msifd/cronis-csf/Cargo.toml [INFO] started frobbing msifd/cronis-csf [INFO] finished frobbing msifd/cronis-csf [INFO] frobbed toml for msifd/cronis-csf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msifd/cronis-csf/Cargo.toml [INFO] crate msifd/cronis-csf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting msifd/cronis-csf against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/msifd/cronis-csf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5a86e55af81eea55dd9953910637dd36902b308b3d89356f2f8d554497d4e117 [INFO] running `"docker" "start" "-a" "5a86e55af81eea55dd9953910637dd36902b308b3d89356f2f8d554497d4e117"` [INFO] [stderr] Checking cronis-csf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lecture2/braking_stack.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | max_stack_size: max_stack_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_stack_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lecture2/multi_stack.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | MultiStack { vec: vec } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lecture3/closest.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lecture3/closest.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lecture2/braking_stack.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | max_stack_size: max_stack_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_stack_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lecture2/multi_stack.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | MultiStack { vec: vec } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lecture3/closest.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lecture3/closest.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lecture3/closest.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | if (n >> i) % 2 == 1 && (n >> i - 1) % 2 == 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider parenthesizing your expression: `n >> (i - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lecture3/closest.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | print!("{}", (prev >> 31 - i) % 2); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `prev >> (31 - i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lecture3/bit_diff.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | diff_n [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lecture3/bit_diff.rs:3:18 [INFO] [stderr] | [INFO] [stderr] 3 | let diff_n = (0..32) [INFO] [stderr] | __________________^ [INFO] [stderr] 4 | | .map(|i| (diff >> i) % 2) [INFO] [stderr] 5 | | .fold(0, |acc, i| acc + i); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lecture3/swap.rs:2:21 [INFO] [stderr] | [INFO] [stderr] 2 | let even_mask = 0b01010101010101010101010101010101; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0101_0101_0101_0101_0101_0101_0101_0101` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lecture3/longest_group.rs:29:33 [INFO] [stderr] | [INFO] [stderr] 29 | assert_eq!(6, longest_group(0b11010010111011)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b11_0100_1011_1011` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lecture3/longest_group.rs:30:34 [INFO] [stderr] | [INFO] [stderr] 30 | assert_eq!(31, longest_group(0xfffffffc)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lecture3/longest_group.rs:31:34 [INFO] [stderr] | [INFO] [stderr] 31 | assert_eq!(32, longest_group(0xfffffffe)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lecture3/longest_group.rs:32:34 [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!(32, longest_group(0xffffffff)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lecture3/closest.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | if (n >> i) % 2 == 1 && (n >> i - 1) % 2 == 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider parenthesizing your expression: `n >> (i - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lecture3/closest.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | print!("{}", (prev >> 31 - i) % 2); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `prev >> (31 - i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lecture3/bit_diff.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | diff_n [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lecture3/bit_diff.rs:3:18 [INFO] [stderr] | [INFO] [stderr] 3 | let diff_n = (0..32) [INFO] [stderr] | __________________^ [INFO] [stderr] 4 | | .map(|i| (diff >> i) % 2) [INFO] [stderr] 5 | | .fold(0, |acc, i| acc + i); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lecture3/swap.rs:2:21 [INFO] [stderr] | [INFO] [stderr] 2 | let even_mask = 0b01010101010101010101010101010101; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0101_0101_0101_0101_0101_0101_0101_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lecture2/braking_stack.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | if self.top_stack().len() == 0 && self.stacks.len() > 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.top_stack().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lecture2/multi_stack.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn is_empty(&mut self, stack_index: usize) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lecture2/multi_stack.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match self.get_stack_top_pos(stack_index) { [INFO] [stderr] 64 | | None => true, [INFO] [stderr] 65 | | Some(_) => false, [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ help: try this: `self.get_stack_top_pos(stack_index).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lecture3/bit_diff.rs:4:34 [INFO] [stderr] | [INFO] [stderr] 4 | .map(|i| (diff >> i) % 2) [INFO] [stderr] | __________________________________^ [INFO] [stderr] 5 | | .fold(0, |acc, i| acc + i); [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lecture7/backpack.rs:7:40 [INFO] [stderr] | [INFO] [stderr] 7 | fn find_best(capacity: u32, items: &Vec, selected: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lecture7/backpack.rs:7:62 [INFO] [stderr] | [INFO] [stderr] 7 | fn find_best(capacity: u32, items: &Vec, selected: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lecture7/backpack.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | items: &Vec, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lecture7/backpack.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / let item_weight; [INFO] [stderr] 36 | | if cached_item != 0 { [INFO] [stderr] 37 | | selected.push(cached_item); [INFO] [stderr] 38 | | item_weight = items[cached_item - 1].1; [INFO] [stderr] 39 | | } else { [INFO] [stderr] 40 | | item_weight = 1; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let item_weight = if cached_item != 0 { ..; items[cached_item - 1].1 } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lecture2/braking_stack.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | if self.top_stack().len() == 0 && self.stacks.len() > 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.top_stack().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lecture2/multi_stack.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn is_empty(&mut self, stack_index: usize) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lecture2/multi_stack.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match self.get_stack_top_pos(stack_index) { [INFO] [stderr] 64 | | None => true, [INFO] [stderr] 65 | | Some(_) => false, [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ help: try this: `self.get_stack_top_pos(stack_index).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lecture3/bit_diff.rs:4:34 [INFO] [stderr] | [INFO] [stderr] 4 | .map(|i| (diff >> i) % 2) [INFO] [stderr] | __________________________________^ [INFO] [stderr] 5 | | .fold(0, |acc, i| acc + i); [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lecture7/backpack.rs:7:40 [INFO] [stderr] | [INFO] [stderr] 7 | fn find_best(capacity: u32, items: &Vec, selected: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lecture7/backpack.rs:7:62 [INFO] [stderr] | [INFO] [stderr] 7 | fn find_best(capacity: u32, items: &Vec, selected: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lecture7/backpack.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | items: &Vec, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lecture7/backpack.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / let item_weight; [INFO] [stderr] 36 | | if cached_item != 0 { [INFO] [stderr] 37 | | selected.push(cached_item); [INFO] [stderr] 38 | | item_weight = items[cached_item - 1].1; [INFO] [stderr] 39 | | } else { [INFO] [stderr] 40 | | item_weight = 1; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let item_weight = if cached_item != 0 { ..; items[cached_item - 1].1 } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.86s [INFO] running `"docker" "inspect" "5a86e55af81eea55dd9953910637dd36902b308b3d89356f2f8d554497d4e117"` [INFO] running `"docker" "rm" "-f" "5a86e55af81eea55dd9953910637dd36902b308b3d89356f2f8d554497d4e117"` [INFO] [stdout] 5a86e55af81eea55dd9953910637dd36902b308b3d89356f2f8d554497d4e117