[INFO] updating cached repository msifd/advent-of-code-2016 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/msifd/advent-of-code-2016 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/msifd/advent-of-code-2016" "work/ex/clippy-test-run/sources/stable/gh/msifd/advent-of-code-2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/msifd/advent-of-code-2016'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/msifd/advent-of-code-2016" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msifd/advent-of-code-2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msifd/advent-of-code-2016'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7788489a5ea0e6cd1d1a1692c45652aa932ae1e3 [INFO] sha for GitHub repo msifd/advent-of-code-2016: 7788489a5ea0e6cd1d1a1692c45652aa932ae1e3 [INFO] validating manifest of msifd/advent-of-code-2016 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of msifd/advent-of-code-2016 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing msifd/advent-of-code-2016 [INFO] finished frobbing msifd/advent-of-code-2016 [INFO] frobbed toml for msifd/advent-of-code-2016 written to work/ex/clippy-test-run/sources/stable/gh/msifd/advent-of-code-2016/Cargo.toml [INFO] started frobbing msifd/advent-of-code-2016 [INFO] finished frobbing msifd/advent-of-code-2016 [INFO] frobbed toml for msifd/advent-of-code-2016 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msifd/advent-of-code-2016/Cargo.toml [INFO] crate msifd/advent-of-code-2016 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting msifd/advent-of-code-2016 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/msifd/advent-of-code-2016:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0df5a8e2ad1626c4384c64054586cf96377aa08e4865b29dc8f1c3593d385065 [INFO] running `"docker" "start" "-a" "0df5a8e2ad1626c4384c64054586cf96377aa08e4865b29dc8f1c3593d385065"` [INFO] [stderr] Compiling gcc v0.3.39 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking advent-of-code-2016 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_1.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return Some(int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(int)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_1.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return Some(int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(int)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/day_1.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 46 | fn intersection(p1: &Pos, p2: &Pos, p3: &Pos, p4: &Pos) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/day_1.rs:46:35 [INFO] [stderr] | [INFO] [stderr] 46 | fn intersection(p1: &Pos, p2: &Pos, p3: &Pos, p4: &Pos) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/day_1.rs:46:45 [INFO] [stderr] | [INFO] [stderr] 46 | fn intersection(p1: &Pos, p2: &Pos, p3: &Pos, p4: &Pos) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/day_1.rs:46:55 [INFO] [stderr] | [INFO] [stderr] 46 | fn intersection(p1: &Pos, p2: &Pos, p3: &Pos, p4: &Pos) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_2.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn decode(input: &InstrVecs) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_2.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn decode_real(input: &InstrVecs) -> String { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_3.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn count_valid(input: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Triple]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day_4.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | fn decrypt_name(encrypted: &String, shift: u32) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/day_4.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / input.iter() [INFO] [stderr] 71 | | .filter(|r| validate(r)) [INFO] [stderr] 72 | | .filter(|r| decrypt_name(&r.name, r.sector).contains("northpole")) [INFO] [stderr] 73 | | .next().unwrap().sector [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|r| decrypt_name(&r.name, r.sector).contains("northpole")).next()` with `find(|r| decrypt_name(&r.name, r.sector).contains("northpole"))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_6.rs:5:35 [INFO] [stderr] | [INFO] [stderr] 5 | let width = input.trim().find("\n").unwrap(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_7.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn count_tls_ips(input: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[IPv7]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/day_7.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | fn has_bab(bab: &[u8; 3], hypernet: &str) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_7.rs:52:38 [INFO] [stderr] | [INFO] [stderr] 52 | fn has_aba(seq: &str, hypernets: &Vec<&str>) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_7.rs:69:29 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn count_ssl_ips(input: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[IPv7]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/day_1.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 46 | fn intersection(p1: &Pos, p2: &Pos, p3: &Pos, p4: &Pos) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/day_1.rs:46:35 [INFO] [stderr] | [INFO] [stderr] 46 | fn intersection(p1: &Pos, p2: &Pos, p3: &Pos, p4: &Pos) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/day_1.rs:46:45 [INFO] [stderr] | [INFO] [stderr] 46 | fn intersection(p1: &Pos, p2: &Pos, p3: &Pos, p4: &Pos) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/day_1.rs:46:55 [INFO] [stderr] | [INFO] [stderr] 46 | fn intersection(p1: &Pos, p2: &Pos, p3: &Pos, p4: &Pos) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_2.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn decode(input: &InstrVecs) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_2.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn decode_real(input: &InstrVecs) -> String { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_3.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn count_valid(input: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Triple]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day_4.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | fn decrypt_name(encrypted: &String, shift: u32) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/day_4.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / input.iter() [INFO] [stderr] 71 | | .filter(|r| validate(r)) [INFO] [stderr] 72 | | .filter(|r| decrypt_name(&r.name, r.sector).contains("northpole")) [INFO] [stderr] 73 | | .next().unwrap().sector [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|r| decrypt_name(&r.name, r.sector).contains("northpole")).next()` with `find(|r| decrypt_name(&r.name, r.sector).contains("northpole"))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_6.rs:5:35 [INFO] [stderr] | [INFO] [stderr] 5 | let width = input.trim().find("\n").unwrap(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_7.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn count_tls_ips(input: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[IPv7]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/day_7.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | fn has_bab(bab: &[u8; 3], hypernet: &str) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_7.rs:52:38 [INFO] [stderr] | [INFO] [stderr] 52 | fn has_aba(seq: &str, hypernets: &Vec<&str>) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_7.rs:69:29 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn count_ssl_ips(input: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[IPv7]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.41s [INFO] running `"docker" "inspect" "0df5a8e2ad1626c4384c64054586cf96377aa08e4865b29dc8f1c3593d385065"` [INFO] running `"docker" "rm" "-f" "0df5a8e2ad1626c4384c64054586cf96377aa08e4865b29dc8f1c3593d385065"` [INFO] [stdout] 0df5a8e2ad1626c4384c64054586cf96377aa08e4865b29dc8f1c3593d385065