[INFO] updating cached repository msierks/rustcube
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/msierks/rustcube
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/msierks/rustcube" "work/ex/clippy-test-run/sources/stable/gh/msierks/rustcube"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/msierks/rustcube'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/msierks/rustcube" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msierks/rustcube"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msierks/rustcube'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b85486fae37e8e2e24889881b7f9ae9296fb1376
[INFO] sha for GitHub repo msierks/rustcube: b85486fae37e8e2e24889881b7f9ae9296fb1376
[INFO] validating manifest of msierks/rustcube on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of msierks/rustcube on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing msierks/rustcube
[INFO] finished frobbing msierks/rustcube
[INFO] frobbed toml for msierks/rustcube written to work/ex/clippy-test-run/sources/stable/gh/msierks/rustcube/Cargo.toml
[INFO] started frobbing msierks/rustcube
[INFO] finished frobbing msierks/rustcube
[INFO] frobbed toml for msierks/rustcube written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msierks/rustcube/Cargo.toml
[INFO] crate msierks/rustcube has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting msierks/rustcube against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/msierks/rustcube:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 236225cd3502aeba6c4606c8ac8ef8a8469b8eae90a212f3e7c2f8684f40f8ba
[INFO] running `"docker" "start" "-a" "236225cd3502aeba6c4606c8ac8ef8a8469b8eae90a212f3e7c2f8684f40f8ba"`
[INFO] [stderr]    Compiling x11-dl v2.14.0
[INFO] [stderr]    Compiling minifb v0.10.6
[INFO] [stderr]     Checking nix v0.5.1
[INFO] [stderr]     Checking bytes v0.4.7
[INFO] [stderr]     Checking num-bigint v0.1.44
[INFO] [stderr]     Checking nix v0.10.0
[INFO] [stderr]     Checking num-rational v0.1.42
[INFO] [stderr]     Checking num v0.1.42
[INFO] [stderr]     Checking rustyline v1.0.0
[INFO] [stderr]     Checking rustcube v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lib.rs:2:43
[INFO] [stderr]   |
[INFO] [stderr] 2 | #![cfg_attr(feature="cargo-clippy", allow(inline_always))]
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lib.rs:3:43
[INFO] [stderr]   |
[INFO] [stderr] 3 | #![cfg_attr(feature="cargo-clippy", allow(many_single_char_names))]
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `new_without_default` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lib.rs:4:43
[INFO] [stderr]   |
[INFO] [stderr] 4 | #![cfg_attr(feature="cargo-clippy", allow(new_without_default))]
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lib.rs:5:43
[INFO] [stderr]   |
[INFO] [stderr] 5 | #![cfg_attr(feature="cargo-clippy", allow(new_without_default_derive))]
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lib.rs:6:43
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![cfg_attr(feature="cargo-clippy", allow(unreadable_literal))]
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal`
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/debugger/console.rs:59:13
[INFO] [stderr]    |
[INFO] [stderr] 59 |             data: data
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/debugger/mod.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |             console: console,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `console`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:84:13
[INFO] [stderr]    |
[INFO] [stderr] 84 |             text_offset: text_offset,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_offset`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:85:13
[INFO] [stderr]    |
[INFO] [stderr] 85 |             data_offset: data_offset,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |             text_address: text_address,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_address`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             data_address: data_address,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_address`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             text_size: text_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |             data_size: data_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:96:13
[INFO] [stderr]    |
[INFO] [stderr] 96 |             header: header,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:97:13
[INFO] [stderr]    |
[INFO] [stderr] 97 |             text_sections: text_sections,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_sections`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:98:13
[INFO] [stderr]    |
[INFO] [stderr] 98 |             data_sections: data_sections
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_sections`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/exi/channel.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             devices: devices
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `devices`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/exi/channel.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |             transfer_type:   transfer_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transfer_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/exi/channel.rs:174:13
[INFO] [stderr]     |
[INFO] [stderr] 174 |             transfer_mode:   transfer_mode,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transfer_mode`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/exi/device_ipl.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             bootrom: bootrom,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `bootrom`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/interconnect.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |             bootrom: bootrom,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `bootrom`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/video_interface.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             window: window
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `window`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lib.rs:2:43
[INFO] [stderr]   |
[INFO] [stderr] 2 | #![cfg_attr(feature="cargo-clippy", allow(inline_always))]
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lib.rs:3:43
[INFO] [stderr]   |
[INFO] [stderr] 3 | #![cfg_attr(feature="cargo-clippy", allow(many_single_char_names))]
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `new_without_default` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lib.rs:4:43
[INFO] [stderr]   |
[INFO] [stderr] 4 | #![cfg_attr(feature="cargo-clippy", allow(new_without_default))]
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lib.rs:5:43
[INFO] [stderr]   |
[INFO] [stderr] 5 | #![cfg_attr(feature="cargo-clippy", allow(new_without_default_derive))]
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lib.rs:6:43
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![cfg_attr(feature="cargo-clippy", allow(unreadable_literal))]
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal`
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/debugger/console.rs:59:13
[INFO] [stderr]    |
[INFO] [stderr] 59 |             data: data
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/debugger/mod.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |             console: console,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `console`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:84:13
[INFO] [stderr]    |
[INFO] [stderr] 84 |             text_offset: text_offset,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_offset`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:85:13
[INFO] [stderr]    |
[INFO] [stderr] 85 |             data_offset: data_offset,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |             text_address: text_address,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_address`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             data_address: data_address,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_address`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             text_size: text_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |             data_size: data_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:96:13
[INFO] [stderr]    |
[INFO] [stderr] 96 |             header: header,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:97:13
[INFO] [stderr]    |
[INFO] [stderr] 97 |             text_sections: text_sections,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_sections`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dol.rs:98:13
[INFO] [stderr]    |
[INFO] [stderr] 98 |             data_sections: data_sections
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_sections`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/exi/channel.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             devices: devices
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `devices`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/exi/channel.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |             transfer_type:   transfer_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transfer_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/exi/channel.rs:174:13
[INFO] [stderr]     |
[INFO] [stderr] 174 |             transfer_mode:   transfer_mode,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transfer_mode`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/exi/device_ipl.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             bootrom: bootrom,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `bootrom`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/interconnect.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |             bootrom: bootrom,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `bootrom`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/video_interface.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             window: window
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `window`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lib.rs:2:43
[INFO] [stderr]   |
[INFO] [stderr] 2 | #![cfg_attr(feature="cargo-clippy", allow(inline_always))]
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lib.rs:2:43
[INFO] [stderr]   |
[INFO] [stderr] 2 | #![cfg_attr(feature="cargo-clippy", allow(inline_always))]
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always`
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/debugger/disassembler.rs:112:16
[INFO] [stderr]     |
[INFO] [stderr] 112 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 113 | |             if instr.a() == 0 {
[INFO] [stderr] 114 | |                 self.opcode = String::from("li");
[INFO] [stderr] 115 | |                 self.operands = format!("r{},{}", instr.d(), instr.simm());
[INFO] [stderr] ...   |
[INFO] [stderr] 119 | |             }
[INFO] [stderr] 120 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 112 |         } else if instr.a() == 0 {
[INFO] [stderr] 113 |     self.opcode = String::from("li");
[INFO] [stderr] 114 |     self.operands = format!("r{},{}", instr.d(), instr.simm());
[INFO] [stderr] 115 | } else {
[INFO] [stderr] 116 |     self.opcode = format!("addi{}", ext);
[INFO] [stderr] 117 |     self.operands = format!("r{},r{},{}", instr.d(), instr.a(), instr.simm());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/debugger/disassembler.rs:130:16
[INFO] [stderr]     |
[INFO] [stderr] 130 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 131 | |             if instr.rc() {
[INFO] [stderr] 132 | |                 self.opcode = String::from("add.");
[INFO] [stderr] 133 | |             } else {
[INFO] [stderr] 134 | |                 self.opcode = String::from("add");
[INFO] [stderr] 135 | |             }
[INFO] [stderr] 136 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 130 |         } else if instr.rc() {
[INFO] [stderr] 131 |     self.opcode = String::from("add.");
[INFO] [stderr] 132 | } else {
[INFO] [stderr] 133 |     self.opcode = String::from("add");
[INFO] [stderr] 134 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/debugger/disassembler.rs:163:16
[INFO] [stderr]     |
[INFO] [stderr] 163 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 164 | |             if instr.lk() == 0 {
[INFO] [stderr] 165 | |                 self.opcode = String::from("ba");
[INFO] [stderr] 166 | |             } else {
[INFO] [stderr] 167 | |                 self.opcode = String::from("bla");
[INFO] [stderr] 168 | |             }            
[INFO] [stderr] 169 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 163 |         } else if instr.lk() == 0 {
[INFO] [stderr] 164 |     self.opcode = String::from("ba");
[INFO] [stderr] 165 | } else {
[INFO] [stderr] 166 |     self.opcode = String::from("bla");
[INFO] [stderr] 167 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/debugger/disassembler.rs:189:16
[INFO] [stderr]     |
[INFO] [stderr] 189 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 190 | |             if instr.lk() == 0 {
[INFO] [stderr] 191 | |                 "a"
[INFO] [stderr] 192 | |             } else {
[INFO] [stderr] 193 | |                 "la"
[INFO] [stderr] 194 | |             }
[INFO] [stderr] 195 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 189 |         } else if instr.lk() == 0 {
[INFO] [stderr] 190 |     "a"
[INFO] [stderr] 191 | } else {
[INFO] [stderr] 192 |     "la"
[INFO] [stderr] 193 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/debugger/disassembler.rs:237:16
[INFO] [stderr]     |
[INFO] [stderr] 237 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 238 | |             if instr.lk() == 0 {
[INFO] [stderr] 239 | |                 "a"
[INFO] [stderr] 240 | |             } else {
[INFO] [stderr] 241 | |                 "la"
[INFO] [stderr] 242 | |             }
[INFO] [stderr] 243 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 237 |         } else if instr.lk() == 0 {
[INFO] [stderr] 238 |     "a"
[INFO] [stderr] 239 | } else {
[INFO] [stderr] 240 |     "la"
[INFO] [stderr] 241 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/debugger/disassembler.rs:112:16
[INFO] [stderr]     |
[INFO] [stderr] 112 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 113 | |             if instr.a() == 0 {
[INFO] [stderr] 114 | |                 self.opcode = String::from("li");
[INFO] [stderr] 115 | |                 self.operands = format!("r{},{}", instr.d(), instr.simm());
[INFO] [stderr] ...   |
[INFO] [stderr] 119 | |             }
[INFO] [stderr] 120 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 112 |         } else if instr.a() == 0 {
[INFO] [stderr] 113 |     self.opcode = String::from("li");
[INFO] [stderr] 114 |     self.operands = format!("r{},{}", instr.d(), instr.simm());
[INFO] [stderr] 115 | } else {
[INFO] [stderr] 116 |     self.opcode = format!("addi{}", ext);
[INFO] [stderr] 117 |     self.operands = format!("r{},r{},{}", instr.d(), instr.a(), instr.simm());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/debugger/disassembler.rs:130:16
[INFO] [stderr]     |
[INFO] [stderr] 130 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 131 | |             if instr.rc() {
[INFO] [stderr] 132 | |                 self.opcode = String::from("add.");
[INFO] [stderr] 133 | |             } else {
[INFO] [stderr] 134 | |                 self.opcode = String::from("add");
[INFO] [stderr] 135 | |             }
[INFO] [stderr] 136 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 130 |         } else if instr.rc() {
[INFO] [stderr] 131 |     self.opcode = String::from("add.");
[INFO] [stderr] 132 | } else {
[INFO] [stderr] 133 |     self.opcode = String::from("add");
[INFO] [stderr] 134 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/debugger/disassembler.rs:163:16
[INFO] [stderr]     |
[INFO] [stderr] 163 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 164 | |             if instr.lk() == 0 {
[INFO] [stderr] 165 | |                 self.opcode = String::from("ba");
[INFO] [stderr] 166 | |             } else {
[INFO] [stderr] 167 | |                 self.opcode = String::from("bla");
[INFO] [stderr] 168 | |             }            
[INFO] [stderr] 169 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 163 |         } else if instr.lk() == 0 {
[INFO] [stderr] 164 |     self.opcode = String::from("ba");
[INFO] [stderr] 165 | } else {
[INFO] [stderr] 166 |     self.opcode = String::from("bla");
[INFO] [stderr] 167 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/debugger/disassembler.rs:189:16
[INFO] [stderr]     |
[INFO] [stderr] 189 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 190 | |             if instr.lk() == 0 {
[INFO] [stderr] 191 | |                 "a"
[INFO] [stderr] 192 | |             } else {
[INFO] [stderr] 193 | |                 "la"
[INFO] [stderr] 194 | |             }
[INFO] [stderr] 195 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 189 |         } else if instr.lk() == 0 {
[INFO] [stderr] 190 |     "a"
[INFO] [stderr] 191 | } else {
[INFO] [stderr] 192 |     "la"
[INFO] [stderr] 193 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/debugger/disassembler.rs:237:16
[INFO] [stderr]     |
[INFO] [stderr] 237 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 238 | |             if instr.lk() == 0 {
[INFO] [stderr] 239 | |                 "a"
[INFO] [stderr] 240 | |             } else {
[INFO] [stderr] 241 | |                 "la"
[INFO] [stderr] 242 | |             }
[INFO] [stderr] 243 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 237 |         } else if instr.lk() == 0 {
[INFO] [stderr] 238 |     "a"
[INFO] [stderr] 239 | } else {
[INFO] [stderr] 240 |     "la"
[INFO] [stderr] 241 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:19:19
[INFO] [stderr]    |
[INFO] [stderr] 19 |         value |=  self.value[7] as u32;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[7])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:20:18
[INFO] [stderr]    |
[INFO] [stderr] 20 |         value |= (self.value[6] as u32) << 4;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[6])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:21:18
[INFO] [stderr]    |
[INFO] [stderr] 21 |         value |= (self.value[5] as u32) << 8;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[5])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:22:18
[INFO] [stderr]    |
[INFO] [stderr] 22 |         value |= (self.value[4] as u32) << 12;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[4])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:23:18
[INFO] [stderr]    |
[INFO] [stderr] 23 |         value |= (self.value[3] as u32) << 16;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |         value |= (self.value[2] as u32) << 20;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:25:18
[INFO] [stderr]    |
[INFO] [stderr] 25 |         value |= (self.value[1] as u32) << 24;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         value |= (self.value[0] as u32) << 28;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cpu/gqr.rs:20:20
[INFO] [stderr]    |
[INFO] [stderr] 20 |     pub fn ld_type(&self) -> u8 {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cpu/gqr.rs:30:20
[INFO] [stderr]    |
[INFO] [stderr] 30 |     pub fn st_type(&self) -> u8 {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/hid.rs:38:18
[INFO] [stderr]    |
[INFO] [stderr] 38 |         value |= (self.dma_queue_length as u32)      << 24;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.dma_queue_length)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:19:19
[INFO] [stderr]    |
[INFO] [stderr] 19 |         value |=  self.value[7] as u32;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[7])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:20:18
[INFO] [stderr]    |
[INFO] [stderr] 20 |         value |= (self.value[6] as u32) << 4;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[6])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:21:18
[INFO] [stderr]    |
[INFO] [stderr] 21 |         value |= (self.value[5] as u32) << 8;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[5])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:22:18
[INFO] [stderr]    |
[INFO] [stderr] 22 |         value |= (self.value[4] as u32) << 12;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[4])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:23:18
[INFO] [stderr]    |
[INFO] [stderr] 23 |         value |= (self.value[3] as u32) << 16;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |         value |= (self.value[2] as u32) << 20;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:25:18
[INFO] [stderr]    |
[INFO] [stderr] 25 |         value |= (self.value[1] as u32) << 24;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cr.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         value |= (self.value[0] as u32) << 28;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.value[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cpu/gqr.rs:20:20
[INFO] [stderr]    |
[INFO] [stderr] 20 |     pub fn ld_type(&self) -> u8 {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cpu/gqr.rs:30:20
[INFO] [stderr]    |
[INFO] [stderr] 30 |     pub fn st_type(&self) -> u8 {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/xer.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         value |= (self.byte_count as u32) & 0x7F;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.byte_count)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/hid.rs:38:18
[INFO] [stderr]    |
[INFO] [stderr] 38 |         value |= (self.dma_queue_length as u32)      << 24;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.dma_queue_length)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/mmu.rs:92:28
[INFO] [stderr]    |
[INFO] [stderr] 92 |                let upper = (bat.brpn ^ ((ea_15 & 0x7FF) & bat.bl)) as u32;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bat.brpn ^ ((ea_15 & 0x7FF) & bat.bl))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/util.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         (x | 0xF000) as i32
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(x | 0xF000)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/util.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         x as i32
[INFO] [stderr]    |         ^^^^^^^^ help: try: `i32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/util.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     (x as i16) as i32
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: try: `i32::from((x as i16))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_integer.rs:21:35
[INFO] [stderr]    |
[INFO] [stderr] 21 |             self.gpr[instr.d()] = (instr.simm() as i32) as u32;
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_integer.rs:23:68
[INFO] [stderr]    |
[INFO] [stderr] 23 |             self.gpr[instr.d()] = self.gpr[instr.a()].wrapping_add((instr.simm() as i32) as u32);
[INFO] [stderr]    |                                                                    ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_integer.rs:29:19
[INFO] [stderr]    |
[INFO] [stderr] 29 |         let imm = (instr.simm() as i32) as u32;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_integer.rs:38:19
[INFO] [stderr]    |
[INFO] [stderr] 38 |         let imm = (instr.simm() as i32) as u32;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:163:17
[INFO] [stderr]     |
[INFO] [stderr] 163 |         let b = instr.simm() as i32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:284:31
[INFO] [stderr]     |
[INFO] [stderr] 284 |         self.gpr[instr.a()] = ((self.gpr[instr.s()] as i8) as i32) as u32;
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((self.gpr[instr.s()] as i8))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:292:31
[INFO] [stderr]     |
[INFO] [stderr] 292 |         self.gpr[instr.a()] = ((self.gpr[instr.s()] as i16) as i32) as u32;
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((self.gpr[instr.s()] as i16))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:300:17
[INFO] [stderr]     |
[INFO] [stderr] 300 |         let a = self.gpr[instr.a()] as u64;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.gpr[instr.a()])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:301:17
[INFO] [stderr]     |
[INFO] [stderr] 301 |         let b = self.gpr[instr.b()] as u64;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.gpr[instr.b()])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:311:73
[INFO] [stderr]     |
[INFO] [stderr] 311 |         self.gpr[instr.d()] = (self.gpr[instr.a()] as i32).wrapping_mul(instr.simm() as i32) as u32;
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/xer.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         value |= (self.byte_count as u32) & 0x7F;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.byte_count)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:365:49
[INFO] [stderr]     |
[INFO] [stderr] 365 |         let r = self.gpr[instr.s()].rotate_left(instr.sh() as u32);
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^ help: try: `u32::from(instr.sh())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:377:64
[INFO] [stderr]     |
[INFO] [stderr] 377 |         self.gpr[instr.a()] = (self.gpr[instr.s()].rotate_left(instr.sh() as u32)) & mask;
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^^ help: try: `u32::from(instr.sh())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:515:19
[INFO] [stderr]     |
[INFO] [stderr] 515 |         let imm = (instr.simm() as i32) + 1;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:25:31
[INFO] [stderr]    |
[INFO] [stderr] 25 |         self.gpr[instr.d()] = interconnect.read_u8(&self.msr, ea) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_u8(&self.msr, ea))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:35:31
[INFO] [stderr]    |
[INFO] [stderr] 35 |         self.gpr[instr.d()] = interconnect.read_u8(&self.msr, ea) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_u8(&self.msr, ea))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:46:31
[INFO] [stderr]    |
[INFO] [stderr] 46 |         self.gpr[instr.d()] = interconnect.read_u8(&self.msr, ea) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_u8(&self.msr, ea))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:71:36
[INFO] [stderr]    |
[INFO] [stderr] 71 |             self.fpr[instr.d()] = ((val as u64) << 32) & val as u64;
[INFO] [stderr]    |                                    ^^^^^^^^^^^^ help: try: `u64::from(val)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:71:58
[INFO] [stderr]    |
[INFO] [stderr] 71 |             self.fpr[instr.d()] = ((val as u64) << 32) & val as u64;
[INFO] [stderr]    |                                                          ^^^^^^^^^^ help: try: `u64::from(val)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:82:31
[INFO] [stderr]    |
[INFO] [stderr] 82 |         self.gpr[instr.d()] = ((interconnect.read_u16(&self.msr, ea) as i16) as i32) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((interconnect.read_u16(&self.msr, ea) as i16))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:92:31
[INFO] [stderr]    |
[INFO] [stderr] 92 |         self.gpr[instr.d()] = interconnect.read_u16(&self.msr, ea) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_u16(&self.msr, ea))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:98:31
[INFO] [stderr]    |
[INFO] [stderr] 98 |         self.gpr[instr.d()] = interconnect.read_u16(&self.msr, ea) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_u16(&self.msr, ea))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/mmu.rs:92:28
[INFO] [stderr]    |
[INFO] [stderr] 92 |                let upper = (bat.brpn ^ ((ea_15 & 0x7FF) & bat.bl)) as u32;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bat.brpn ^ ((ea_15 & 0x7FF) & bat.bl))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_load_store.rs:171:44
[INFO] [stderr]     |
[INFO] [stderr] 171 |                     self.fpr[instr.d()] = ((ps0 as u64) << 32) | (ps1 as u64);
[INFO] [stderr]     |                                            ^^^^^^^^^^^^ help: try: `u64::from(ps0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_load_store.rs:178:44
[INFO] [stderr]     |
[INFO] [stderr] 178 |                     self.fpr[instr.d()] = ((value.0 as u64) << 32) | (value.1 as u64);
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^ help: try: `u64::from(value.0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_load_store.rs:178:70
[INFO] [stderr]     |
[INFO] [stderr] 178 |                     self.fpr[instr.d()] = ((value.0 as u64) << 32) | (value.1 as u64);
[INFO] [stderr]     |                                                                      ^^^^^^^^^^^^^^^^ help: try: `u64::from(value.1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 35
[INFO] [stderr]    --> src/cpu/msr.rs:138:5
[INFO] [stderr]     |
[INFO] [stderr] 138 | /     fn u32_conversion() {
[INFO] [stderr] 139 | |         let msr: Msr = 0x55555.into();
[INFO] [stderr] 140 | |
[INFO] [stderr] 141 | |         assert!(msr.power_management);
[INFO] [stderr] ...   |
[INFO] [stderr] 179 | |         assert_eq!(0xAA22, msr.as_u32());
[INFO] [stderr] 180 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/util.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         (x | 0xF000) as i32
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(x | 0xF000)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/util.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         x as i32
[INFO] [stderr]    |         ^^^^^^^^ help: try: `i32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/util.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     (x as i16) as i32
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: try: `i32::from((x as i16))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_integer.rs:21:35
[INFO] [stderr]    |
[INFO] [stderr] 21 |             self.gpr[instr.d()] = (instr.simm() as i32) as u32;
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_integer.rs:23:68
[INFO] [stderr]    |
[INFO] [stderr] 23 |             self.gpr[instr.d()] = self.gpr[instr.a()].wrapping_add((instr.simm() as i32) as u32);
[INFO] [stderr]    |                                                                    ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_integer.rs:29:19
[INFO] [stderr]    |
[INFO] [stderr] 29 |         let imm = (instr.simm() as i32) as u32;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_integer.rs:38:19
[INFO] [stderr]    |
[INFO] [stderr] 38 |         let imm = (instr.simm() as i32) as u32;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:163:17
[INFO] [stderr]     |
[INFO] [stderr] 163 |         let b = instr.simm() as i32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:284:31
[INFO] [stderr]     |
[INFO] [stderr] 284 |         self.gpr[instr.a()] = ((self.gpr[instr.s()] as i8) as i32) as u32;
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((self.gpr[instr.s()] as i8))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:292:31
[INFO] [stderr]     |
[INFO] [stderr] 292 |         self.gpr[instr.a()] = ((self.gpr[instr.s()] as i16) as i32) as u32;
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((self.gpr[instr.s()] as i16))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:300:17
[INFO] [stderr]     |
[INFO] [stderr] 300 |         let a = self.gpr[instr.a()] as u64;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.gpr[instr.a()])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:301:17
[INFO] [stderr]     |
[INFO] [stderr] 301 |         let b = self.gpr[instr.b()] as u64;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.gpr[instr.b()])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:311:73
[INFO] [stderr]     |
[INFO] [stderr] 311 |         self.gpr[instr.d()] = (self.gpr[instr.a()] as i32).wrapping_mul(instr.simm() as i32) as u32;
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:365:49
[INFO] [stderr]     |
[INFO] [stderr] 365 |         let r = self.gpr[instr.s()].rotate_left(instr.sh() as u32);
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^ help: try: `u32::from(instr.sh())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:377:64
[INFO] [stderr]     |
[INFO] [stderr] 377 |         self.gpr[instr.a()] = (self.gpr[instr.s()].rotate_left(instr.sh() as u32)) & mask;
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^^ help: try: `u32::from(instr.sh())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/debugger/console.rs:85:29
[INFO] [stderr]    |
[INFO] [stderr] 85 |     fn advance(&self, args: &Vec<&str>, debugger: &mut ConsoleDebugger) {
[INFO] [stderr]    |                             ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_integer.rs:515:19
[INFO] [stderr]     |
[INFO] [stderr] 515 |         let imm = (instr.simm() as i32) + 1;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(instr.simm())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/debugger/console.rs:97:28
[INFO] [stderr]    |
[INFO] [stderr] 97 |     fn break_(&self, args: &Vec<&str>, debugger: &mut ConsoleDebugger) {
[INFO] [stderr]    |                            ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/debugger/console.rs:108:29
[INFO] [stderr]     |
[INFO] [stderr] 108 |     fn examine(&self, args: &Vec<&str>, cpu: &mut Cpu, interconnect: &mut Interconnect) {
[INFO] [stderr]     |                             ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:25:31
[INFO] [stderr]    |
[INFO] [stderr] 25 |         self.gpr[instr.d()] = interconnect.read_u8(&self.msr, ea) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_u8(&self.msr, ea))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/debugger/console.rs:119:28
[INFO] [stderr]     |
[INFO] [stderr] 119 |     fn watch_(&self, args: &Vec<&str>, debugger: &mut ConsoleDebugger) {
[INFO] [stderr]     |                            ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:35:31
[INFO] [stderr]    |
[INFO] [stderr] 35 |         self.gpr[instr.d()] = interconnect.read_u8(&self.msr, ea) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_u8(&self.msr, ea))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/debugger/console.rs:130:27
[INFO] [stderr]     |
[INFO] [stderr] 130 |     fn clear(&self, args: &Vec<&str>, debugger: &mut ConsoleDebugger) {
[INFO] [stderr]     |                           ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:46:31
[INFO] [stderr]    |
[INFO] [stderr] 46 |         self.gpr[instr.d()] = interconnect.read_u8(&self.msr, ea) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_u8(&self.msr, ea))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/debugger/console.rs:144:26
[INFO] [stderr]     |
[INFO] [stderr] 144 |     fn help(&self, args: &Vec<&str>) {
[INFO] [stderr]     |                          ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:71:36
[INFO] [stderr]    |
[INFO] [stderr] 71 |             self.fpr[instr.d()] = ((val as u64) << 32) & val as u64;
[INFO] [stderr]    |                                    ^^^^^^^^^^^^ help: try: `u64::from(val)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:71:58
[INFO] [stderr]    |
[INFO] [stderr] 71 |             self.fpr[instr.d()] = ((val as u64) << 32) & val as u64;
[INFO] [stderr]    |                                                          ^^^^^^^^^^ help: try: `u64::from(val)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:82:31
[INFO] [stderr]    |
[INFO] [stderr] 82 |         self.gpr[instr.d()] = ((interconnect.read_u16(&self.msr, ea) as i16) as i32) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((interconnect.read_u16(&self.msr, ea) as i16))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/debugger/console.rs:161:26
[INFO] [stderr]     |
[INFO] [stderr] 161 |     fn show(&self, args: &Vec<&str>, debugger: &mut ConsoleDebugger, cpu: &mut Cpu, interconnect: &mut Interconnect) {
[INFO] [stderr]     |                          ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:92:31
[INFO] [stderr]    |
[INFO] [stderr] 92 |         self.gpr[instr.d()] = interconnect.read_u16(&self.msr, ea) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_u16(&self.msr, ea))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu_load_store.rs:98:31
[INFO] [stderr]    |
[INFO] [stderr] 98 |         self.gpr[instr.d()] = interconnect.read_u16(&self.msr, ea) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_u16(&self.msr, ea))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_load_store.rs:171:44
[INFO] [stderr]     |
[INFO] [stderr] 171 |                     self.fpr[instr.d()] = ((ps0 as u64) << 32) | (ps1 as u64);
[INFO] [stderr]     |                                            ^^^^^^^^^^^^ help: try: `u64::from(ps0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_load_store.rs:178:44
[INFO] [stderr]     |
[INFO] [stderr] 178 |                     self.fpr[instr.d()] = ((value.0 as u64) << 32) | (value.1 as u64);
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^ help: try: `u64::from(value.0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu_load_store.rs:178:70
[INFO] [stderr]     |
[INFO] [stderr] 178 |                     self.fpr[instr.d()] = ((value.0 as u64) << 32) | (value.1 as u64);
[INFO] [stderr]     |                                                                      ^^^^^^^^^^^^^^^^ help: try: `u64::from(value.1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/debugger/console.rs:193:26
[INFO] [stderr]     |
[INFO] [stderr] 193 |     fn step(&self, args: &Vec<&str>, debugger: &mut ConsoleDebugger) {
[INFO] [stderr]     |                          ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/debugger/console.rs:85:29
[INFO] [stderr]    |
[INFO] [stderr] 85 |     fn advance(&self, args: &Vec<&str>, debugger: &mut ConsoleDebugger) {
[INFO] [stderr]    |                             ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/debugger/console.rs:97:28
[INFO] [stderr]    |
[INFO] [stderr] 97 |     fn break_(&self, args: &Vec<&str>, debugger: &mut ConsoleDebugger) {
[INFO] [stderr]    |                            ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/debugger/console.rs:108:29
[INFO] [stderr]     |
[INFO] [stderr] 108 |     fn examine(&self, args: &Vec<&str>, cpu: &mut Cpu, interconnect: &mut Interconnect) {
[INFO] [stderr]     |                             ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/debugger/console.rs:119:28
[INFO] [stderr]     |
[INFO] [stderr] 119 |     fn watch_(&self, args: &Vec<&str>, debugger: &mut ConsoleDebugger) {
[INFO] [stderr]     |                            ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/debugger/console.rs:130:27
[INFO] [stderr]     |
[INFO] [stderr] 130 |     fn clear(&self, args: &Vec<&str>, debugger: &mut ConsoleDebugger) {
[INFO] [stderr]     |                           ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/debugger/console.rs:144:26
[INFO] [stderr]     |
[INFO] [stderr] 144 |     fn help(&self, args: &Vec<&str>) {
[INFO] [stderr]     |                          ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/debugger/console.rs:161:26
[INFO] [stderr]     |
[INFO] [stderr] 161 |     fn show(&self, args: &Vec<&str>, debugger: &mut ConsoleDebugger, cpu: &mut Cpu, interconnect: &mut Interconnect) {
[INFO] [stderr]     |                          ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/debugger/console.rs:193:26
[INFO] [stderr]     |
[INFO] [stderr] 193 |     fn step(&self, args: &Vec<&str>, debugger: &mut ConsoleDebugger) {
[INFO] [stderr]     |                          ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/dol.rs:59:48
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 try!(file.seek(SeekFrom::Start(text_offset[x] as u64)));
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(text_offset[x])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/dol.rs:75:48
[INFO] [stderr]    |
[INFO] [stderr] 75 |                 try!(file.seek(SeekFrom::Start(data_offset[x] as u64)));
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data_offset[x])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/exi/channel.rs:34:42
[INFO] [stderr]    |
[INFO] [stderr] 34 |     pub fn get_device(&self, num: u8) -> &Box<Device> {
[INFO] [stderr]    |                                          ^^^^^^^^^^^^ help: try: `&Device`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/exi/channel.rs:41:50
[INFO] [stderr]    |
[INFO] [stderr] 41 |     pub fn get_device_mut(&mut self, num: u8) -> &mut Box<Device> {
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^ help: try: `&mut Device`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/exi/channel.rs:71:18
[INFO] [stderr]    |
[INFO] [stderr] 71 |         value |= (device as u32) << 7;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^ help: try: `u32::from(device)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/exi/channel.rs:72:18
[INFO] [stderr]    |
[INFO] [stderr] 72 |         value |= (self.exi_frequency as u32) << 4;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.exi_frequency)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/exi/channel.rs:137:18
[INFO] [stderr]     |
[INFO] [stderr] 137 |         value |= (self.transfer_length as u32) << 4;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.transfer_length)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/exi/device_ipl.rs:148:28
[INFO] [stderr]     |
[INFO] [stderr] 148 |             self.offset += len as u32;
[INFO] [stderr]     |                            ^^^^^^^^^^ help: try: `u32::from(len)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/gamecube.rs:126:18
[INFO] [stderr]     |
[INFO] [stderr] 126 |         acc = (2*acc as u16 + x as u16) as u8;
[INFO] [stderr]     |                  ^^^^^^^^^^ help: try: `u16::from(acc)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/gamecube.rs:126:31
[INFO] [stderr]     |
[INFO] [stderr] 126 |         acc = (2*acc as u16 + x as u16) as u8;
[INFO] [stderr]     |                               ^^^^^^^^ help: try: `u16::from(x)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/gp_fifo.rs:37:72
[INFO] [stderr]    |
[INFO] [stderr] 37 |                 ram.write_dma(pi.fifo_write_pointer, &self.gather_pipe[processed..processed + GATHER_PIPE_BURST + 1]);
[INFO] [stderr]    |                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `processed..=processed + GATHER_PIPE_BURST`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `buf`
[INFO] [stderr]   --> src/memory.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for i in 0..buf.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/dol.rs:59:48
[INFO] [stderr]    |
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 try!(file.seek(SeekFrom::Start(text_offset[x] as u64)));
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(text_offset[x])`
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr]    |
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for (i, <item>) in buf.iter_mut().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/dol.rs:75:48
[INFO] [stderr]    |
[INFO] [stderr] 75 |                 try!(file.seek(SeekFrom::Start(data_offset[x] as u64)));
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data_offset[x])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `buf`
[INFO] [stderr]   --> src/memory.rs:59:18
[INFO] [stderr]    |
[INFO] [stderr] 59 |         for i in 0..buf.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 59 |         for (i, <item>) in buf.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/exi/channel.rs:34:42
[INFO] [stderr]    |
[INFO] [stderr] 34 |     pub fn get_device(&self, num: u8) -> &Box<Device> {
[INFO] [stderr]    |                                          ^^^^^^^^^^^^ help: try: `&Device`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/exi/channel.rs:41:50
[INFO] [stderr]    |
[INFO] [stderr] 41 |     pub fn get_device_mut(&mut self, num: u8) -> &mut Box<Device> {
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^ help: try: `&mut Device`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/exi/channel.rs:71:18
[INFO] [stderr]    |
[INFO] [stderr] 71 |         value |= (device as u32) << 7;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^ help: try: `u32::from(device)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/exi/channel.rs:72:18
[INFO] [stderr]    |
[INFO] [stderr] 72 |         value |= (self.exi_frequency as u32) << 4;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.exi_frequency)`
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:144:30
[INFO] [stderr]     |
[INFO] [stderr] 144 |                     let y1 = ram.read_u8(i) as i32;
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ram.read_u8(i))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:145:30
[INFO] [stderr]     |
[INFO] [stderr] 145 |                     let v  = ram.read_u8(i + 1) as i32;
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ram.read_u8(i + 1))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:146:30
[INFO] [stderr]     |
[INFO] [stderr] 146 |                     let y2 = ram.read_u8(i + 2) as i32;
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ram.read_u8(i + 2))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:147:30
[INFO] [stderr]     |
[INFO] [stderr] 147 |                     let u  = ram.read_u8(i + 3) as i32;
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ram.read_u8(i + 3))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/video_interface.rs:156:17
[INFO] [stderr]     |
[INFO] [stderr] 156 |                 self.window.update_with_buffer(&self.buffer);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/exi/channel.rs:137:18
[INFO] [stderr]     |
[INFO] [stderr] 137 |         value |= (self.transfer_length as u32) << 4;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.transfer_length)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:233:18
[INFO] [stderr]     |
[INFO] [stderr] 233 |         value |= (self.format as u16)          << 8;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.format)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:234:18
[INFO] [stderr]     |
[INFO] [stderr] 234 |         value |= (self.display_latch_0 as u16) << 6;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.display_latch_0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:235:18
[INFO] [stderr]     |
[INFO] [stderr] 235 |         value |= (self.display_latch_1 as u16) << 4;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.display_latch_1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/exi/device_ipl.rs:148:28
[INFO] [stderr]     |
[INFO] [stderr] 148 |             self.offset += len as u32;
[INFO] [stderr]     |                            ^^^^^^^^^^ help: try: `u32::from(len)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/gamecube.rs:126:18
[INFO] [stderr]     |
[INFO] [stderr] 126 |         acc = (2*acc as u16 + x as u16) as u8;
[INFO] [stderr]     |                  ^^^^^^^^^^ help: try: `u16::from(acc)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/gamecube.rs:126:31
[INFO] [stderr]     |
[INFO] [stderr] 126 |         acc = (2*acc as u16 + x as u16) as u8;
[INFO] [stderr]     |                               ^^^^^^^^ help: try: `u16::from(x)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/gp_fifo.rs:37:72
[INFO] [stderr]    |
[INFO] [stderr] 37 |                 ram.write_dma(pi.fifo_write_pointer, &self.gather_pipe[processed..processed + GATHER_PIPE_BURST + 1]);
[INFO] [stderr]    |                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `processed..=processed + GATHER_PIPE_BURST`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `buf`
[INFO] [stderr]   --> src/memory.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for i in 0..buf.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for (i, <item>) in buf.iter_mut().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `buf`
[INFO] [stderr]   --> src/memory.rs:59:18
[INFO] [stderr]    |
[INFO] [stderr] 59 |         for i in 0..buf.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 59 |         for (i, <item>) in buf.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:144:30
[INFO] [stderr]     |
[INFO] [stderr] 144 |                     let y1 = ram.read_u8(i) as i32;
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ram.read_u8(i))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:145:30
[INFO] [stderr]     |
[INFO] [stderr] 145 |                     let v  = ram.read_u8(i + 1) as i32;
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ram.read_u8(i + 1))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:146:30
[INFO] [stderr]     |
[INFO] [stderr] 146 |                     let y2 = ram.read_u8(i + 2) as i32;
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ram.read_u8(i + 2))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:147:30
[INFO] [stderr]     |
[INFO] [stderr] 147 |                     let u  = ram.read_u8(i + 3) as i32;
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ram.read_u8(i + 3))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/video_interface.rs:156:17
[INFO] [stderr]     |
[INFO] [stderr] 156 |                 self.window.update_with_buffer(&self.buffer);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:233:18
[INFO] [stderr]     |
[INFO] [stderr] 233 |         value |= (self.format as u16)          << 8;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.format)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:234:18
[INFO] [stderr]     |
[INFO] [stderr] 234 |         value |= (self.display_latch_0 as u16) << 6;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.display_latch_0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/video_interface.rs:235:18
[INFO] [stderr]     |
[INFO] [stderr] 235 |         value |= (self.display_latch_1 as u16) << 4;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.display_latch_1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 17.82s
[INFO] running `"docker" "inspect" "236225cd3502aeba6c4606c8ac8ef8a8469b8eae90a212f3e7c2f8684f40f8ba"`
[INFO] running `"docker" "rm" "-f" "236225cd3502aeba6c4606c8ac8ef8a8469b8eae90a212f3e7c2f8684f40f8ba"`
[INFO] [stdout] 236225cd3502aeba6c4606c8ac8ef8a8469b8eae90a212f3e7c2f8684f40f8ba