[INFO] updating cached repository msevilgenius/rusty-euler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/msevilgenius/rusty-euler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/msevilgenius/rusty-euler" "work/ex/clippy-test-run/sources/stable/gh/msevilgenius/rusty-euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/msevilgenius/rusty-euler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/msevilgenius/rusty-euler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msevilgenius/rusty-euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msevilgenius/rusty-euler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8ef8da5845b6c162420580cfee9eec54a04c0442 [INFO] sha for GitHub repo msevilgenius/rusty-euler: 8ef8da5845b6c162420580cfee9eec54a04c0442 [INFO] validating manifest of msevilgenius/rusty-euler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of msevilgenius/rusty-euler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing msevilgenius/rusty-euler [INFO] finished frobbing msevilgenius/rusty-euler [INFO] frobbed toml for msevilgenius/rusty-euler written to work/ex/clippy-test-run/sources/stable/gh/msevilgenius/rusty-euler/Cargo.toml [INFO] started frobbing msevilgenius/rusty-euler [INFO] finished frobbing msevilgenius/rusty-euler [INFO] frobbed toml for msevilgenius/rusty-euler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msevilgenius/rusty-euler/Cargo.toml [INFO] crate msevilgenius/rusty-euler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting msevilgenius/rusty-euler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/msevilgenius/rusty-euler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 00ea7d91c0ec096a3a811736e6c4d30a1644aa0b33314833e6d3eba0af2eef0e [INFO] running `"docker" "start" "-a" "00ea7d91c0ec096a3a811736e6c4d30a1644aa0b33314833e6d3eba0af2eef0e"` [INFO] [stderr] Checking euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/problem2.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | max: max [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/problem2.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | max: max [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problems/problem2.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | sum_even_fibonacci(4000000) [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problems/problem3.rs:2:33 [INFO] [stderr] | [INFO] [stderr] 2 | largest_prime_factor_faster(600851475143) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problems/problem2.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | sum_even_fibonacci(4000000) [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problems/problem3.rs:2:33 [INFO] [stderr] | [INFO] [stderr] 2 | largest_prime_factor_faster(600851475143) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: function is never used: `largest_prime_factor` [INFO] [stderr] --> src/problems/problem3.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | fn largest_prime_factor(num: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/problems/problem3.rs:7:41 [INFO] [stderr] | [INFO] [stderr] 7 | let is_prime = |x : &i64| -> bool { (2..x/2+1).filter(|y| x % y == 0).next() == None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|y| x % y == 0).next()` with `find(|y| x % y == 0)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problems/problem3.rs:7:41 [INFO] [stderr] | [INFO] [stderr] 7 | let is_prime = |x : &i64| -> bool { (2..x/2+1).filter(|y| x % y == 0).next() == None }; [INFO] [stderr] | ^^^^^^^^^^ help: use: `(2..=x/2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/problems/problem3.rs:14:40 [INFO] [stderr] | [INFO] [stderr] 14 | let is_prime = |x : i64| -> bool { (2..x/2+1).filter(|y| x % y == 0).next() == None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|y| x % y == 0).next()` with `find(|y| x % y == 0)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problems/problem3.rs:14:40 [INFO] [stderr] | [INFO] [stderr] 14 | let is_prime = |x : i64| -> bool { (2..x/2+1).filter(|y| x % y == 0).next() == None }; [INFO] [stderr] | ^^^^^^^^^^ help: use: `(2..=x/2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/problems/problem3.rs:7:41 [INFO] [stderr] | [INFO] [stderr] 7 | let is_prime = |x : &i64| -> bool { (2..x/2+1).filter(|y| x % y == 0).next() == None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|y| x % y == 0).next()` with `find(|y| x % y == 0)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problems/problem3.rs:7:41 [INFO] [stderr] | [INFO] [stderr] 7 | let is_prime = |x : &i64| -> bool { (2..x/2+1).filter(|y| x % y == 0).next() == None }; [INFO] [stderr] | ^^^^^^^^^^ help: use: `(2..=x/2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/problems/problem3.rs:14:40 [INFO] [stderr] | [INFO] [stderr] 14 | let is_prime = |x : i64| -> bool { (2..x/2+1).filter(|y| x % y == 0).next() == None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|y| x % y == 0).next()` with `find(|y| x % y == 0)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problems/problem3.rs:14:40 [INFO] [stderr] | [INFO] [stderr] 14 | let is_prime = |x : i64| -> bool { (2..x/2+1).filter(|y| x % y == 0).next() == None }; [INFO] [stderr] | ^^^^^^^^^^ help: use: `(2..=x/2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s [INFO] running `"docker" "inspect" "00ea7d91c0ec096a3a811736e6c4d30a1644aa0b33314833e6d3eba0af2eef0e"` [INFO] running `"docker" "rm" "-f" "00ea7d91c0ec096a3a811736e6c4d30a1644aa0b33314833e6d3eba0af2eef0e"` [INFO] [stdout] 00ea7d91c0ec096a3a811736e6c4d30a1644aa0b33314833e6d3eba0af2eef0e