[INFO] updating cached repository msekletar/net-ifnames-prefix [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/msekletar/net-ifnames-prefix [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/msekletar/net-ifnames-prefix" "work/ex/clippy-test-run/sources/stable/gh/msekletar/net-ifnames-prefix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/msekletar/net-ifnames-prefix'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/msekletar/net-ifnames-prefix" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msekletar/net-ifnames-prefix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msekletar/net-ifnames-prefix'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 57f075d9df0cd4ea1b39003044e6e36c7f6dfbfe [INFO] sha for GitHub repo msekletar/net-ifnames-prefix: 57f075d9df0cd4ea1b39003044e6e36c7f6dfbfe [INFO] validating manifest of msekletar/net-ifnames-prefix on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of msekletar/net-ifnames-prefix on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing msekletar/net-ifnames-prefix [INFO] finished frobbing msekletar/net-ifnames-prefix [INFO] frobbed toml for msekletar/net-ifnames-prefix written to work/ex/clippy-test-run/sources/stable/gh/msekletar/net-ifnames-prefix/Cargo.toml [INFO] started frobbing msekletar/net-ifnames-prefix [INFO] finished frobbing msekletar/net-ifnames-prefix [INFO] frobbed toml for msekletar/net-ifnames-prefix written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msekletar/net-ifnames-prefix/Cargo.toml [INFO] crate msekletar/net-ifnames-prefix has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting msekletar/net-ifnames-prefix against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/msekletar/net-ifnames-prefix:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 46d44d60cbfad71929a1a8c44e87f92ccd802fbca6ca912e2ae8a507dab7b3fb [INFO] running `"docker" "start" "-a" "46d44d60cbfad71929a1a8c44e87f92ccd802fbca6ca912e2ae8a507dab7b3fb"` [INFO] [stderr] Compiling matches v0.1.6 [INFO] [stderr] Compiling foreign-types-shared v0.1.1 [INFO] [stderr] Compiling httparse v1.2.4 [INFO] [stderr] Compiling antidote v1.0.0 [INFO] [stderr] Compiling adler32 v1.0.2 [INFO] [stderr] Compiling openssl-sys v0.9.32 [INFO] [stderr] Compiling log v0.4.3 [INFO] [stderr] Compiling time v0.1.40 [INFO] [stderr] Compiling base64 v0.6.0 [INFO] [stderr] Compiling phf_shared v0.7.22 [INFO] [stderr] Compiling foreign-types v0.3.2 [INFO] [stderr] Compiling unicode-bidi v0.3.4 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking phf v0.7.22 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Compiling serde_json v1.0.19 [INFO] [stderr] Checking regex v1.0.1 [INFO] [stderr] Compiling mime v0.2.6 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Compiling libflate v0.1.14 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Compiling idna v0.1.4 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Compiling native-tls v0.1.5 [INFO] [stderr] Compiling url v1.7.0 [INFO] [stderr] Compiling hyper v0.10.13 [INFO] [stderr] Compiling serde_urlencoded v0.5.2 [INFO] [stderr] Compiling hyper-native-tls v0.2.4 [INFO] [stderr] Compiling reqwest v0.6.2 [INFO] [stderr] Compiling hwaddr v0.1.4 [INFO] [stderr] Checking net-ifnames-prefix v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:36:64 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new_with_hwaddr(link_name: &T, hwaddr: &HwAddr) -> Result> { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `HwAddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/config.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn new_with_prefix(prefix: &String) -> Self { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 97 | pub fn new_with_prefix(prefix: &str) -> Self { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `prefix.clone()` to [INFO] [stderr] | [INFO] [stderr] 101| ifname_prefix: prefix.to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:117:35 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn for_hwaddr(&self, mac: &HwAddr) -> Option { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `HwAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/config.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | links = links.iter() [INFO] [stderr] | _________________^ [INFO] [stderr] 155 | | .filter_map(|l| if l.name.starts_with(&self.ifname_prefix) { Some(l) } else { None }) [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:36:64 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new_with_hwaddr(link_name: &T, hwaddr: &HwAddr) -> Result> { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `HwAddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/config.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn new_with_prefix(prefix: &String) -> Self { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 97 | pub fn new_with_prefix(prefix: &str) -> Self { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `prefix.clone()` to [INFO] [stderr] | [INFO] [stderr] 101| ifname_prefix: prefix.to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:117:35 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn for_hwaddr(&self, mac: &HwAddr) -> Option { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `HwAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/config.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | links = links.iter() [INFO] [stderr] | _________________^ [INFO] [stderr] 155 | | .filter_map(|l| if l.name.starts_with(&self.ifname_prefix) { Some(l) } else { None }) [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 40.68s [INFO] running `"docker" "inspect" "46d44d60cbfad71929a1a8c44e87f92ccd802fbca6ca912e2ae8a507dab7b3fb"` [INFO] running `"docker" "rm" "-f" "46d44d60cbfad71929a1a8c44e87f92ccd802fbca6ca912e2ae8a507dab7b3fb"` [INFO] [stdout] 46d44d60cbfad71929a1a8c44e87f92ccd802fbca6ca912e2ae8a507dab7b3fb