[INFO] updating cached repository msehnout/lunch-bot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/msehnout/lunch-bot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/msehnout/lunch-bot" "work/ex/clippy-test-run/sources/stable/gh/msehnout/lunch-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/msehnout/lunch-bot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/msehnout/lunch-bot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msehnout/lunch-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msehnout/lunch-bot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 834b2c8691175a61d0c29d98518d5c7ecb3499cf [INFO] sha for GitHub repo msehnout/lunch-bot: 834b2c8691175a61d0c29d98518d5c7ecb3499cf [INFO] validating manifest of msehnout/lunch-bot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of msehnout/lunch-bot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing msehnout/lunch-bot [INFO] finished frobbing msehnout/lunch-bot [INFO] frobbed toml for msehnout/lunch-bot written to work/ex/clippy-test-run/sources/stable/gh/msehnout/lunch-bot/Cargo.toml [INFO] started frobbing msehnout/lunch-bot [INFO] finished frobbing msehnout/lunch-bot [INFO] frobbed toml for msehnout/lunch-bot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msehnout/lunch-bot/Cargo.toml [INFO] crate msehnout/lunch-bot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting msehnout/lunch-bot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/msehnout/lunch-bot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1f9b0911f24aeae53d66addd9448a4ef43db250fe1d6d40ed7178d1fa04b58f0 [INFO] running `"docker" "start" "-a" "1f9b0911f24aeae53d66addd9448a4ef43db250fe1d6d40ed7178d1fa04b58f0"` [INFO] [stderr] Checking tokio-mockstream v1.1.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking irc v0.13.5 [INFO] [stderr] Checking lunch-bot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/syntax.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | const PROPOSE_SYNTAX: &'static str = concat!( [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/syntax.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | const PROPOSE_SYNTAX: &'static str = concat!( [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/syntax.rs:21:56 [INFO] [stderr] | [INFO] [stderr] 21 | static ref DUMPSTATE_CMD_REGEX: Regex = Regex::new(r"lb dumpstate").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/syntax.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | if let Some(_) = caps.get(1) { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 57 | | let name = caps.get(2)?.as_str(); [INFO] [stderr] 58 | | let users = caps.get(3)?.as_str(); [INFO] [stderr] 59 | | let users: Vec<&str> = users.split(',').collect(); [INFO] [stderr] ... | [INFO] [stderr] 65 | | None [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____- help: try this: `if caps.get(1).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/syntax.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | } else if let Some(_) = caps.get(4) { [INFO] [stderr] | ____________- ^^^^^^^ [INFO] [stderr] 62 | | let name = caps.get(5)?.as_str(); [INFO] [stderr] 63 | | Some(LunchCommand::GroupRemove(name)) [INFO] [stderr] 64 | | } else { [INFO] [stderr] 65 | | None [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____- help: try this: `if caps.get(4).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/syntax.rs:21:56 [INFO] [stderr] | [INFO] [stderr] 21 | static ref DUMPSTATE_CMD_REGEX: Regex = Regex::new(r"lb dumpstate").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/syntax.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | if let Some(_) = caps.get(1) { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 57 | | let name = caps.get(2)?.as_str(); [INFO] [stderr] 58 | | let users = caps.get(3)?.as_str(); [INFO] [stderr] 59 | | let users: Vec<&str> = users.split(',').collect(); [INFO] [stderr] ... | [INFO] [stderr] 65 | | None [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____- help: try this: `if caps.get(1).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/syntax.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | } else if let Some(_) = caps.get(4) { [INFO] [stderr] | ____________- ^^^^^^^ [INFO] [stderr] 62 | | let name = caps.get(5)?.as_str(); [INFO] [stderr] 63 | | Some(LunchCommand::GroupRemove(name)) [INFO] [stderr] 64 | | } else { [INFO] [stderr] 65 | | None [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____- help: try this: `if caps.get(4).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/state.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | / if self.groups.len() < length { [INFO] [stderr] 138 | | true [INFO] [stderr] 139 | | } else { [INFO] [stderr] 140 | | false [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `self.groups.len() < length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/state.rs:253:42 [INFO] [stderr] | [INFO] [stderr] 253 | serde_json::to_string(state).unwrap_or("failed to dump state".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "failed to dump state".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/state.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | format!("Success") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Success".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/state.rs:261:17 [INFO] [stderr] | [INFO] [stderr] 261 | format!("Fail") [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Fail".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/state.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | / if self.groups.len() < length { [INFO] [stderr] 138 | | true [INFO] [stderr] 139 | | } else { [INFO] [stderr] 140 | | false [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `self.groups.len() < length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / match message.command { [INFO] [stderr] 116 | | Command::PRIVMSG(ref target, ref line) => { [INFO] [stderr] 117 | | if line.starts_with("lb ") { [INFO] [stderr] 118 | | // Update state and store the response [INFO] [stderr] ... | [INFO] [stderr] 132 | | _ => (), [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | if let Command::PRIVMSG(ref target, ref line) = message.command { [INFO] [stderr] 116 | if line.starts_with("lb ") { [INFO] [stderr] 117 | // Update state and store the response [INFO] [stderr] 118 | let response = update_state(line, state.clone(), &irc_client); [INFO] [stderr] 119 | if let Some(t) = message.response_target() { [INFO] [stderr] 120 | if let Err(e) = irc_client.send_privmsg(t, &response) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/state.rs:253:42 [INFO] [stderr] | [INFO] [stderr] 253 | serde_json::to_string(state).unwrap_or("failed to dump state".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "failed to dump state".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/state.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | format!("Success") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Success".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/state.rs:261:17 [INFO] [stderr] | [INFO] [stderr] 261 | format!("Fail") [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Fail".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / match message.command { [INFO] [stderr] 116 | | Command::PRIVMSG(ref target, ref line) => { [INFO] [stderr] 117 | | if line.starts_with("lb ") { [INFO] [stderr] 118 | | // Update state and store the response [INFO] [stderr] ... | [INFO] [stderr] 132 | | _ => (), [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | if let Command::PRIVMSG(ref target, ref line) = message.command { [INFO] [stderr] 116 | if line.starts_with("lb ") { [INFO] [stderr] 117 | // Update state and store the response [INFO] [stderr] 118 | let response = update_state(line, state.clone(), &irc_client); [INFO] [stderr] 119 | if let Some(t) = message.response_target() { [INFO] [stderr] 120 | if let Err(e) = irc_client.send_privmsg(t, &response) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.31s [INFO] running `"docker" "inspect" "1f9b0911f24aeae53d66addd9448a4ef43db250fe1d6d40ed7178d1fa04b58f0"` [INFO] running `"docker" "rm" "-f" "1f9b0911f24aeae53d66addd9448a4ef43db250fe1d6d40ed7178d1fa04b58f0"` [INFO] [stdout] 1f9b0911f24aeae53d66addd9448a4ef43db250fe1d6d40ed7178d1fa04b58f0