[INFO] updating cached repository mschoenm/euler
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mschoenm/euler
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mschoenm/euler" "work/ex/clippy-test-run/sources/stable/gh/mschoenm/euler"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mschoenm/euler'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mschoenm/euler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mschoenm/euler"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mschoenm/euler'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 227c14924488460247662f8d2cbecf42706e4cbf
[INFO] sha for GitHub repo mschoenm/euler: 227c14924488460247662f8d2cbecf42706e4cbf
[INFO] validating manifest of mschoenm/euler on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mschoenm/euler on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mschoenm/euler
[INFO] finished frobbing mschoenm/euler
[INFO] frobbed toml for mschoenm/euler written to work/ex/clippy-test-run/sources/stable/gh/mschoenm/euler/Cargo.toml
[INFO] started frobbing mschoenm/euler
[INFO] finished frobbing mschoenm/euler
[INFO] frobbed toml for mschoenm/euler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mschoenm/euler/Cargo.toml
[INFO] crate mschoenm/euler has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mschoenm/euler against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mschoenm/euler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3a9061735ec2a48d00505d7d583c0bb696c3ead083e99f90a0dd276f685dc760
[INFO] running `"docker" "start" "-a" "3a9061735ec2a48d00505d7d583c0bb696c3ead083e99f90a0dd276f685dc760"`
[INFO] [stderr]    Compiling num-integer v0.1.38
[INFO] [stderr]     Checking num-complex v0.1.43
[INFO] [stderr]     Checking num-bigint v0.1.44
[INFO] [stderr]     Checking num-iter v0.1.37
[INFO] [stderr]     Checking num-rational v0.1.42
[INFO] [stderr]     Checking num v0.1.42
[INFO] [stderr]     Checking euler v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/utils/mod.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | mod utils;
[INFO] [stderr]   | ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils/utils.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 |     return true
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils/utils.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return a
[INFO] [stderr]    |     ^^^^^^^^ help: remove `return` as shown: `a`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/problems/problem002.rs:8:16
[INFO] [stderr]   |
[INFO] [stderr] 8 |     let max = &4000000.to_bigint();
[INFO] [stderr]   |                ^^^^^^^ help: consider: `4_000_000`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]  --> src/problems/problem003.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     last
[INFO] [stderr]   |     ^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]  --> src/problems/problem003.rs:6:16
[INFO] [stderr]   |
[INFO] [stderr] 6 |     let last = prime_factors(&number).last().unwrap();
[INFO] [stderr]   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/problems/problem004.rs:9:13
[INFO] [stderr]    |
[INFO] [stderr] 9  | /             if product > largest {
[INFO] [stderr] 10 | |                 if is_palindrome(product) {
[INFO] [stderr] 11 | |                     largest = product;
[INFO] [stderr] 12 | |                     break;
[INFO] [stderr] 13 | |                 }
[INFO] [stderr] 14 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 9  |             if product > largest && is_palindrome(product) {
[INFO] [stderr] 10 |     largest = product;
[INFO] [stderr] 11 |     break;
[INFO] [stderr] 12 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/utils/mod.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | mod utils;
[INFO] [stderr]   | ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils/utils.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 |     return true
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils/utils.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return a
[INFO] [stderr]    |     ^^^^^^^^ help: remove `return` as shown: `a`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/problems/problem001.rs:21:24
[INFO] [stderr]    |
[INFO] [stderr] 21 |         let expected = 233168;
[INFO] [stderr]    |                        ^^^^^^ help: consider: `233_168`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/problems/problem002.rs:8:16
[INFO] [stderr]   |
[INFO] [stderr] 8 |     let max = &4000000.to_bigint();
[INFO] [stderr]   |                ^^^^^^^ help: consider: `4_000_000`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]  --> src/problems/problem003.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     last
[INFO] [stderr]   |     ^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]  --> src/problems/problem003.rs:6:16
[INFO] [stderr]   |
[INFO] [stderr] 6 |     let last = prime_factors(&number).last().unwrap();
[INFO] [stderr]   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/problems/problem004.rs:9:13
[INFO] [stderr]    |
[INFO] [stderr] 9  | /             if product > largest {
[INFO] [stderr] 10 | |                 if is_palindrome(product) {
[INFO] [stderr] 11 | |                     largest = product;
[INFO] [stderr] 12 | |                     break;
[INFO] [stderr] 13 | |                 }
[INFO] [stderr] 14 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 9  |             if product > largest && is_palindrome(product) {
[INFO] [stderr] 10 |     largest = product;
[INFO] [stderr] 11 |     break;
[INFO] [stderr] 12 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/problems/problem004.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 |         let expected = 906609;
[INFO] [stderr]    |                        ^^^^^^ help: consider: `906_609`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `utils::prime_iterator::PrimeIterator<T>`
[INFO] [stderr]   --> src/utils/prime_iterator.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     pub fn new() -> PrimeIterator<T> {
[INFO] [stderr] 23 | |         PrimeIterator {
[INFO] [stderr] 24 | |             primes:Vec::new(), 
[INFO] [stderr] 25 | |          }
[INFO] [stderr] 26 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `utils::prime_iterator::PrimeIterator<T>`
[INFO] [stderr]   --> src/utils/prime_iterator.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     pub fn new() -> PrimeIterator<T> {
[INFO] [stderr] 23 | |         PrimeIterator {
[INFO] [stderr] 24 | |             primes:Vec::new(), 
[INFO] [stderr] 25 | |          }
[INFO] [stderr] 26 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `utils::fibonacci_iterator::FibonacciIterator<T>`
[INFO] [stderr]   --> src/utils/fibonacci_iterator.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 | /     pub fn new() -> FibonacciIterator<T> {
[INFO] [stderr] 27 | |         FibonacciIterator { a : T::one(), b : T::one() }
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 22 | impl Default for utils::fibonacci_iterator::FibonacciIterator<T> {
[INFO] [stderr] 23 |     fn default() -> Self {
[INFO] [stderr] 24 |         Self::new()
[INFO] [stderr] 25 |     }
[INFO] [stderr] 26 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `utils::fibonacci_iterator::FibonacciIterator<T>`
[INFO] [stderr]   --> src/utils/fibonacci_iterator.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 | /     pub fn new() -> FibonacciIterator<T> {
[INFO] [stderr] 27 | |         FibonacciIterator { a : T::one(), b : T::one() }
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 22 | impl Default for utils::fibonacci_iterator::FibonacciIterator<T> {
[INFO] [stderr] 23 |     fn default() -> Self {
[INFO] [stderr] 24 |         Self::new()
[INFO] [stderr] 25 |     }
[INFO] [stderr] 26 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/problems/problem002.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 |     for ref i in fibonacci_numbers::<BigInt>() {
[INFO] [stderr]    |         ^^^^^    ----------------------------- help: try: `let i = &fibonacci_numbers::<BigInt>();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/problems/problem002.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 |     for ref i in fibonacci_numbers::<BigInt>() {
[INFO] [stderr]    |         ^^^^^    ----------------------------- help: try: `let i = &fibonacci_numbers::<BigInt>();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.64s
[INFO] running `"docker" "inspect" "3a9061735ec2a48d00505d7d583c0bb696c3ead083e99f90a0dd276f685dc760"`
[INFO] running `"docker" "rm" "-f" "3a9061735ec2a48d00505d7d583c0bb696c3ead083e99f90a0dd276f685dc760"`
[INFO] [stdout] 3a9061735ec2a48d00505d7d583c0bb696c3ead083e99f90a0dd276f685dc760