[INFO] updating cached repository msathis/adventofcode [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/msathis/adventofcode [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/msathis/adventofcode" "work/ex/clippy-test-run/sources/stable/gh/msathis/adventofcode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/msathis/adventofcode'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/msathis/adventofcode" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msathis/adventofcode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msathis/adventofcode'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9b8a2e4a40738555a0bc08247718291bc1c0485a [INFO] sha for GitHub repo msathis/adventofcode: 9b8a2e4a40738555a0bc08247718291bc1c0485a [INFO] validating manifest of msathis/adventofcode on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of msathis/adventofcode on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing msathis/adventofcode [INFO] finished frobbing msathis/adventofcode [INFO] frobbed toml for msathis/adventofcode written to work/ex/clippy-test-run/sources/stable/gh/msathis/adventofcode/Cargo.toml [INFO] started frobbing msathis/adventofcode [INFO] finished frobbing msathis/adventofcode [INFO] frobbed toml for msathis/adventofcode written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msathis/adventofcode/Cargo.toml [INFO] crate msathis/adventofcode has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting msathis/adventofcode against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/msathis/adventofcode:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 031547500b7c5b643103da95b402081f2c9001e16a43fccdacfd45638d7408ec [INFO] running `"docker" "start" "-a" "031547500b7c5b643103da95b402081f2c9001e16a43fccdacfd45638d7408ec"` [INFO] [stderr] Checking adventofcode v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Stdin` [INFO] [stderr] --> src/day1.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{Stdin, Read, stdin}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/day1.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `Stdin` [INFO] [stderr] --> src/day2.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{Stdin, Read, stdin}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Stdin` [INFO] [stderr] --> src/day3.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{Stdin, Read, stdin}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `core::str::Chars` [INFO] [stderr] --> src/day3.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use core::str::Chars; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Stdin` [INFO] [stderr] --> src/day1.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{Stdin, Read, stdin}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/day1.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `Stdin` [INFO] [stderr] --> src/day2.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{Stdin, Read, stdin}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Stdin` [INFO] [stderr] --> src/day3.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{Stdin, Read, stdin}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `core::str::Chars` [INFO] [stderr] --> src/day3.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use core::str::Chars; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `has_twos` [INFO] [stderr] --> src/day2.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | let mut has_twos = false; [INFO] [stderr] | ^^^^^^^^ help: consider using `_has_twos` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `has_threes` [INFO] [stderr] --> src/day2.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | let mut has_threes = false; [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_has_threes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/day3.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | let (hashmap, claims) = get_map(&buffer, &re); [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key` [INFO] [stderr] --> src/day3.rs:61:10 [INFO] [stderr] | [INFO] [stderr] 61 | for (key, val) in &hashmap { [INFO] [stderr] | ^^^ help: consider using `_key` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `has_twos` [INFO] [stderr] --> src/day2.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | let mut has_twos = false; [INFO] [stderr] | ^^^^^^^^ help: consider using `_has_twos` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `has_threes` [INFO] [stderr] --> src/day2.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | let mut has_threes = false; [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_has_threes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/day3.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | let (hashmap, claims) = get_map(&buffer, &re); [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key` [INFO] [stderr] --> src/day3.rs:61:10 [INFO] [stderr] | [INFO] [stderr] 61 | for (key, val) in &hashmap { [INFO] [stderr] | ^^^ help: consider using `_key` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/day2.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | let mut has_twos = false; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/day2.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | let mut has_threes = false; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/day2.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | let mut has_twos = false; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/day2.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | let mut has_threes = false; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day1.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | stdin().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day1.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | stdin().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day2.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | stdin().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/day2.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | / if visited_chars.contains_key(&c) { [INFO] [stderr] 19 | | visited_chars.insert(c, visited_chars.get(&c).unwrap() + 1); [INFO] [stderr] 20 | | } else { [INFO] [stderr] 21 | | visited_chars.insert(c, 1); [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____________^ help: consider using: `visited_chars.entry(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day2.rs:19:41 [INFO] [stderr] | [INFO] [stderr] 19 | visited_chars.insert(c, visited_chars.get(&c).unwrap() + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&visited_chars[&c]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day2.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | stdin().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day2.rs:46:34 [INFO] [stderr] | [INFO] [stderr] 46 | let f_word: &Chars = lines.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `lines[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day2.rs:47:34 [INFO] [stderr] | [INFO] [stderr] 47 | let s_word: &Chars = lines.get(j).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `lines[j]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day2.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | mismatch = mismatch + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mismatch += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day3.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn get_map(buffer: &String, re: &Regex) -> (HashMap<(u32, u32), i32>, Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day3.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | count = hashmap.get(&(i, j)).unwrap() + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hashmap[&(i, j)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day1.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | stdin().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day3.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | stdin().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day1.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | stdin().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/day3.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | if val > &1 { [INFO] [stderr] | ^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day3.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | stdin().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day2.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | stdin().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/day3.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | if hashmap.get(&(i, j)).unwrap() > &1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day3.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | if hashmap.get(&(i, j)).unwrap() > &1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hashmap[&(i, j)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/day2.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | / if visited_chars.contains_key(&c) { [INFO] [stderr] 19 | | visited_chars.insert(c, visited_chars.get(&c).unwrap() + 1); [INFO] [stderr] 20 | | } else { [INFO] [stderr] 21 | | visited_chars.insert(c, 1); [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____________^ help: consider using: `visited_chars.entry(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day2.rs:19:41 [INFO] [stderr] | [INFO] [stderr] 19 | visited_chars.insert(c, visited_chars.get(&c).unwrap() + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&visited_chars[&c]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day2.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | stdin().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day2.rs:46:34 [INFO] [stderr] | [INFO] [stderr] 46 | let f_word: &Chars = lines.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `lines[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day2.rs:47:34 [INFO] [stderr] | [INFO] [stderr] 47 | let s_word: &Chars = lines.get(j).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `lines[j]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day2.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | mismatch = mismatch + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mismatch += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day3.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn get_map(buffer: &String, re: &Regex) -> (HashMap<(u32, u32), i32>, Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day3.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | count = hashmap.get(&(i, j)).unwrap() + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hashmap[&(i, j)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day3.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | stdin().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/day3.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | if val > &1 { [INFO] [stderr] | ^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day3.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | stdin().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/day3.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | if hashmap.get(&(i, j)).unwrap() > &1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day3.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | if hashmap.get(&(i, j)).unwrap() > &1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hashmap[&(i, j)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.54s [INFO] running `"docker" "inspect" "031547500b7c5b643103da95b402081f2c9001e16a43fccdacfd45638d7408ec"` [INFO] running `"docker" "rm" "-f" "031547500b7c5b643103da95b402081f2c9001e16a43fccdacfd45638d7408ec"` [INFO] [stdout] 031547500b7c5b643103da95b402081f2c9001e16a43fccdacfd45638d7408ec