[INFO] updating cached repository mrterry/conda_lockfile_rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mrterry/conda_lockfile_rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mrterry/conda_lockfile_rs" "work/ex/clippy-test-run/sources/stable/gh/mrterry/conda_lockfile_rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mrterry/conda_lockfile_rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mrterry/conda_lockfile_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mrterry/conda_lockfile_rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mrterry/conda_lockfile_rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] fe489ce2f64f590d570bb737e563fd64653a9477
[INFO] sha for GitHub repo mrterry/conda_lockfile_rs: fe489ce2f64f590d570bb737e563fd64653a9477
[INFO] validating manifest of mrterry/conda_lockfile_rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mrterry/conda_lockfile_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mrterry/conda_lockfile_rs
[INFO] finished frobbing mrterry/conda_lockfile_rs
[INFO] frobbed toml for mrterry/conda_lockfile_rs written to work/ex/clippy-test-run/sources/stable/gh/mrterry/conda_lockfile_rs/Cargo.toml
[INFO] started frobbing mrterry/conda_lockfile_rs
[INFO] finished frobbing mrterry/conda_lockfile_rs
[INFO] frobbed toml for mrterry/conda_lockfile_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mrterry/conda_lockfile_rs/Cargo.toml
[INFO] crate mrterry/conda_lockfile_rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mrterry/conda_lockfile_rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mrterry/conda_lockfile_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] de841c27d54371af3ef50fdafc0ce25c5c1ef379e72d9301acff818dac40e347
[INFO] running `"docker" "start" "-a" "de841c27d54371af3ef50fdafc0ce25c5c1ef379e72d9301acff818dac40e347"`
[INFO] [stderr]     Checking log v0.4.6
[INFO] [stderr]     Checking tempfile v3.0.4
[INFO] [stderr]     Checking log v0.3.9
[INFO] [stderr]     Checking simplelog v0.4.4
[INFO] [stderr]     Checking conda-lockfile v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/main.rs:139:5
[INFO] [stderr]     |
[INFO] [stderr] 139 |     val
[INFO] [stderr]     |     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/main.rs:132:15
[INFO] [stderr]     |
[INFO] [stderr] 132 |       let val = match app_m.subcommand() {
[INFO] [stderr]     |  _______________^
[INFO] [stderr] 133 | |         ("freeze", Some(sub_m)) => handle_freeze(sub_m),
[INFO] [stderr] 134 | |         ("create", Some(sub_m)) => handle_create(sub_m),
[INFO] [stderr] 135 | |         ("checkenv", Some(sub_m)) => handle_checkenv(sub_m),
[INFO] [stderr] 136 | |         ("checklocks", Some(sub_m)) => handle_checklocks(sub_m),
[INFO] [stderr] 137 | |         _ => Ok(()),
[INFO] [stderr] 138 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/main.rs:139:5
[INFO] [stderr]     |
[INFO] [stderr] 139 |     val
[INFO] [stderr]     |     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/main.rs:132:15
[INFO] [stderr]     |
[INFO] [stderr] 132 |       let val = match app_m.subcommand() {
[INFO] [stderr]     |  _______________^
[INFO] [stderr] 133 | |         ("freeze", Some(sub_m)) => handle_freeze(sub_m),
[INFO] [stderr] 134 | |         ("create", Some(sub_m)) => handle_create(sub_m),
[INFO] [stderr] 135 | |         ("checkenv", Some(sub_m)) => handle_checkenv(sub_m),
[INFO] [stderr] 136 | |         ("checklocks", Some(sub_m)) => handle_checklocks(sub_m),
[INFO] [stderr] 137 | |         _ => Ok(()),
[INFO] [stderr] 138 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:64:42
[INFO] [stderr]    |
[INFO] [stderr] 64 |         .filter(|line| !line.starts_with("#"))
[INFO] [stderr]    |                                          ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:339:9
[INFO] [stderr]     |
[INFO] [stderr] 339 | /         match d.as_str() {
[INFO] [stderr] 340 | |             Some(conda_dep) => {
[INFO] [stderr] 341 | |                 conda_deps.insert(conda_dep);
[INFO] [stderr] 342 | |                 continue;
[INFO] [stderr] 343 | |             }
[INFO] [stderr] 344 | |             None => {}
[INFO] [stderr] 345 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 339 |         if let Some(conda_dep) = d.as_str() {
[INFO] [stderr] 340 |     conda_deps.insert(conda_dep);
[INFO] [stderr] 341 |     continue;
[INFO] [stderr] 342 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:346:9
[INFO] [stderr]     |
[INFO] [stderr] 346 | /         match d.as_vec() {
[INFO] [stderr] 347 | |             Some(pips) => {
[INFO] [stderr] 348 | |                 pip_deps.extend(pips.iter().filter_map(|pip| pip.as_str()));
[INFO] [stderr] 349 | |                 continue;
[INFO] [stderr] 350 | |             }
[INFO] [stderr] 351 | |             None => {}
[INFO] [stderr] 352 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 346 |         if let Some(pips) = d.as_vec() {
[INFO] [stderr] 347 |     pip_deps.extend(pips.iter().filter_map(|pip| pip.as_str()));
[INFO] [stderr] 348 |     continue;
[INFO] [stderr] 349 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:363:37
[INFO] [stderr]     |
[INFO] [stderr] 363 |         .filter_map(|dep| dep.split("=").nth(0))
[INFO] [stderr]     |                                     ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:518:34
[INFO] [stderr]     |
[INFO] [stderr] 518 |         Some(files) => files.map(|p| PathBuf::from(p)).collect(),
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:64:42
[INFO] [stderr]    |
[INFO] [stderr] 64 |         .filter(|line| !line.starts_with("#"))
[INFO] [stderr]    |                                          ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:339:9
[INFO] [stderr]     |
[INFO] [stderr] 339 | /         match d.as_str() {
[INFO] [stderr] 340 | |             Some(conda_dep) => {
[INFO] [stderr] 341 | |                 conda_deps.insert(conda_dep);
[INFO] [stderr] 342 | |                 continue;
[INFO] [stderr] 343 | |             }
[INFO] [stderr] 344 | |             None => {}
[INFO] [stderr] 345 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 339 |         if let Some(conda_dep) = d.as_str() {
[INFO] [stderr] 340 |     conda_deps.insert(conda_dep);
[INFO] [stderr] 341 |     continue;
[INFO] [stderr] 342 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:346:9
[INFO] [stderr]     |
[INFO] [stderr] 346 | /         match d.as_vec() {
[INFO] [stderr] 347 | |             Some(pips) => {
[INFO] [stderr] 348 | |                 pip_deps.extend(pips.iter().filter_map(|pip| pip.as_str()));
[INFO] [stderr] 349 | |                 continue;
[INFO] [stderr] 350 | |             }
[INFO] [stderr] 351 | |             None => {}
[INFO] [stderr] 352 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 346 |         if let Some(pips) = d.as_vec() {
[INFO] [stderr] 347 |     pip_deps.extend(pips.iter().filter_map(|pip| pip.as_str()));
[INFO] [stderr] 348 |     continue;
[INFO] [stderr] 349 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:363:37
[INFO] [stderr]     |
[INFO] [stderr] 363 |         .filter_map(|dep| dep.split("=").nth(0))
[INFO] [stderr]     |                                     ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:518:34
[INFO] [stderr]     |
[INFO] [stderr] 518 |         Some(files) => files.map(|p| PathBuf::from(p)).collect(),
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.79s
[INFO] running `"docker" "inspect" "de841c27d54371af3ef50fdafc0ce25c5c1ef379e72d9301acff818dac40e347"`
[INFO] running `"docker" "rm" "-f" "de841c27d54371af3ef50fdafc0ce25c5c1ef379e72d9301acff818dac40e347"`
[INFO] [stdout] de841c27d54371af3ef50fdafc0ce25c5c1ef379e72d9301acff818dac40e347