[INFO] updating cached repository mrobakowski/rust-metaballs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mrobakowski/rust-metaballs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mrobakowski/rust-metaballs" "work/ex/clippy-test-run/sources/stable/gh/mrobakowski/rust-metaballs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mrobakowski/rust-metaballs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mrobakowski/rust-metaballs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mrobakowski/rust-metaballs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mrobakowski/rust-metaballs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8a4fb6c36f2f58591c90c5b4e152156bbea55bde [INFO] sha for GitHub repo mrobakowski/rust-metaballs: 8a4fb6c36f2f58591c90c5b4e152156bbea55bde [INFO] validating manifest of mrobakowski/rust-metaballs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mrobakowski/rust-metaballs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mrobakowski/rust-metaballs [INFO] finished frobbing mrobakowski/rust-metaballs [INFO] frobbed toml for mrobakowski/rust-metaballs written to work/ex/clippy-test-run/sources/stable/gh/mrobakowski/rust-metaballs/Cargo.toml [INFO] started frobbing mrobakowski/rust-metaballs [INFO] finished frobbing mrobakowski/rust-metaballs [INFO] frobbed toml for mrobakowski/rust-metaballs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mrobakowski/rust-metaballs/Cargo.toml [INFO] crate mrobakowski/rust-metaballs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mrobakowski/rust-metaballs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mrobakowski/rust-metaballs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0789c0b56a8cacefd27f2c795e9469810beb278ff4e024bd427cfbbcb4fccb81 [INFO] running `"docker" "start" "-a" "0789c0b56a8cacefd27f2c795e9469810beb278ff4e024bd427cfbbcb4fccb81"` [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking rand v0.5.4 [INFO] [stderr] Compiling wayland-scanner v0.20.10 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking quaternion v0.3.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking x11-dl v2.18.0 [INFO] [stderr] Checking approx v0.2.1 [INFO] [stderr] Checking num-complex v0.2.0 [INFO] [stderr] Checking piston3d-cam v0.3.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Compiling wayland-client v0.20.10 [INFO] [stderr] Compiling wayland-protocols v0.20.10 [INFO] [stderr] Checking wayland-sys v0.20.10 [INFO] [stderr] Checking alga v0.6.0 [INFO] [stderr] Checking wayland-commons v0.20.10 [INFO] [stderr] Compiling glutin v0.17.0 [INFO] [stderr] Compiling glium v0.22.0 [INFO] [stderr] Checking nalgebra v0.15.3 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking rust-metaballs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/linspace/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | let _00 = match face { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/main.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | let _01 = match face { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/main.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | let _10 = match face { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/main.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | let _11 = match face { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/linspace/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | let _00 = match face { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/main.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | let _01 = match face { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/main.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | let _10 = match face { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/main.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | let _11 = match face { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: unary minus has lower precedence than method call [INFO] [stderr] --> src/main.rs:432:69 [INFO] [stderr] | [INFO] [stderr] 432 | pitch = pitch.min(90.0f32.to_radians()).max(-90.0f32.to_radians()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider adding parentheses to clarify your intent: `-(90.0f32.to_radians())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unary minus has lower precedence than method call [INFO] [stderr] --> src/main.rs:432:69 [INFO] [stderr] | [INFO] [stderr] 432 | pitch = pitch.min(90.0f32.to_radians()).max(-90.0f32.to_radians()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider adding parentheses to clarify your intent: `-(90.0f32.to_radians())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/linspace/mod.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | start: self.start.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/linspace/mod.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | step: self.step.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/linspace/mod.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | index: self.index.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/linspace/mod.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | len: self.len.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `metaballs`. [INFO] [stderr] --> src/main.rs:179:14 [INFO] [stderr] | [INFO] [stderr] 179 | for i in 0..MAX_METABALLS_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 179 | for in metaballs.iter_mut().take(MAX_METABALLS_SIZE) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | / match ev { [INFO] [stderr] 366 | | Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 367 | | WindowEvent::CloseRequested | WindowEvent::Destroyed => running = false, [INFO] [stderr] 368 | | WindowEvent::Resized(LogicalSize { width, height }) => [INFO] [stderr] ... | [INFO] [stderr] 444 | | _ => (), [INFO] [stderr] 445 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 365 | if let Event::WindowEvent { event, .. } = ev { match event { [INFO] [stderr] 366 | WindowEvent::CloseRequested | WindowEvent::Destroyed => running = false, [INFO] [stderr] 367 | WindowEvent::Resized(LogicalSize { width, height }) => [INFO] [stderr] 368 | camera_perspective.aspect_ratio = width as f32 / height as f32, [INFO] [stderr] 369 | kbd!(pressed LControl) => ctrl_down = true, [INFO] [stderr] 370 | kbd!(released LControl) => ctrl_down = false, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:431:25 [INFO] [stderr] | [INFO] [stderr] 431 | pitch = pitch - (y - mouse_y) as f32 / 1000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pitch -= (y - mouse_y) as f32 / 1000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:433:25 [INFO] [stderr] | [INFO] [stderr] 433 | yaw = yaw + (x - mouse_x) as f32 / 1000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `yaw += (x - mouse_x) as f32 / 1000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/linspace/mod.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | start: self.start.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/linspace/mod.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | step: self.step.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/linspace/mod.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | index: self.index.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/linspace/mod.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | len: self.len.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `metaballs`. [INFO] [stderr] --> src/main.rs:179:14 [INFO] [stderr] | [INFO] [stderr] 179 | for i in 0..MAX_METABALLS_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 179 | for in metaballs.iter_mut().take(MAX_METABALLS_SIZE) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | / match ev { [INFO] [stderr] 366 | | Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 367 | | WindowEvent::CloseRequested | WindowEvent::Destroyed => running = false, [INFO] [stderr] 368 | | WindowEvent::Resized(LogicalSize { width, height }) => [INFO] [stderr] ... | [INFO] [stderr] 444 | | _ => (), [INFO] [stderr] 445 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 365 | if let Event::WindowEvent { event, .. } = ev { match event { [INFO] [stderr] 366 | WindowEvent::CloseRequested | WindowEvent::Destroyed => running = false, [INFO] [stderr] 367 | WindowEvent::Resized(LogicalSize { width, height }) => [INFO] [stderr] 368 | camera_perspective.aspect_ratio = width as f32 / height as f32, [INFO] [stderr] 369 | kbd!(pressed LControl) => ctrl_down = true, [INFO] [stderr] 370 | kbd!(released LControl) => ctrl_down = false, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:431:25 [INFO] [stderr] | [INFO] [stderr] 431 | pitch = pitch - (y - mouse_y) as f32 / 1000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pitch -= (y - mouse_y) as f32 / 1000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:433:25 [INFO] [stderr] | [INFO] [stderr] 433 | yaw = yaw + (x - mouse_x) as f32 / 1000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `yaw += (x - mouse_x) as f32 / 1000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 24s [INFO] running `"docker" "inspect" "0789c0b56a8cacefd27f2c795e9469810beb278ff4e024bd427cfbbcb4fccb81"` [INFO] running `"docker" "rm" "-f" "0789c0b56a8cacefd27f2c795e9469810beb278ff4e024bd427cfbbcb4fccb81"` [INFO] [stdout] 0789c0b56a8cacefd27f2c795e9469810beb278ff4e024bd427cfbbcb4fccb81