[INFO] updating cached repository mrbkap/cpow-log-parser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mrbkap/cpow-log-parser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mrbkap/cpow-log-parser" "work/ex/clippy-test-run/sources/stable/gh/mrbkap/cpow-log-parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mrbkap/cpow-log-parser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mrbkap/cpow-log-parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mrbkap/cpow-log-parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mrbkap/cpow-log-parser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 255b1548f47f1f31fa5f521d152cbc41938365dd [INFO] sha for GitHub repo mrbkap/cpow-log-parser: 255b1548f47f1f31fa5f521d152cbc41938365dd [INFO] validating manifest of mrbkap/cpow-log-parser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mrbkap/cpow-log-parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mrbkap/cpow-log-parser [INFO] finished frobbing mrbkap/cpow-log-parser [INFO] frobbed toml for mrbkap/cpow-log-parser written to work/ex/clippy-test-run/sources/stable/gh/mrbkap/cpow-log-parser/Cargo.toml [INFO] started frobbing mrbkap/cpow-log-parser [INFO] finished frobbing mrbkap/cpow-log-parser [INFO] frobbed toml for mrbkap/cpow-log-parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mrbkap/cpow-log-parser/Cargo.toml [INFO] crate mrbkap/cpow-log-parser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mrbkap/cpow-log-parser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mrbkap/cpow-log-parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a416b22fb6d2d5e3939dcbf68378c98d1b2af8295198a9b51bfb6edfb9569ffc [INFO] running `"docker" "start" "-a" "a416b22fb6d2d5e3939dcbf68378c98d1b2af8295198a9b51bfb6edfb9569ffc"` [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking textwrap v0.6.0 [INFO] [stderr] Checking nom v3.2.0 [INFO] [stderr] Checking clap v2.25.1 [INFO] [stderr] Checking log-parser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:251:17 [INFO] [stderr] | [INFO] [stderr] 251 | cpows: cpows, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cpows` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | indirect_cpows: indirect_cpows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `indirect_cpows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | include_shims: include_shims, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `include_shims` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:251:17 [INFO] [stderr] | [INFO] [stderr] 251 | cpows: cpows, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cpows` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | indirect_cpows: indirect_cpows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `indirect_cpows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | include_shims: include_shims, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `include_shims` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:106:25 [INFO] [stderr] | [INFO] [stderr] 106 | assert!(rest.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:112:25 [INFO] [stderr] | [INFO] [stderr] 112 | assert!(rest.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / match self.cur_line.as_ref().unwrap() { [INFO] [stderr] 163 | | &LogLine::StackComponent(idx, ref path, ref filename, line_no) => { [INFO] [stderr] 164 | | assert!(idx == 0); [INFO] [stderr] 165 | | if is_test_path(path) { [INFO] [stderr] ... | [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 162 | match *self.cur_line.as_ref().unwrap() { [INFO] [stderr] 163 | LogLine::StackComponent(idx, ref path, ref filename, line_no) => { [INFO] [stderr] 164 | assert!(idx == 0); [INFO] [stderr] 165 | if is_test_path(path) { [INFO] [stderr] 166 | report = true; [INFO] [stderr] 167 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | / match self.cur_line.as_ref().unwrap() { [INFO] [stderr] 187 | | // Pull lines until we find the next test or the next CPOW. [INFO] [stderr] 188 | | &LogLine::StackComponent(0, _, _, _) | &LogLine::TestStart(_) => break, [INFO] [stderr] 189 | | &LogLine::StackComponent(_, ref path, ref filename, line_no) => { [INFO] [stderr] ... | [INFO] [stderr] 208 | | } [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 186 | match *self.cur_line.as_ref().unwrap() { [INFO] [stderr] 187 | // Pull lines until we find the next test or the next CPOW. [INFO] [stderr] 188 | LogLine::StackComponent(0, _, _, _) | LogLine::TestStart(_) => break, [INFO] [stderr] 189 | LogLine::StackComponent(_, ref path, ref filename, line_no) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:321:22 [INFO] [stderr] | [INFO] [stderr] 321 | for (_, test) in &all_tests { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 321 | for test in all_tests.values() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:106:25 [INFO] [stderr] | [INFO] [stderr] 106 | assert!(rest.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:112:25 [INFO] [stderr] | [INFO] [stderr] 112 | assert!(rest.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / match self.cur_line.as_ref().unwrap() { [INFO] [stderr] 163 | | &LogLine::StackComponent(idx, ref path, ref filename, line_no) => { [INFO] [stderr] 164 | | assert!(idx == 0); [INFO] [stderr] 165 | | if is_test_path(path) { [INFO] [stderr] ... | [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 162 | match *self.cur_line.as_ref().unwrap() { [INFO] [stderr] 163 | LogLine::StackComponent(idx, ref path, ref filename, line_no) => { [INFO] [stderr] 164 | assert!(idx == 0); [INFO] [stderr] 165 | if is_test_path(path) { [INFO] [stderr] 166 | report = true; [INFO] [stderr] 167 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | / match self.cur_line.as_ref().unwrap() { [INFO] [stderr] 187 | | // Pull lines until we find the next test or the next CPOW. [INFO] [stderr] 188 | | &LogLine::StackComponent(0, _, _, _) | &LogLine::TestStart(_) => break, [INFO] [stderr] 189 | | &LogLine::StackComponent(_, ref path, ref filename, line_no) => { [INFO] [stderr] ... | [INFO] [stderr] 208 | | } [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 186 | match *self.cur_line.as_ref().unwrap() { [INFO] [stderr] 187 | // Pull lines until we find the next test or the next CPOW. [INFO] [stderr] 188 | LogLine::StackComponent(0, _, _, _) | LogLine::TestStart(_) => break, [INFO] [stderr] 189 | LogLine::StackComponent(_, ref path, ref filename, line_no) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:321:22 [INFO] [stderr] | [INFO] [stderr] 321 | for (_, test) in &all_tests { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 321 | for test in all_tests.values() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.04s [INFO] running `"docker" "inspect" "a416b22fb6d2d5e3939dcbf68378c98d1b2af8295198a9b51bfb6edfb9569ffc"` [INFO] running `"docker" "rm" "-f" "a416b22fb6d2d5e3939dcbf68378c98d1b2af8295198a9b51bfb6edfb9569ffc"` [INFO] [stdout] a416b22fb6d2d5e3939dcbf68378c98d1b2af8295198a9b51bfb6edfb9569ffc