[INFO] updating cached repository mraof/morbitgen
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mraof/morbitgen
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mraof/morbitgen" "work/ex/clippy-test-run/sources/stable/gh/mraof/morbitgen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mraof/morbitgen'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mraof/morbitgen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mraof/morbitgen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mraof/morbitgen'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 891b819fb658f27186d662e0f983736b111750ec
[INFO] sha for GitHub repo mraof/morbitgen: 891b819fb658f27186d662e0f983736b111750ec
[INFO] validating manifest of mraof/morbitgen on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mraof/morbitgen on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mraof/morbitgen
[INFO] finished frobbing mraof/morbitgen
[INFO] frobbed toml for mraof/morbitgen written to work/ex/clippy-test-run/sources/stable/gh/mraof/morbitgen/Cargo.toml
[INFO] started frobbing mraof/morbitgen
[INFO] finished frobbing mraof/morbitgen
[INFO] frobbed toml for mraof/morbitgen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mraof/morbitgen/Cargo.toml
[INFO] crate mraof/morbitgen has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mraof/morbitgen against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mraof/morbitgen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3f701f502f1be4ae76883d634ec73b453f2bcb0ed93efcc300b9460d7dc8b1e7
[INFO] running `"docker" "start" "-a" "3f701f502f1be4ae76883d634ec73b453f2bcb0ed93efcc300b9460d7dc8b1e7"`
[INFO] [stderr]     Checking morbitgen v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/serde_support.rs:113:24
[INFO] [stderr]     |
[INFO] [stderr] 113 |         const FIELDS: &'static [&'static str] =
[INFO] [stderr]     |                       -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/serde_support.rs:113:34
[INFO] [stderr]     |
[INFO] [stderr] 113 |         const FIELDS: &'static [&'static str] =
[INFO] [stderr]     |                                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/serde_support.rs:113:24
[INFO] [stderr]     |
[INFO] [stderr] 113 |         const FIELDS: &'static [&'static str] =
[INFO] [stderr]     |                       -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/serde_support.rs:113:34
[INFO] [stderr]     |
[INFO] [stderr] 113 |         const FIELDS: &'static [&'static str] =
[INFO] [stderr]     |                                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/serde_support.rs:94:29
[INFO] [stderr]    |
[INFO] [stderr] 94 |                             let _: () = map.next_value()?;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/serde_support.rs:126:9
[INFO] [stderr]     |
[INFO] [stderr] 126 | /         match &self.generator {
[INFO] [stderr] 127 | |             &Generator::Choose(ref choices) => {
[INFO] [stderr] 128 | |                 map.serialize_entry("choose", choices)?;
[INFO] [stderr] 129 | |             }
[INFO] [stderr] ...   |
[INFO] [stderr] 136 | |             &Generator::Nothing => {}
[INFO] [stderr] 137 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 126 |         match self.generator {
[INFO] [stderr] 127 |             Generator::Choose(ref choices) => {
[INFO] [stderr] 128 |                 map.serialize_entry("choose", choices)?;
[INFO] [stderr] 129 |             }
[INFO] [stderr] 130 |             Generator::Reuse(ref attribute_name) => {
[INFO] [stderr] 131 |                 map.serialize_entry("reuse", attribute_name)?;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/serde_support.rs:94:29
[INFO] [stderr]    |
[INFO] [stderr] 94 |                             let _: () = map.next_value()?;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/serde_support.rs:126:9
[INFO] [stderr]     |
[INFO] [stderr] 126 | /         match &self.generator {
[INFO] [stderr] 127 | |             &Generator::Choose(ref choices) => {
[INFO] [stderr] 128 | |                 map.serialize_entry("choose", choices)?;
[INFO] [stderr] 129 | |             }
[INFO] [stderr] ...   |
[INFO] [stderr] 136 | |             &Generator::Nothing => {}
[INFO] [stderr] 137 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 126 |         match self.generator {
[INFO] [stderr] 127 |             Generator::Choose(ref choices) => {
[INFO] [stderr] 128 |                 map.serialize_entry("choose", choices)?;
[INFO] [stderr] 129 |             }
[INFO] [stderr] 130 |             Generator::Reuse(ref attribute_name) => {
[INFO] [stderr] 131 |                 map.serialize_entry("reuse", attribute_name)?;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in &self.possibilities.enumerate()` or similar iterators
[INFO] [stderr]    --> src/lib.rs:103:47
[INFO] [stderr]     |
[INFO] [stderr] 103 |         for &(ref key, ref value, ref not) in &self.possibilities {
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:126:19
[INFO] [stderr]     |
[INFO] [stderr] 126 |     pub fn chance(&self) -> u32 {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/lib.rs:399:38
[INFO] [stderr]     |
[INFO] [stderr] 399 |                 if let Some(value) = generated.get(attribute_name).map(|value| value.clone()) {
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `generated.get(attribute_name).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:408:9
[INFO] [stderr]     |
[INFO] [stderr] 408 | /         match self {
[INFO] [stderr] 409 | |             &Generator::Choose(ref options) => {
[INFO] [stderr] 410 | |                 if let Some(value) = options.get(name) {
[INFO] [stderr] 411 | |                     value.get_requirements(name, attributes)
[INFO] [stderr] ...   |
[INFO] [stderr] 435 | |             &Generator::Nothing => Vec::new(),
[INFO] [stderr] 436 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 408 |         match *self {
[INFO] [stderr] 409 |             Generator::Choose(ref options) => {
[INFO] [stderr] 410 |                 if let Some(value) = options.get(name) {
[INFO] [stderr] 411 |                     value.get_requirements(name, attributes)
[INFO] [stderr] 412 |                 } else {
[INFO] [stderr] 413 |                     for value in options.values() {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:440:9
[INFO] [stderr]     |
[INFO] [stderr] 440 | /         match self {
[INFO] [stderr] 441 | |             &Generator::Choose(ref options) => {
[INFO] [stderr] 442 | |                 if let Some(value) = options.get(name) {
[INFO] [stderr] 443 | |                     match &value.generator {
[INFO] [stderr] ...   |
[INFO] [stderr] 464 | |             &Generator::Nothing => false,
[INFO] [stderr] 465 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 440 |         match *self {
[INFO] [stderr] 441 |             Generator::Choose(ref options) => {
[INFO] [stderr] 442 |                 if let Some(value) = options.get(name) {
[INFO] [stderr] 443 |                     match &value.generator {
[INFO] [stderr] 444 |                         &Generator::Nothing => true,
[INFO] [stderr] 445 |                         generator => generator.contains(name, attributes),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:469:9
[INFO] [stderr]     |
[INFO] [stderr] 469 | /         match self {
[INFO] [stderr] 470 | |             &Generator::Choose(ref options) => {
[INFO] [stderr] 471 | |                 if let Some(value) = options.get(name) {
[INFO] [stderr] 472 | |                     match &value.generator {
[INFO] [stderr] ...   |
[INFO] [stderr] 494 | |             &Generator::Nothing => false,
[INFO] [stderr] 495 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 469 |         match *self {
[INFO] [stderr] 470 |             Generator::Choose(ref options) => {
[INFO] [stderr] 471 |                 if let Some(value) = options.get(name) {
[INFO] [stderr] 472 |                     match &value.generator {
[INFO] [stderr] 473 |                         &Generator::Nothing => value.chance.map_or(false, |chance| chance == Chance::Always) || options.len() == 1,
[INFO] [stderr] 474 |                         generator => generator.always(name, attributes),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:517:15
[INFO] [stderr]     |
[INFO] [stderr] 517 |     requires: &Vec<Requirement>,
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 517 |     requires: &[Requirement],
[INFO] [stderr]     |               ^^^^^^^^^^^^^^
[INFO] [stderr] help: change `requires.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 522 |     let mut requires = requires.to_owned();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:533:30
[INFO] [stderr]     |
[INFO] [stderr] 533 |             while finding && possibilities.len() > 0 {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!possibilities.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/lib.rs:541:24
[INFO] [stderr]     |
[INFO] [stderr] 541 |                   } else if !generated.contains_key(&key) {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 542 | |                     if let Some(attribute) = attributes.get(&key) {
[INFO] [stderr] 543 | |                         requires.append(&mut attribute.get_requirements(&value, attributes));
[INFO] [stderr] 544 | |                     }
[INFO] [stderr] 545 | |                     generated.insert(key, value);
[INFO] [stderr] 546 | |                     finding = false;
[INFO] [stderr] 547 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using: `generated.entry(key)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in &self.possibilities.enumerate()` or similar iterators
[INFO] [stderr]    --> src/lib.rs:103:47
[INFO] [stderr]     |
[INFO] [stderr] 103 |         for &(ref key, ref value, ref not) in &self.possibilities {
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:574:30
[INFO] [stderr]     |
[INFO] [stderr] 574 |                   let string = match formatting {
[INFO] [stderr]     |  ______________________________^
[INFO] [stderr] 575 | |                     &SubFormatting::Text(ref text) => text.clone(),
[INFO] [stderr] 576 | |                     &SubFormatting::Variable(ref variable) => {
[INFO] [stderr] 577 | |                         let value = generated.get(&variable.to_lowercase()).map_or(
[INFO] [stderr] ...   |
[INFO] [stderr] 593 | |                     &SubFormatting::Formatted(ref formatting) => formatting.format(generated),
[INFO] [stderr] 594 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 574 |                 let string = match *formatting {
[INFO] [stderr] 575 |                     SubFormatting::Text(ref text) => text.clone(),
[INFO] [stderr] 576 |                     SubFormatting::Variable(ref variable) => {
[INFO] [stderr] 577 |                         let value = generated.get(&variable.to_lowercase()).map_or(
[INFO] [stderr] 578 |                             "".to_string(),
[INFO] [stderr] 579 |                             |value| value.clone(),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:126:19
[INFO] [stderr]     |
[INFO] [stderr] 126 |     pub fn chance(&self) -> u32 {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/lib.rs:399:38
[INFO] [stderr]     |
[INFO] [stderr] 399 |                 if let Some(value) = generated.get(attribute_name).map(|value| value.clone()) {
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `generated.get(attribute_name).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:408:9
[INFO] [stderr]     |
[INFO] [stderr] 408 | /         match self {
[INFO] [stderr] 409 | |             &Generator::Choose(ref options) => {
[INFO] [stderr] 410 | |                 if let Some(value) = options.get(name) {
[INFO] [stderr] 411 | |                     value.get_requirements(name, attributes)
[INFO] [stderr] ...   |
[INFO] [stderr] 435 | |             &Generator::Nothing => Vec::new(),
[INFO] [stderr] 436 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 408 |         match *self {
[INFO] [stderr] 409 |             Generator::Choose(ref options) => {
[INFO] [stderr] 410 |                 if let Some(value) = options.get(name) {
[INFO] [stderr] 411 |                     value.get_requirements(name, attributes)
[INFO] [stderr] 412 |                 } else {
[INFO] [stderr] 413 |                     for value in options.values() {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:440:9
[INFO] [stderr]     |
[INFO] [stderr] 440 | /         match self {
[INFO] [stderr] 441 | |             &Generator::Choose(ref options) => {
[INFO] [stderr] 442 | |                 if let Some(value) = options.get(name) {
[INFO] [stderr] 443 | |                     match &value.generator {
[INFO] [stderr] ...   |
[INFO] [stderr] 464 | |             &Generator::Nothing => false,
[INFO] [stderr] 465 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 440 |         match *self {
[INFO] [stderr] 441 |             Generator::Choose(ref options) => {
[INFO] [stderr] 442 |                 if let Some(value) = options.get(name) {
[INFO] [stderr] 443 |                     match &value.generator {
[INFO] [stderr] 444 |                         &Generator::Nothing => true,
[INFO] [stderr] 445 |                         generator => generator.contains(name, attributes),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:469:9
[INFO] [stderr]     |
[INFO] [stderr] 469 | /         match self {
[INFO] [stderr] 470 | |             &Generator::Choose(ref options) => {
[INFO] [stderr] 471 | |                 if let Some(value) = options.get(name) {
[INFO] [stderr] 472 | |                     match &value.generator {
[INFO] [stderr] ...   |
[INFO] [stderr] 494 | |             &Generator::Nothing => false,
[INFO] [stderr] 495 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 469 |         match *self {
[INFO] [stderr] 470 |             Generator::Choose(ref options) => {
[INFO] [stderr] 471 |                 if let Some(value) = options.get(name) {
[INFO] [stderr] 472 |                     match &value.generator {
[INFO] [stderr] 473 |                         &Generator::Nothing => value.chance.map_or(false, |chance| chance == Chance::Always) || options.len() == 1,
[INFO] [stderr] 474 |                         generator => generator.always(name, attributes),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:517:15
[INFO] [stderr]     |
[INFO] [stderr] 517 |     requires: &Vec<Requirement>,
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 517 |     requires: &[Requirement],
[INFO] [stderr]     |               ^^^^^^^^^^^^^^
[INFO] [stderr] help: change `requires.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 522 |     let mut requires = requires.to_owned();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:533:30
[INFO] [stderr]     |
[INFO] [stderr] 533 |             while finding && possibilities.len() > 0 {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!possibilities.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/lib.rs:541:24
[INFO] [stderr]     |
[INFO] [stderr] 541 |                   } else if !generated.contains_key(&key) {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 542 | |                     if let Some(attribute) = attributes.get(&key) {
[INFO] [stderr] 543 | |                         requires.append(&mut attribute.get_requirements(&value, attributes));
[INFO] [stderr] 544 | |                     }
[INFO] [stderr] 545 | |                     generated.insert(key, value);
[INFO] [stderr] 546 | |                     finding = false;
[INFO] [stderr] 547 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using: `generated.entry(key)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:574:30
[INFO] [stderr]     |
[INFO] [stderr] 574 |                   let string = match formatting {
[INFO] [stderr]     |  ______________________________^
[INFO] [stderr] 575 | |                     &SubFormatting::Text(ref text) => text.clone(),
[INFO] [stderr] 576 | |                     &SubFormatting::Variable(ref variable) => {
[INFO] [stderr] 577 | |                         let value = generated.get(&variable.to_lowercase()).map_or(
[INFO] [stderr] ...   |
[INFO] [stderr] 593 | |                     &SubFormatting::Formatted(ref formatting) => formatting.format(generated),
[INFO] [stderr] 594 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 574 |                 let string = match *formatting {
[INFO] [stderr] 575 |                     SubFormatting::Text(ref text) => text.clone(),
[INFO] [stderr] 576 |                     SubFormatting::Variable(ref variable) => {
[INFO] [stderr] 577 |                         let value = generated.get(&variable.to_lowercase()).map_or(
[INFO] [stderr] 578 |                             "".to_string(),
[INFO] [stderr] 579 |                             |value| value.clone(),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.13s
[INFO] running `"docker" "inspect" "3f701f502f1be4ae76883d634ec73b453f2bcb0ed93efcc300b9460d7dc8b1e7"`
[INFO] running `"docker" "rm" "-f" "3f701f502f1be4ae76883d634ec73b453f2bcb0ed93efcc300b9460d7dc8b1e7"`
[INFO] [stdout] 3f701f502f1be4ae76883d634ec73b453f2bcb0ed93efcc300b9460d7dc8b1e7