[INFO] updating cached repository mprasil/dronelab
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mprasil/dronelab
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mprasil/dronelab" "work/ex/clippy-test-run/sources/stable/gh/mprasil/dronelab"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mprasil/dronelab'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mprasil/dronelab" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mprasil/dronelab"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mprasil/dronelab'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 80269b85c7a71821a286da1a54648f4aa62244f4
[INFO] sha for GitHub repo mprasil/dronelab: 80269b85c7a71821a286da1a54648f4aa62244f4
[INFO] validating manifest of mprasil/dronelab on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mprasil/dronelab on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mprasil/dronelab
[INFO] finished frobbing mprasil/dronelab
[INFO] frobbed toml for mprasil/dronelab written to work/ex/clippy-test-run/sources/stable/gh/mprasil/dronelab/Cargo.toml
[INFO] started frobbing mprasil/dronelab
[INFO] finished frobbing mprasil/dronelab
[INFO] frobbed toml for mprasil/dronelab written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mprasil/dronelab/Cargo.toml
[INFO] crate mprasil/dronelab has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mprasil/dronelab against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mprasil/dronelab:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 05122f608a90927fbbfd293625662fcfdffdcac699d456d5a55991c85875d1bd
[INFO] running `"docker" "start" "-a" "05122f608a90927fbbfd293625662fcfdffdcac699d456d5a55991c85875d1bd"`
[INFO] [stderr]     Checking serde_yaml v0.8.5
[INFO] [stderr]     Checking dronelab v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/envsource.rs:25:30
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Some(var(&self.name).unwrap_or(self.default.clone()))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| self.default.clone())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/plugin_params.rs:30:62
[INFO] [stderr]    |
[INFO] [stderr] 30 |                                   if values.iter().all(|ref x| { 
[INFO] [stderr]    |  ______________________________________________________________^
[INFO] [stderr] 31 | |                                     x.is_number() || x.is_string() 
[INFO] [stderr] 32 | |                                 }) {
[INFO] [stderr]    | |_________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/envsource.rs:25:30
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Some(var(&self.name).unwrap_or(self.default.clone()))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| self.default.clone())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/plugin_params.rs:30:62
[INFO] [stderr]    |
[INFO] [stderr] 30 |                                   if values.iter().all(|ref x| { 
[INFO] [stderr]    |  ______________________________________________________________^
[INFO] [stderr] 31 | |                                     x.is_number() || x.is_string() 
[INFO] [stderr] 32 | |                                 }) {
[INFO] [stderr]    | |_________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.88s
[INFO] running `"docker" "inspect" "05122f608a90927fbbfd293625662fcfdffdcac699d456d5a55991c85875d1bd"`
[INFO] running `"docker" "rm" "-f" "05122f608a90927fbbfd293625662fcfdffdcac699d456d5a55991c85875d1bd"`
[INFO] [stdout] 05122f608a90927fbbfd293625662fcfdffdcac699d456d5a55991c85875d1bd