[INFO] updating cached repository mpigsley/rust-game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mpigsley/rust-game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mpigsley/rust-game" "work/ex/clippy-test-run/sources/stable/gh/mpigsley/rust-game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mpigsley/rust-game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mpigsley/rust-game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpigsley/rust-game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpigsley/rust-game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cdd8347747a8dcaadddc641ec98f45d58864cfb0 [INFO] sha for GitHub repo mpigsley/rust-game: cdd8347747a8dcaadddc641ec98f45d58864cfb0 [INFO] validating manifest of mpigsley/rust-game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mpigsley/rust-game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mpigsley/rust-game [INFO] finished frobbing mpigsley/rust-game [INFO] frobbed toml for mpigsley/rust-game written to work/ex/clippy-test-run/sources/stable/gh/mpigsley/rust-game/Cargo.toml [INFO] started frobbing mpigsley/rust-game [INFO] finished frobbing mpigsley/rust-game [INFO] frobbed toml for mpigsley/rust-game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpigsley/rust-game/Cargo.toml [INFO] crate mpigsley/rust-game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mpigsley/rust-game against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mpigsley/rust-game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cecdb9b953f35f26b38cf157c763e3a8f258aa83c27d58aa8fa1420ef27fe4b5 [INFO] running `"docker" "start" "-a" "cecdb9b953f35f26b38cf157c763e3a8f258aa83c27d58aa8fa1420ef27fe4b5"` [INFO] [stderr] Checking serde v1.0.40 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking tempfile v3.0.1 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Compiling serde_derive v1.0.40 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking piston2d-opengl_graphics v0.52.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking glutin v0.12.2 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.45.3 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking rust-game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:77:33 [INFO] [stderr] | [INFO] [stderr] 77 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:77:33 [INFO] [stderr] | [INFO] [stderr] 77 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 40.41s [INFO] running `"docker" "inspect" "cecdb9b953f35f26b38cf157c763e3a8f258aa83c27d58aa8fa1420ef27fe4b5"` [INFO] running `"docker" "rm" "-f" "cecdb9b953f35f26b38cf157c763e3a8f258aa83c27d58aa8fa1420ef27fe4b5"` [INFO] [stdout] cecdb9b953f35f26b38cf157c763e3a8f258aa83c27d58aa8fa1420ef27fe4b5