[INFO] updating cached repository mpgarate/dropper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mpgarate/dropper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mpgarate/dropper" "work/ex/clippy-test-run/sources/stable/gh/mpgarate/dropper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mpgarate/dropper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mpgarate/dropper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpgarate/dropper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpgarate/dropper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f053f069f97b2d5fe63262aecdf784164f7ddc90 [INFO] sha for GitHub repo mpgarate/dropper: f053f069f97b2d5fe63262aecdf784164f7ddc90 [INFO] validating manifest of mpgarate/dropper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mpgarate/dropper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mpgarate/dropper [INFO] finished frobbing mpgarate/dropper [INFO] frobbed toml for mpgarate/dropper written to work/ex/clippy-test-run/sources/stable/gh/mpgarate/dropper/Cargo.toml [INFO] started frobbing mpgarate/dropper [INFO] finished frobbing mpgarate/dropper [INFO] frobbed toml for mpgarate/dropper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpgarate/dropper/Cargo.toml [INFO] crate mpgarate/dropper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mpgarate/dropper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mpgarate/dropper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 47fe2b5ccb637d4433028ee3d546caf1b4fd5e179e256cab93291ff8f3ef3453 [INFO] running `"docker" "start" "-a" "47fe2b5ccb637d4433028ee3d546caf1b4fd5e179e256cab93291ff8f3ef3453"` [INFO] [stderr] Compiling either v1.4.0 [INFO] [stderr] Compiling sdl2-sys v0.27.3 [INFO] [stderr] Compiling x11-dl v2.17.3 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking crossbeam-epoch v0.3.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking pistoncore-input v0.17.1 [INFO] [stderr] Checking quaternion v0.3.0 [INFO] [stderr] Checking piston2d-graphics v0.20.1 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking gfx_core v0.6.1 [INFO] [stderr] Checking uuid v0.1.18 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking piston3d-cam v0.3.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Compiling gfx_gl v0.4.0 [INFO] [stderr] Compiling gl v0.7.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking pistoncore-window v0.26.2 [INFO] [stderr] Checking piston-ai_behavior v0.19.0 [INFO] [stderr] Checking piston2d-drag_controller v0.18.0 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Compiling glutin v0.10.1 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Checking camera_controllers v0.20.0 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking piston2d-sprite v0.33.0 [INFO] [stderr] Checking piston2d-graphics v0.24.0 [INFO] [stderr] Checking sdl2 v0.28.0 [INFO] [stderr] Checking rayon v1.0.0 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking pistoncore-sdl2_window v0.40.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking gfx_device_gl v0.13.1 [INFO] [stderr] Checking gfx v0.14.1 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.0 [INFO] [stderr] Checking piston-gfx_texture v0.31.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.48.0 [INFO] [stderr] Checking piston_window v0.75.0 [INFO] [stderr] Checking dropper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame_timer.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | duration: duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | piece_generator: piece_generator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piece_generator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | Piece { row: row, col: col, color: self.get(row, col).unwrap() } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:89:31 [INFO] [stderr] | [INFO] [stderr] 89 | Piece { row: row, col: col, color: self.get(row, col).unwrap() } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame_timer.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | duration: duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | piece_generator: piece_generator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piece_generator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | Piece { row: row, col: col, color: self.get(row, col).unwrap() } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:89:31 [INFO] [stderr] | [INFO] [stderr] 89 | Piece { row: row, col: col, color: self.get(row, col).unwrap() } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/frame_timer.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/game.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn next(&mut self) -> Piece { [INFO] [stderr] 17 | | match self { [INFO] [stderr] 18 | | &mut PieceGenerator::Random(max_col) => { [INFO] [stderr] 19 | | let mut rng = thread_rng(); [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match self { [INFO] [stderr] 18 | | &mut PieceGenerator::Random(max_col) => { [INFO] [stderr] 19 | | let mut rng = thread_rng(); [INFO] [stderr] 20 | | [INFO] [stderr] ... | [INFO] [stderr] 27 | | &mut PieceGenerator::Exact(ref mut pieces) => pieces.remove(0), [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *self { [INFO] [stderr] 18 | PieceGenerator::Random(max_col) => { [INFO] [stderr] 19 | let mut rng = thread_rng(); [INFO] [stderr] 20 | [INFO] [stderr] 21 | Piece { [INFO] [stderr] 22 | row: 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/game.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / self.board.get_pieces() [INFO] [stderr] 92 | | .iter() [INFO] [stderr] 93 | | .map(|x| x.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 91 | self.board.get_pieces() [INFO] [stderr] 92 | .iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/game.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | if let None = self.board.get(self.current_piece.row, new_col) { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 108 | | self.current_piece.col = new_col; [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________- help: try this: `if self.board.get(self.current_piece.row, new_col).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game.rs:117:45 [INFO] [stderr] | [INFO] [stderr] 117 | let is_piece_below = self.board.get(new_row.clone(), self.current_piece.col) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_row` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/board.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | self.color_matrix.get_mut(row).unwrap()[col] = Some(color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.color_matrix[row]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/board.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | self.color_matrix.get_mut(row).unwrap()[col] = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.color_matrix[row]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/board.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | for row in (0..(starting_row + 1)).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=starting_row)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/board.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | self.color_matrix.get_mut(row).unwrap()[col] = piece_above; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.color_matrix[row]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/frame_timer.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/game.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn next(&mut self) -> Piece { [INFO] [stderr] 17 | | match self { [INFO] [stderr] 18 | | &mut PieceGenerator::Random(max_col) => { [INFO] [stderr] 19 | | let mut rng = thread_rng(); [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match self { [INFO] [stderr] 18 | | &mut PieceGenerator::Random(max_col) => { [INFO] [stderr] 19 | | let mut rng = thread_rng(); [INFO] [stderr] 20 | | [INFO] [stderr] ... | [INFO] [stderr] 27 | | &mut PieceGenerator::Exact(ref mut pieces) => pieces.remove(0), [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *self { [INFO] [stderr] 18 | PieceGenerator::Random(max_col) => { [INFO] [stderr] 19 | let mut rng = thread_rng(); [INFO] [stderr] 20 | [INFO] [stderr] 21 | Piece { [INFO] [stderr] 22 | row: 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/game.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / self.board.get_pieces() [INFO] [stderr] 92 | | .iter() [INFO] [stderr] 93 | | .map(|x| x.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 91 | self.board.get_pieces() [INFO] [stderr] 92 | .iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/game.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | if let None = self.board.get(self.current_piece.row, new_col) { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 108 | | self.current_piece.col = new_col; [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________- help: try this: `if self.board.get(self.current_piece.row, new_col).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game.rs:117:45 [INFO] [stderr] | [INFO] [stderr] 117 | let is_piece_below = self.board.get(new_row.clone(), self.current_piece.col) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_row` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/board.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | self.color_matrix.get_mut(row).unwrap()[col] = Some(color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.color_matrix[row]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/board.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | self.color_matrix.get_mut(row).unwrap()[col] = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.color_matrix[row]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/board.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | for row in (0..(starting_row + 1)).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=starting_row)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/board.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | self.color_matrix.get_mut(row).unwrap()[col] = piece_above; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.color_matrix[row]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | (piece.col as u32 * BLOCK_WIDTH) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(piece.col as u32 * BLOCK_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | (piece.row as u32 * BLOCK_HEIGHT) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(piece.row as u32 * BLOCK_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | BLOCK_WIDTH as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(BLOCK_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | BLOCK_HEIGHT as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(BLOCK_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | (piece.col as u32 * BLOCK_WIDTH) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(piece.col as u32 * BLOCK_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | (piece.row as u32 * BLOCK_HEIGHT) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(piece.row as u32 * BLOCK_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | BLOCK_WIDTH as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(BLOCK_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | BLOCK_HEIGHT as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(BLOCK_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 23s [INFO] running `"docker" "inspect" "47fe2b5ccb637d4433028ee3d546caf1b4fd5e179e256cab93291ff8f3ef3453"` [INFO] running `"docker" "rm" "-f" "47fe2b5ccb637d4433028ee3d546caf1b4fd5e179e256cab93291ff8f3ef3453"` [INFO] [stdout] 47fe2b5ccb637d4433028ee3d546caf1b4fd5e179e256cab93291ff8f3ef3453