[INFO] updating cached repository mpereira/noronha [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mpereira/noronha [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mpereira/noronha" "work/ex/clippy-test-run/sources/stable/gh/mpereira/noronha"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mpereira/noronha'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mpereira/noronha" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpereira/noronha"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpereira/noronha'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6daf3c4c566a8b45b6282675372a5392842dbb58 [INFO] sha for GitHub repo mpereira/noronha: 6daf3c4c566a8b45b6282675372a5392842dbb58 [INFO] validating manifest of mpereira/noronha on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mpereira/noronha on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mpereira/noronha [INFO] finished frobbing mpereira/noronha [INFO] frobbed toml for mpereira/noronha written to work/ex/clippy-test-run/sources/stable/gh/mpereira/noronha/Cargo.toml [INFO] started frobbing mpereira/noronha [INFO] finished frobbing mpereira/noronha [INFO] frobbed toml for mpereira/noronha written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpereira/noronha/Cargo.toml [INFO] crate mpereira/noronha has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mpereira/noronha against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mpereira/noronha:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b6a3770eb2d8aec2702ec8d24e356fe4db40351ac13666bd25091d8cf36612be [INFO] running `"docker" "start" "-a" "b6a3770eb2d8aec2702ec8d24e356fe4db40351ac13666bd25091d8cf36612be"` [INFO] [stderr] Checking arc-swap v0.3.0 [INFO] [stderr] Checking rand v0.5.4 [INFO] [stderr] Checking bytes v0.4.9 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking log v0.4.3 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking serde_yaml v0.7.5 [INFO] [stderr] Checking ring v0.13.2 [INFO] [stderr] Compiling syn v0.14.5 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking regex v1.0.2 [INFO] [stderr] Compiling im v11.0.1 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking signal-hook v0.1.3 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking http v0.1.8 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking chrono v0.4.5 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking serde-value v0.5.2 [INFO] [stderr] Checking tokio-fs v0.1.2 [INFO] [stderr] Checking state v0.4.1 [INFO] [stderr] Checking crossbeam-channel v0.2.4 [INFO] [stderr] Checking serde-hjson v0.8.1 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-signal v0.2.1 [INFO] [stderr] Checking mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking trust-dns-proto v0.4.0 [INFO] [stderr] Checking config v0.9.0 [INFO] [stderr] Checking h2 v0.1.10 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling actix_derive v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.70 [INFO] [stderr] Checking trust-dns-resolver v0.9.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking actix v0.7.3 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.8.7 [INFO] [stderr] Checking actix-web v0.7.3 [INFO] [stderr] Checking log4rs v0.8.0 [INFO] [stderr] Checking noronha v0.1.0-SNAPSHOT (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/components/cluster.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keyspace.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/components/cluster.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keyspace.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/object.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/cluster.rs:42:51 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn register_ping(&mut self, pinger: Node) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/cluster.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn initialize() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/http_resources.rs:240:16 [INFO] [stderr] | [INFO] [stderr] 240 | pub fn start() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/http_transport.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn start() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/http_transport_pinger.rs:94:40 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn identify_peers(client: &Client) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/http_transport_pinger.rs:120:32 [INFO] [stderr] | [INFO] [stderr] 120 | fn ping_peers(client: &Client) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/http_transport_pinger.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn start() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/logging.rs:6:46 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn initialize(log_config_file: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/cluster.rs:42:51 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn register_ping(&mut self, pinger: Node) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/cluster.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn initialize() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/http_resources.rs:240:16 [INFO] [stderr] | [INFO] [stderr] 240 | pub fn start() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/http_transport.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn start() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/http_transport_pinger.rs:94:40 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn identify_peers(client: &Client) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/http_transport_pinger.rs:120:32 [INFO] [stderr] | [INFO] [stderr] 120 | fn ping_peers(client: &Client) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/http_transport_pinger.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn start() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/components/logging.rs:6:46 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn initialize(log_config_file: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `http_transport_pinger_connect_timeout` [INFO] [stderr] --> src/components/http_transport_pinger.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | let http_transport_pinger_connect_timeout = [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `_http_transport_pinger_connect_timeout` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `nodes` [INFO] [stderr] --> src/cluster.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn nodes(&self) -> HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write` [INFO] [stderr] --> src/components/configuration.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn write() -> RwLockWriteGuard<'static, Self> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `http_transport_pinger_connect_timeout` [INFO] [stderr] --> src/components/http_transport_pinger.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | let http_transport_pinger_connect_timeout = [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `_http_transport_pinger_connect_timeout` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/components/http_resources.rs:130:10 [INFO] [stderr] | [INFO] [stderr] 130 | .or(Some(make_id_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(make_id_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/components/http_resources.rs:177:10 [INFO] [stderr] | [INFO] [stderr] 177 | .or(Some(make_id_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(make_id_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/components/http_transport_pinger.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / match components::cluster::STATE.write().unwrap().as_mut() { [INFO] [stderr] 96 | | Some(cluster) => { [INFO] [stderr] 97 | | let unknown_peers = cluster.unknown_peers.clone(); [INFO] [stderr] 98 | | for peer in unknown_peers { [INFO] [stderr] ... | [INFO] [stderr] 116 | | None => (), [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | if let Some(cluster) = components::cluster::STATE.write().unwrap().as_mut() { [INFO] [stderr] 96 | let unknown_peers = cluster.unknown_peers.clone(); [INFO] [stderr] 97 | for peer in unknown_peers { [INFO] [stderr] 98 | info!("Identifying {}", peer.address); [INFO] [stderr] 99 | match identify_peer(client, cluster, &peer) { [INFO] [stderr] 100 | Ok(node) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/components/http_transport_pinger.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / match components::cluster::STATE.read().unwrap().as_ref() { [INFO] [stderr] 122 | | Some(cluster) => { [INFO] [stderr] 123 | | for peer in &cluster.peers { [INFO] [stderr] 124 | | info!("Pinging {}", peer.name); [INFO] [stderr] ... | [INFO] [stderr] 135 | | None => (), [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 121 | if let Some(cluster) = components::cluster::STATE.read().unwrap().as_ref() { [INFO] [stderr] 122 | for peer in &cluster.peers { [INFO] [stderr] 123 | info!("Pinging {}", peer.name); [INFO] [stderr] 124 | match ping_peer(client, &cluster.node, &peer) { [INFO] [stderr] 125 | Ok(pong) => { [INFO] [stderr] 126 | info!("Got pong from {}", pong.from.name); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: method is never used: `nodes` [INFO] [stderr] --> src/cluster.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn nodes(&self) -> HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write` [INFO] [stderr] --> src/components/configuration.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn write() -> RwLockWriteGuard<'static, Self> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/components/http_resources.rs:130:10 [INFO] [stderr] | [INFO] [stderr] 130 | .or(Some(make_id_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(make_id_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/components/http_resources.rs:177:10 [INFO] [stderr] | [INFO] [stderr] 177 | .or(Some(make_id_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(make_id_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/components/http_transport_pinger.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / match components::cluster::STATE.write().unwrap().as_mut() { [INFO] [stderr] 96 | | Some(cluster) => { [INFO] [stderr] 97 | | let unknown_peers = cluster.unknown_peers.clone(); [INFO] [stderr] 98 | | for peer in unknown_peers { [INFO] [stderr] ... | [INFO] [stderr] 116 | | None => (), [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | if let Some(cluster) = components::cluster::STATE.write().unwrap().as_mut() { [INFO] [stderr] 96 | let unknown_peers = cluster.unknown_peers.clone(); [INFO] [stderr] 97 | for peer in unknown_peers { [INFO] [stderr] 98 | info!("Identifying {}", peer.address); [INFO] [stderr] 99 | match identify_peer(client, cluster, &peer) { [INFO] [stderr] 100 | Ok(node) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/components/http_transport_pinger.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / match components::cluster::STATE.read().unwrap().as_ref() { [INFO] [stderr] 122 | | Some(cluster) => { [INFO] [stderr] 123 | | for peer in &cluster.peers { [INFO] [stderr] 124 | | info!("Pinging {}", peer.name); [INFO] [stderr] ... | [INFO] [stderr] 135 | | None => (), [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 121 | if let Some(cluster) = components::cluster::STATE.read().unwrap().as_ref() { [INFO] [stderr] 122 | for peer in &cluster.peers { [INFO] [stderr] 123 | info!("Pinging {}", peer.name); [INFO] [stderr] 124 | match ping_peer(client, &cluster.node, &peer) { [INFO] [stderr] 125 | Ok(pong) => { [INFO] [stderr] 126 | info!("Got pong from {}", pong.from.name); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 52s [INFO] running `"docker" "inspect" "b6a3770eb2d8aec2702ec8d24e356fe4db40351ac13666bd25091d8cf36612be"` [INFO] running `"docker" "rm" "-f" "b6a3770eb2d8aec2702ec8d24e356fe4db40351ac13666bd25091d8cf36612be"` [INFO] [stdout] b6a3770eb2d8aec2702ec8d24e356fe4db40351ac13666bd25091d8cf36612be