[INFO] updating cached repository mpdrescher/termcalc
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mpdrescher/termcalc
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mpdrescher/termcalc" "work/ex/clippy-test-run/sources/stable/gh/mpdrescher/termcalc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mpdrescher/termcalc'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mpdrescher/termcalc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpdrescher/termcalc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpdrescher/termcalc'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] be0409ef8f403d240378eb9c57f20952b8dacb73
[INFO] sha for GitHub repo mpdrescher/termcalc: be0409ef8f403d240378eb9c57f20952b8dacb73
[INFO] validating manifest of mpdrescher/termcalc on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mpdrescher/termcalc on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mpdrescher/termcalc
[INFO] finished frobbing mpdrescher/termcalc
[INFO] frobbed toml for mpdrescher/termcalc written to work/ex/clippy-test-run/sources/stable/gh/mpdrescher/termcalc/Cargo.toml
[INFO] started frobbing mpdrescher/termcalc
[INFO] finished frobbing mpdrescher/termcalc
[INFO] frobbed toml for mpdrescher/termcalc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpdrescher/termcalc/Cargo.toml
[INFO] crate mpdrescher/termcalc has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mpdrescher/termcalc against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mpdrescher/termcalc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 922f3b1029e9dd4325c404c523bff15a380a3d6a066d72ed6fe3d0058679c9d1
[INFO] running `"docker" "start" "-a" "922f3b1029e9dd4325c404c523bff15a380a3d6a066d72ed6fe3d0058679c9d1"`
[INFO] [stderr]     Checking nix v0.5.1
[INFO] [stderr]     Checking rustyline v1.0.0
[INFO] [stderr]     Checking termcalc v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib/function.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             args: args,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib/function.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             code: code
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib/function.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             args: args,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib/function.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             code: code
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `code`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib/interpreter.rs:68:10
[INFO] [stderr]    |
[INFO] [stderr] 68 |       else {
[INFO] [stderr]    |  __________^
[INFO] [stderr] 69 | |         if valstack.len() == 0 {
[INFO] [stderr] 70 | |             Err(format!("no arguments"))
[INFO] [stderr] 71 | |         }
[INFO] [stderr] ...  |
[INFO] [stderr] 74 | |         }
[INFO] [stderr] 75 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 68 |     else if valstack.len() == 0 {
[INFO] [stderr] 69 |     Err(format!("no arguments"))
[INFO] [stderr] 70 | }
[INFO] [stderr] 71 | else {
[INFO] [stderr] 72 |     Err(format!("unused arguments: {:?}", valstack))
[INFO] [stderr] 73 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib/interpreter.rs:68:10
[INFO] [stderr]    |
[INFO] [stderr] 68 |       else {
[INFO] [stderr]    |  __________^
[INFO] [stderr] 69 | |         if valstack.len() == 0 {
[INFO] [stderr] 70 | |             Err(format!("no arguments"))
[INFO] [stderr] 71 | |         }
[INFO] [stderr] ...  |
[INFO] [stderr] 74 | |         }
[INFO] [stderr] 75 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 68 |     else if valstack.len() == 0 {
[INFO] [stderr] 69 |     Err(format!("no arguments"))
[INFO] [stderr] 70 | }
[INFO] [stderr] 71 | else {
[INFO] [stderr] 72 |     Err(format!("unused arguments: {:?}", valstack))
[INFO] [stderr] 73 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `engine::Engine`
[INFO] [stderr]   --> src/lib/engine.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn new() -> Engine {
[INFO] [stderr] 19 | |         Engine {
[INFO] [stderr] 20 | |             static_empty_map: HashMap::new(),
[INFO] [stderr] 21 | |             vars: HashMap::new(),
[INFO] [stderr] 22 | |             functions: HashMap::new()
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 10 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib/engine.rs:46:33
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn get_val(&self, name: &String) -> Option<&Value> {
[INFO] [stderr]    |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lib/engine.rs:60:29
[INFO] [stderr]    |
[INFO] [stderr] 60 |         if line.starts_with(":") {
[INFO] [stderr]    |                             ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib/engine.rs:77:36
[INFO] [stderr]    |
[INFO] [stderr] 77 |                                 if line.trim().len() == 0 || line.trim().starts_with("--") {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.trim().is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib/engine.rs:118:44
[INFO] [stderr]     |
[INFO] [stderr] 118 |         let split_index = match param.find("=") {
[INFO] [stderr]     |                                            ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/engine.rs:120:46
[INFO] [stderr]     |
[INFO] [stderr] 120 |             None => return LineResult::Error(format!("no '=' found"))
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"no '=' found".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/engine.rs:126:38
[INFO] [stderr]     |
[INFO] [stderr] 126 |             return LineResult::Error(format!("no arguments or name in function definition"))
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"no arguments or name in function definition".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib/engine.rs:128:25
[INFO] [stderr]     |
[INFO] [stderr] 128 |         let func_name = arg_vec.get(0).unwrap().clone();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&arg_vec[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/engine.rs:130:38
[INFO] [stderr]     |
[INFO] [stderr] 130 |             return LineResult::Error(format!("function names should start with a lowercase character"))
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"function names should start with a lowercase character".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/engine.rs:133:38
[INFO] [stderr]     |
[INFO] [stderr] 133 |             return LineResult::Error(format!("functions cannot end with '!'"));
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"functions cannot end with '!'".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/engine.rs:147:46
[INFO] [stderr]     |
[INFO] [stderr] 147 |             None => return LineResult::Error(format!("set usage: ':set [var] [expr]'"))
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"set usage: ':set [var] [expr]'".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/engine.rs:151:38
[INFO] [stderr]     |
[INFO] [stderr] 151 |             return LineResult::Error(format!("variable names should start with an uppercase character"))
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"variable names should start with an uppercase character".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib/engine.rs:177:27
[INFO] [stderr]     |
[INFO] [stderr] 177 |     pub fn to_line_result(self) -> LineResult {
[INFO] [stderr]     |                           ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/lib/value.rs:95:42
[INFO] [stderr]    |
[INFO] [stderr] 95 |               else if NUMBERS.contains(&v) {
[INFO] [stderr]    |  __________________________________________^
[INFO] [stderr] 96 | |                 true
[INFO] [stderr] 97 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/lib/value.rs:92:25
[INFO] [stderr]    |
[INFO] [stderr] 92 |               if v == '-' {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 93 | |                 true
[INFO] [stderr] 94 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib/value.rs:95:18
[INFO] [stderr]     |
[INFO] [stderr] 95  |               else if NUMBERS.contains(&v) {
[INFO] [stderr]     |  __________________^
[INFO] [stderr] 96  | |                 true
[INFO] [stderr] 97  | |             }
[INFO] [stderr] 98  | |             else {
[INFO] [stderr] 99  | |                 false
[INFO] [stderr] 100 | |             }
[INFO] [stderr]     | |_____________^ help: you can reduce it to: `NUMBERS.contains(&v)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lib/tokenize.rs:82:27
[INFO] [stderr]    |
[INFO] [stderr] 82 |         if word.ends_with("!") {
[INFO] [stderr]    |                           ^^^ help: try using a char instead: `'!'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib/tokenize.rs:116:43
[INFO] [stderr]     |
[INFO] [stderr] 116 |                         if word.ends_with("!") {
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `'!'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]  --> src/lib/interpreter.rs:9:66
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn interpret(code: Vec<Token>, engine: &Engine, local_vars: &HashMap<String, Value>) -> Result<Value, String> {
[INFO] [stderr]   |                                                                  ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn interpret<S: ::std::hash::BuildHasher + Default>(code: Vec<Token>, engine: &Engine, local_vars: &HashMap<String, Value, S>) -> Result<Value, String> {
[INFO] [stderr]   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: ...and use generic constructor
[INFO] [stderr]   |
[INFO] [stderr] 44|                     let mut local_vars = HashMap::default();
[INFO] [stderr]   |                                          ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/lib/interpreter.rs:42:25
[INFO] [stderr]    |
[INFO] [stderr] 42 |                         function.args().into_iter().map(|x| x.clone())
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `function.args().into_iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/lib/interpreter.rs:42:41
[INFO] [stderr]    |
[INFO] [stderr] 42 |                         function.args().into_iter().map(|x| x.clone())
[INFO] [stderr]    |                                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib/interpreter.rs:69:12
[INFO] [stderr]    |
[INFO] [stderr] 69 |         if valstack.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `valstack.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/lib/interpreter.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 |             Err(format!("no arguments"))
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"no arguments".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/lib/interpreter.rs:109:20
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 if success == false {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!success`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/stdlib.rs:191:24
[INFO] [stderr]     |
[INFO] [stderr] 191 |             return Err(format!("square root of a negative number"))
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"square root of a negative number".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/lib/stdlib.rs:217:12
[INFO] [stderr]     |
[INFO] [stderr] 217 |         if p1val == p2val {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(p1val - p2val).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/lib/stdlib.rs:217:12
[INFO] [stderr]     |
[INFO] [stderr] 217 |         if p1val == p2val {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/stdlib.rs:350:24
[INFO] [stderr]     |
[INFO] [stderr] 350 |             return Err(format!("divide by zero"));
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"divide by zero".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `termcalc`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `engine::Engine`
[INFO] [stderr]   --> src/lib/engine.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn new() -> Engine {
[INFO] [stderr] 19 | |         Engine {
[INFO] [stderr] 20 | |             static_empty_map: HashMap::new(),
[INFO] [stderr] 21 | |             vars: HashMap::new(),
[INFO] [stderr] 22 | |             functions: HashMap::new()
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 10 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib/engine.rs:46:33
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn get_val(&self, name: &String) -> Option<&Value> {
[INFO] [stderr]    |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lib/engine.rs:60:29
[INFO] [stderr]    |
[INFO] [stderr] 60 |         if line.starts_with(":") {
[INFO] [stderr]    |                             ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib/engine.rs:77:36
[INFO] [stderr]    |
[INFO] [stderr] 77 |                                 if line.trim().len() == 0 || line.trim().starts_with("--") {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.trim().is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib/engine.rs:118:44
[INFO] [stderr]     |
[INFO] [stderr] 118 |         let split_index = match param.find("=") {
[INFO] [stderr]     |                                            ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/engine.rs:120:46
[INFO] [stderr]     |
[INFO] [stderr] 120 |             None => return LineResult::Error(format!("no '=' found"))
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"no '=' found".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/engine.rs:126:38
[INFO] [stderr]     |
[INFO] [stderr] 126 |             return LineResult::Error(format!("no arguments or name in function definition"))
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"no arguments or name in function definition".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib/engine.rs:128:25
[INFO] [stderr]     |
[INFO] [stderr] 128 |         let func_name = arg_vec.get(0).unwrap().clone();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&arg_vec[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/engine.rs:130:38
[INFO] [stderr]     |
[INFO] [stderr] 130 |             return LineResult::Error(format!("function names should start with a lowercase character"))
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"function names should start with a lowercase character".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/engine.rs:133:38
[INFO] [stderr]     |
[INFO] [stderr] 133 |             return LineResult::Error(format!("functions cannot end with '!'"));
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"functions cannot end with '!'".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/engine.rs:147:46
[INFO] [stderr]     |
[INFO] [stderr] 147 |             None => return LineResult::Error(format!("set usage: ':set [var] [expr]'"))
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"set usage: ':set [var] [expr]'".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/engine.rs:151:38
[INFO] [stderr]     |
[INFO] [stderr] 151 |             return LineResult::Error(format!("variable names should start with an uppercase character"))
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"variable names should start with an uppercase character".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib/engine.rs:177:27
[INFO] [stderr]     |
[INFO] [stderr] 177 |     pub fn to_line_result(self) -> LineResult {
[INFO] [stderr]     |                           ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/lib/value.rs:95:42
[INFO] [stderr]    |
[INFO] [stderr] 95 |               else if NUMBERS.contains(&v) {
[INFO] [stderr]    |  __________________________________________^
[INFO] [stderr] 96 | |                 true
[INFO] [stderr] 97 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/lib/value.rs:92:25
[INFO] [stderr]    |
[INFO] [stderr] 92 |               if v == '-' {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 93 | |                 true
[INFO] [stderr] 94 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib/value.rs:95:18
[INFO] [stderr]     |
[INFO] [stderr] 95  |               else if NUMBERS.contains(&v) {
[INFO] [stderr]     |  __________________^
[INFO] [stderr] 96  | |                 true
[INFO] [stderr] 97  | |             }
[INFO] [stderr] 98  | |             else {
[INFO] [stderr] 99  | |                 false
[INFO] [stderr] 100 | |             }
[INFO] [stderr]     | |_____________^ help: you can reduce it to: `NUMBERS.contains(&v)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lib/tokenize.rs:82:27
[INFO] [stderr]    |
[INFO] [stderr] 82 |         if word.ends_with("!") {
[INFO] [stderr]    |                           ^^^ help: try using a char instead: `'!'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib/tokenize.rs:116:43
[INFO] [stderr]     |
[INFO] [stderr] 116 |                         if word.ends_with("!") {
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `'!'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]  --> src/lib/interpreter.rs:9:66
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn interpret(code: Vec<Token>, engine: &Engine, local_vars: &HashMap<String, Value>) -> Result<Value, String> {
[INFO] [stderr]   |                                                                  ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn interpret<S: ::std::hash::BuildHasher + Default>(code: Vec<Token>, engine: &Engine, local_vars: &HashMap<String, Value, S>) -> Result<Value, String> {
[INFO] [stderr]   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: ...and use generic constructor
[INFO] [stderr]   |
[INFO] [stderr] 44|                     let mut local_vars = HashMap::default();
[INFO] [stderr]   |                                          ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/lib/interpreter.rs:42:25
[INFO] [stderr]    |
[INFO] [stderr] 42 |                         function.args().into_iter().map(|x| x.clone())
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `function.args().into_iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/lib/interpreter.rs:42:41
[INFO] [stderr]    |
[INFO] [stderr] 42 |                         function.args().into_iter().map(|x| x.clone())
[INFO] [stderr]    |                                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib/interpreter.rs:69:12
[INFO] [stderr]    |
[INFO] [stderr] 69 |         if valstack.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `valstack.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/lib/interpreter.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 |             Err(format!("no arguments"))
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"no arguments".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/lib/interpreter.rs:109:20
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 if success == false {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!success`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/stdlib.rs:191:24
[INFO] [stderr]     |
[INFO] [stderr] 191 |             return Err(format!("square root of a negative number"))
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"square root of a negative number".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/lib/stdlib.rs:217:12
[INFO] [stderr]     |
[INFO] [stderr] 217 |         if p1val == p2val {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(p1val - p2val).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/lib/stdlib.rs:217:12
[INFO] [stderr]     |
[INFO] [stderr] 217 |         if p1val == p2val {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib/stdlib.rs:350:24
[INFO] [stderr]     |
[INFO] [stderr] 350 |             return Err(format!("divide by zero"));
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"divide by zero".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `termcalc`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "922f3b1029e9dd4325c404c523bff15a380a3d6a066d72ed6fe3d0058679c9d1"`
[INFO] running `"docker" "rm" "-f" "922f3b1029e9dd4325c404c523bff15a380a3d6a066d72ed6fe3d0058679c9d1"`
[INFO] [stdout] 922f3b1029e9dd4325c404c523bff15a380a3d6a066d72ed6fe3d0058679c9d1