[INFO] updating cached repository mpdrescher/run-info [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mpdrescher/run-info [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mpdrescher/run-info" "work/ex/clippy-test-run/sources/stable/gh/mpdrescher/run-info"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mpdrescher/run-info'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mpdrescher/run-info" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpdrescher/run-info"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpdrescher/run-info'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6084269161e9ba2396eecc56480629a1c791e359 [INFO] sha for GitHub repo mpdrescher/run-info: 6084269161e9ba2396eecc56480629a1c791e359 [INFO] validating manifest of mpdrescher/run-info on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mpdrescher/run-info on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mpdrescher/run-info [INFO] finished frobbing mpdrescher/run-info [INFO] frobbed toml for mpdrescher/run-info written to work/ex/clippy-test-run/sources/stable/gh/mpdrescher/run-info/Cargo.toml [INFO] started frobbing mpdrescher/run-info [INFO] finished frobbing mpdrescher/run-info [INFO] frobbed toml for mpdrescher/run-info written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpdrescher/run-info/Cargo.toml [INFO] crate mpdrescher/run-info has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mpdrescher/run-info against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mpdrescher/run-info:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0750308e462eed8d62a7236ab6be206f39205541df4c7ddf2da5aff777eeb333 [INFO] running `"docker" "start" "-a" "0750308e462eed8d62a7236ab6be206f39205541df4c7ddf2da5aff777eeb333"` [INFO] [stderr] Checking libc v0.2.15 [INFO] [stderr] Checking unicode-segmentation v0.1.2 [INFO] [stderr] Checking strsim v0.5.1 [INFO] [stderr] Checking ansi_term v0.8.0 [INFO] [stderr] Checking term v0.4.4 [INFO] [stderr] Checking term_size v0.1.1 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking clap v2.11.0 [INFO] [stderr] Checking run-info v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpuinfo.rs:58:6 [INFO] [stderr] | [INFO] [stderr] 58 | busy: busy, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `busy` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpuinfo.rs:59:6 [INFO] [stderr] | [INFO] [stderr] 59 | idle: idle [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `idle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(term, "")` [INFO] [stderr] --> src/printutils.rs:66:10 [INFO] [stderr] | [INFO] [stderr] 66 | let _ = writeln!(term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(term, "")` [INFO] [stderr] --> src/printutils.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | let _ = writeln!(term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(term, "")` [INFO] [stderr] --> src/printutils.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | let _ = writeln!(term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:90:3 [INFO] [stderr] | [INFO] [stderr] 90 | delay: delay, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:91:3 [INFO] [stderr] | [INFO] [stderr] 91 | enable_color: enable_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `enable_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:92:3 [INFO] [stderr] | [INFO] [stderr] 92 | enable_graph: enable_graph, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `enable_graph` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:93:6 [INFO] [stderr] | [INFO] [stderr] 93 | mode: mode [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:100:2 [INFO] [stderr] | [INFO] [stderr] 100 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpuinfo.rs:58:6 [INFO] [stderr] | [INFO] [stderr] 58 | busy: busy, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `busy` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpuinfo.rs:59:6 [INFO] [stderr] | [INFO] [stderr] 59 | idle: idle [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `idle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(term, "")` [INFO] [stderr] --> src/printutils.rs:66:10 [INFO] [stderr] | [INFO] [stderr] 66 | let _ = writeln!(term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(term, "")` [INFO] [stderr] --> src/printutils.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | let _ = writeln!(term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(term, "")` [INFO] [stderr] --> src/printutils.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | let _ = writeln!(term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:90:3 [INFO] [stderr] | [INFO] [stderr] 90 | delay: delay, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:91:3 [INFO] [stderr] | [INFO] [stderr] 91 | enable_color: enable_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `enable_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:92:3 [INFO] [stderr] | [INFO] [stderr] 92 | enable_graph: enable_graph, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `enable_graph` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:93:6 [INFO] [stderr] | [INFO] [stderr] 93 | mode: mode [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:100:2 [INFO] [stderr] | [INFO] [stderr] 100 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/printutils.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | let barsize = ((value * size as f64)) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/printutils.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | let barsize = ((value * size as f64)) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/printer.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn print_small_mode(mut term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/printer.rs:158:23 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn print_log_mode(mut term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `pad_string` [INFO] [stderr] --> src/printutils.rs:126:1 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn pad_string(mut str: String, size: usize) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/printer.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn print_small_mode(mut term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/printer.rs:158:23 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn print_log_mode(mut term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] warning: the loop variable `i` is used to index `result` [INFO] [stderr] --> src/graph.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | for i in 0..GRAPH_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 29 | for (i, ) in result.iter_mut().enumerate().take(GRAPH_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: function is never used: `pad_string` [INFO] [stderr] --> src/printutils.rs:126:1 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn pad_string(mut str: String, size: usize) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the variable `col_count` is used as a loop counter. Consider using `for (col_count, item) in line.split_whitespace().enumerate()` or similar iterators [INFO] [stderr] --> src/meminfo.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | for info in line.split_whitespace() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `result` [INFO] [stderr] --> src/graph.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | for i in 0..GRAPH_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 29 | for (i, ) in result.iter_mut().enumerate().take(GRAPH_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/cpuinfo.rs:39:34 [INFO] [stderr] | [INFO] [stderr] 39 | if line.starts_with("cpu") && line.starts_with("cpu ") == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!line.starts_with("cpu ")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cpuinfo.rs:98:21 [INFO] [stderr] | [INFO] [stderr] 98 | let delta_idle = new.cores_load.get(core).unwrap().idle - old.cores_load.get(core).unwrap().idle; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `new.cores_load[core]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cpuinfo.rs:98:62 [INFO] [stderr] | [INFO] [stderr] 98 | let delta_idle = new.cores_load.get(core).unwrap().idle - old.cores_load.get(core).unwrap().idle; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `old.cores_load[core]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cpuinfo.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | let delta_busy = new.cores_load.get(core).unwrap().busy - old.cores_load.get(core).unwrap().busy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `new.cores_load[core]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cpuinfo.rs:99:62 [INFO] [stderr] | [INFO] [stderr] 99 | let delta_busy = new.cores_load.get(core).unwrap().busy - old.cores_load.get(core).unwrap().busy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `old.cores_load[core]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:22:33 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn print_progress_bar(term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn print_highlighted(term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn print_header(term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:69:26 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn print_graph(term: &mut Box + Send>, settings: &Settings, graph: &Graph) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `graph_height_values`. [INFO] [stderr] --> src/printutils.rs:80:18 [INFO] [stderr] | [INFO] [stderr] 80 | for x in 0..graph_height_values.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 80 | for in &graph_height_values { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn attribute(term: &mut Box + Send>, settings: &Settings, attrib: Attr) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:106:20 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn reset(term: &mut Box + Send>, settings: &Settings) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:112:23 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn colorize(term: &mut Box + Send>, settings: &Settings, color_code: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/printutils.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | if string.contains(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/printutils.rs:121:40 [INFO] [stderr] | [INFO] [stderr] 121 | string = string.split_at(string.find(".").unwrap() + 2).0.to_owned(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/printutils.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | if string.contains(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/printutils.rs:139:40 [INFO] [stderr] | [INFO] [stderr] 139 | string = string.split_at(string.find(".").unwrap() + 2).0.to_owned(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/printutils.rs:145:2 [INFO] [stderr] | [INFO] [stderr] 145 | let mut load_percentage: f64 = 0.0; [INFO] [stderr] | _____^ [INFO] [stderr] 146 | | if load.busy != 0 { [INFO] [stderr] 147 | | load_percentage = load.busy as f64 / (load.idle + load.busy) as f64; [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let load_percentage = if load.busy != 0 { load.busy as f64 / (load.idle + load.busy) as f64 } else { 0.0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printer.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn print(mut term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: the variable `col_count` is used as a loop counter. Consider using `for (col_count, item) in line.split_whitespace().enumerate()` or similar iterators [INFO] [stderr] --> src/meminfo.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | for info in line.split_whitespace() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/printer.rs:94:37 [INFO] [stderr] | [INFO] [stderr] 94 | print_highlighted(term, &settings, format!("{}", format_gib(mem.total))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `format_gib(mem.total).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/printer.rs:105:37 [INFO] [stderr] | [INFO] [stderr] 105 | print_highlighted(term, &settings, format!("{}", format_gib(mem.swap_total))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `format_gib(mem.swap_total).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printer.rs:116:35 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn print_small_mode(mut term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/printer.rs:120:37 [INFO] [stderr] | [INFO] [stderr] 120 | print_highlighted(term, &settings, format!("TOTAL: ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"TOTAL: ".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/cpuinfo.rs:39:34 [INFO] [stderr] | [INFO] [stderr] 39 | if line.starts_with("cpu") && line.starts_with("cpu ") == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!line.starts_with("cpu ")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/printer.rs:139:40 [INFO] [stderr] | [INFO] [stderr] 139 | print_highlighted(term, &settings, format!("RAM: ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"RAM: ".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/printer.rs:144:44 [INFO] [stderr] | [INFO] [stderr] 144 | print_highlighted(term, &settings, format!("SWAP: ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SWAP: ".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printer.rs:158:33 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn print_log_mode(mut term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cpuinfo.rs:98:21 [INFO] [stderr] | [INFO] [stderr] 98 | let delta_idle = new.cores_load.get(core).unwrap().idle - old.cores_load.get(core).unwrap().idle; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `new.cores_load[core]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cpuinfo.rs:98:62 [INFO] [stderr] | [INFO] [stderr] 98 | let delta_idle = new.cores_load.get(core).unwrap().idle - old.cores_load.get(core).unwrap().idle; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `old.cores_load[core]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cpuinfo.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | let delta_busy = new.cores_load.get(core).unwrap().busy - old.cores_load.get(core).unwrap().busy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `new.cores_load[core]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cpuinfo.rs:99:62 [INFO] [stderr] | [INFO] [stderr] 99 | let delta_busy = new.cores_load.get(core).unwrap().busy - old.cores_load.get(core).unwrap().busy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `old.cores_load[core]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:22:33 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn print_progress_bar(term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn print_highlighted(term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / let mut mode = Mode::Normal; [INFO] [stderr] 75 | | if matches.occurrences_of("log-mode") > 0 { [INFO] [stderr] 76 | | mode = Mode::Log; [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let mode = if matches.occurrences_of("log-mode") > 0 { Mode::Log } else { Mode::Normal };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn print_header(term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:69:26 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn print_graph(term: &mut Box + Send>, settings: &Settings, graph: &Graph) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `graph_height_values`. [INFO] [stderr] --> src/printutils.rs:80:18 [INFO] [stderr] | [INFO] [stderr] 80 | for x in 0..graph_height_values.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 80 | for in &graph_height_values { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn attribute(term: &mut Box + Send>, settings: &Settings, attrib: Attr) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:106:20 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn reset(term: &mut Box + Send>, settings: &Settings) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printutils.rs:112:23 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn colorize(term: &mut Box + Send>, settings: &Settings, color_code: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/printutils.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | if string.contains(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/printutils.rs:121:40 [INFO] [stderr] | [INFO] [stderr] 121 | string = string.split_at(string.find(".").unwrap() + 2).0.to_owned(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/printutils.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | if string.contains(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/printutils.rs:139:40 [INFO] [stderr] | [INFO] [stderr] 139 | string = string.split_at(string.find(".").unwrap() + 2).0.to_owned(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/printutils.rs:145:2 [INFO] [stderr] | [INFO] [stderr] 145 | let mut load_percentage: f64 = 0.0; [INFO] [stderr] | _____^ [INFO] [stderr] 146 | | if load.busy != 0 { [INFO] [stderr] 147 | | load_percentage = load.busy as f64 / (load.idle + load.busy) as f64; [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let load_percentage = if load.busy != 0 { load.busy as f64 / (load.idle + load.busy) as f64 } else { 0.0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printer.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn print(mut term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/printer.rs:94:37 [INFO] [stderr] | [INFO] [stderr] 94 | print_highlighted(term, &settings, format!("{}", format_gib(mem.total))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `format_gib(mem.total).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/printer.rs:105:37 [INFO] [stderr] | [INFO] [stderr] 105 | print_highlighted(term, &settings, format!("{}", format_gib(mem.swap_total))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `format_gib(mem.swap_total).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printer.rs:116:35 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn print_small_mode(mut term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/printer.rs:120:37 [INFO] [stderr] | [INFO] [stderr] 120 | print_highlighted(term, &settings, format!("TOTAL: ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"TOTAL: ".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/printer.rs:139:40 [INFO] [stderr] | [INFO] [stderr] 139 | print_highlighted(term, &settings, format!("RAM: ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"RAM: ".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/printer.rs:144:44 [INFO] [stderr] | [INFO] [stderr] 144 | print_highlighted(term, &settings, format!("SWAP: ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SWAP: ".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/printer.rs:158:33 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn print_log_mode(mut term: &mut Box + Send>, settings: &Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::Terminal + Send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / let mut mode = Mode::Normal; [INFO] [stderr] 75 | | if matches.occurrences_of("log-mode") > 0 { [INFO] [stderr] 76 | | mode = Mode::Log; [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let mode = if matches.occurrences_of("log-mode") > 0 { Mode::Log } else { Mode::Normal };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.37s [INFO] running `"docker" "inspect" "0750308e462eed8d62a7236ab6be206f39205541df4c7ddf2da5aff777eeb333"` [INFO] running `"docker" "rm" "-f" "0750308e462eed8d62a7236ab6be206f39205541df4c7ddf2da5aff777eeb333"` [INFO] [stdout] 0750308e462eed8d62a7236ab6be206f39205541df4c7ddf2da5aff777eeb333