[INFO] updating cached repository mount-tech/tug [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mount-tech/tug [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mount-tech/tug" "work/ex/clippy-test-run/sources/stable/gh/mount-tech/tug"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mount-tech/tug'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mount-tech/tug" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mount-tech/tug"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mount-tech/tug'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f3d9048b5f34d4588dfc67f758aa3673061a7244 [INFO] sha for GitHub repo mount-tech/tug: f3d9048b5f34d4588dfc67f758aa3673061a7244 [INFO] validating manifest of mount-tech/tug on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mount-tech/tug on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mount-tech/tug [INFO] finished frobbing mount-tech/tug [INFO] frobbed toml for mount-tech/tug written to work/ex/clippy-test-run/sources/stable/gh/mount-tech/tug/Cargo.toml [INFO] started frobbing mount-tech/tug [INFO] finished frobbing mount-tech/tug [INFO] frobbed toml for mount-tech/tug written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mount-tech/tug/Cargo.toml [INFO] crate mount-tech/tug has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mount-tech/tug against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mount-tech/tug:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c26fa2f5ba3125bea26089d6b27c984e0c2ebf36bb1c0812c75ac2920506b2c4 [INFO] running `"docker" "start" "-a" "c26fa2f5ba3125bea26089d6b27c984e0c2ebf36bb1c0812c75ac2920506b2c4"` [INFO] [stderr] Compiling pulldown-cmark v0.2.0 [INFO] [stderr] Checking fern v0.5.7 [INFO] [stderr] Checking crossbeam-epoch v0.7.0 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking hyper v0.10.15 [INFO] [stderr] Compiling syn v0.15.23 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking h2 v0.1.14 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Compiling serde_derive v1.0.82 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking hyper v0.12.18 [INFO] [stderr] Checking reqwest v0.6.2 [INFO] [stderr] Checking acme-client v0.5.3 [INFO] [stderr] Checking tug v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:244:25 [INFO] [stderr] | [INFO] [stderr] 244 | gzip: gzip, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `gzip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:244:25 [INFO] [stderr] | [INFO] [stderr] 244 | gzip: gzip, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `gzip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | const DEFAULT_CONFIG: &'static str = "tug.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:139:31 [INFO] [stderr] | [INFO] [stderr] 139 | const NOT_FOUND: &'static str = "Not Found"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | const DEFAULT_CONFIG: &'static str = "tug.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:139:31 [INFO] [stderr] | [INFO] [stderr] 139 | const NOT_FOUND: &'static str = "Not Found"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | / let mut buf = Vec::new(); [INFO] [stderr] 93 | | [INFO] [stderr] 94 | | if self.markdown.is_some() && file_path.extension() == Some(OsStr::new("md")) { [INFO] [stderr] 95 | | let markdown_conf = self.markdown.clone().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 119 | | let _ = file.read_to_end(&mut buf); [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let buf = if self.markdown.is_some() && file_path.extension() == Some(OsStr::new("md")) { ..; html_buf.into_bytes() } else { ..; Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:233:39 [INFO] [stderr] | [INFO] [stderr] 233 | let root = server_config.root.unwrap_or(".".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ".".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:275:31 [INFO] [stderr] | [INFO] [stderr] 275 | let log_path = config.log.unwrap_or("output.log".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "output.log".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | / let mut buf = Vec::new(); [INFO] [stderr] 93 | | [INFO] [stderr] 94 | | if self.markdown.is_some() && file_path.extension() == Some(OsStr::new("md")) { [INFO] [stderr] 95 | | let markdown_conf = self.markdown.clone().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 119 | | let _ = file.read_to_end(&mut buf); [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let buf = if self.markdown.is_some() && file_path.extension() == Some(OsStr::new("md")) { ..; html_buf.into_bytes() } else { ..; Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:233:39 [INFO] [stderr] | [INFO] [stderr] 233 | let root = server_config.root.unwrap_or(".".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ".".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:275:31 [INFO] [stderr] | [INFO] [stderr] 275 | let log_path = config.log.unwrap_or("output.log".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "output.log".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 51.46s [INFO] running `"docker" "inspect" "c26fa2f5ba3125bea26089d6b27c984e0c2ebf36bb1c0812c75ac2920506b2c4"` [INFO] running `"docker" "rm" "-f" "c26fa2f5ba3125bea26089d6b27c984e0c2ebf36bb1c0812c75ac2920506b2c4"` [INFO] [stdout] c26fa2f5ba3125bea26089d6b27c984e0c2ebf36bb1c0812c75ac2920506b2c4