[INFO] updating cached repository mosbasik/fluidspaces-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mosbasik/fluidspaces-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mosbasik/fluidspaces-rs" "work/ex/clippy-test-run/sources/stable/gh/mosbasik/fluidspaces-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mosbasik/fluidspaces-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mosbasik/fluidspaces-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mosbasik/fluidspaces-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mosbasik/fluidspaces-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8396cb976dcd95ce89ce98521b9f9c77736110cc [INFO] sha for GitHub repo mosbasik/fluidspaces-rs: 8396cb976dcd95ce89ce98521b9f9c77736110cc [INFO] validating manifest of mosbasik/fluidspaces-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mosbasik/fluidspaces-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mosbasik/fluidspaces-rs [INFO] finished frobbing mosbasik/fluidspaces-rs [INFO] frobbed toml for mosbasik/fluidspaces-rs written to work/ex/clippy-test-run/sources/stable/gh/mosbasik/fluidspaces-rs/Cargo.toml [INFO] started frobbing mosbasik/fluidspaces-rs [INFO] finished frobbing mosbasik/fluidspaces-rs [INFO] frobbed toml for mosbasik/fluidspaces-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mosbasik/fluidspaces-rs/Cargo.toml [INFO] crate mosbasik/fluidspaces-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mosbasik/fluidspaces-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mosbasik/fluidspaces-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 410cc79e56d264d44e9d55043298ac74fa206d171346060f4e9476dac5eb8302 [INFO] running `"docker" "start" "-a" "410cc79e56d264d44e9d55043298ac74fa206d171346060f4e9476dac5eb8302"` [INFO] [stderr] Checking serde v1.0.24 [INFO] [stderr] Checking clap v2.29.0 [INFO] [stderr] Checking memchr v2.1.1 [INFO] [stderr] Checking backtrace v0.3.4 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking serde_json v1.0.8 [INFO] [stderr] Checking i3ipc v0.8.2 [INFO] [stderr] Checking fluidspaces v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn title_from_name<'a>(name: &'a str) -> Result<&'a str, Error> { [INFO] [stderr] 37 | | match title_parser(Input(name)) { [INFO] [stderr] 38 | | Ok((_, (number, name))) => Ok(from_utf8(name.or(number).unwrap().as_bytes())?), [INFO] [stderr] 39 | | Err(e) => Err(err_msg(format!( [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/lib.rs:74:42 [INFO] [stderr] | [INFO] [stderr] 74 | self.workspaces.iter().find(|wp| wp.focused == true) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `wp.focused` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | fn title<'a>(&'a self) -> &'a str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / fn title<'a>(&'a self) -> &'a str { [INFO] [stderr] 106 | | title_from_name(&self.name).unwrap() [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn title_from_name<'a>(name: &'a str) -> Result<&'a str, Error> { [INFO] [stderr] 37 | | match title_parser(Input(name)) { [INFO] [stderr] 38 | | Ok((_, (number, name))) => Ok(from_utf8(name.or(number).unwrap().as_bytes())?), [INFO] [stderr] 39 | | Err(e) => Err(err_msg(format!( [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/parser.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 134 | / parser_tests! { [INFO] [stderr] 135 | | basic: ("7:foo", (Some(Input("7")), Some(Input("foo")))), [INFO] [stderr] 136 | | number_is_multidigit: ("77:foo", (Some(Input("77")), Some(Input("foo")))), [INFO] [stderr] 137 | | number_is_missing: (":foo", (None, Some(Input("foo")))), [INFO] [stderr] ... | [INFO] [stderr] 155 | | number_title_with_missing_index_missing_colon: ("2", (Some(Input("2")), None)), [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/parser.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 134 | / parser_tests! { [INFO] [stderr] 135 | | basic: ("7:foo", (Some(Input("7")), Some(Input("foo")))), [INFO] [stderr] 136 | | number_is_multidigit: ("77:foo", (Some(Input("77")), Some(Input("foo")))), [INFO] [stderr] 137 | | number_is_missing: (":foo", (None, Some(Input("foo")))), [INFO] [stderr] ... | [INFO] [stderr] 155 | | number_title_with_missing_index_missing_colon: ("2", (Some(Input("2")), None)), [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/lib.rs:74:42 [INFO] [stderr] | [INFO] [stderr] 74 | self.workspaces.iter().find(|wp| wp.focused == true) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `wp.focused` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | fn title<'a>(&'a self) -> &'a str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / fn title<'a>(&'a self) -> &'a str { [INFO] [stderr] 106 | | title_from_name(&self.name).unwrap() [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/fluidspaces.rs:97:40 [INFO] [stderr] | [INFO] [stderr] 97 | None => return Err(err_msg(format!("Couldn't find workspace number 2"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Couldn't find workspace number 2".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/fluidspaces.rs:112:48 [INFO] [stderr] | [INFO] [stderr] 112 | None => return Err(err_msg(format!("Couldn't get ref to stdin of dmenu"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Couldn't get ref to stdin of dmenu".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/fluidspaces.rs:97:40 [INFO] [stderr] | [INFO] [stderr] 97 | None => return Err(err_msg(format!("Couldn't find workspace number 2"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Couldn't find workspace number 2".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/fluidspaces.rs:112:48 [INFO] [stderr] | [INFO] [stderr] 112 | None => return Err(err_msg(format!("Couldn't get ref to stdin of dmenu"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Couldn't get ref to stdin of dmenu".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.94s [INFO] running `"docker" "inspect" "410cc79e56d264d44e9d55043298ac74fa206d171346060f4e9476dac5eb8302"` [INFO] running `"docker" "rm" "-f" "410cc79e56d264d44e9d55043298ac74fa206d171346060f4e9476dac5eb8302"` [INFO] [stdout] 410cc79e56d264d44e9d55043298ac74fa206d171346060f4e9476dac5eb8302