[INFO] updating cached repository mosbasik/CtCI-6th-Edition-Rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mosbasik/CtCI-6th-Edition-Rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mosbasik/CtCI-6th-Edition-Rust" "work/ex/clippy-test-run/sources/stable/gh/mosbasik/CtCI-6th-Edition-Rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mosbasik/CtCI-6th-Edition-Rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mosbasik/CtCI-6th-Edition-Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mosbasik/CtCI-6th-Edition-Rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mosbasik/CtCI-6th-Edition-Rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f7de2da54634d871fa8b0640e9e5c4473b96a858
[INFO] sha for GitHub repo mosbasik/CtCI-6th-Edition-Rust: f7de2da54634d871fa8b0640e9e5c4473b96a858
[INFO] validating manifest of mosbasik/CtCI-6th-Edition-Rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mosbasik/CtCI-6th-Edition-Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mosbasik/CtCI-6th-Edition-Rust
[INFO] finished frobbing mosbasik/CtCI-6th-Edition-Rust
[INFO] frobbed toml for mosbasik/CtCI-6th-Edition-Rust written to work/ex/clippy-test-run/sources/stable/gh/mosbasik/CtCI-6th-Edition-Rust/Cargo.toml
[INFO] started frobbing mosbasik/CtCI-6th-Edition-Rust
[INFO] finished frobbing mosbasik/CtCI-6th-Edition-Rust
[INFO] frobbed toml for mosbasik/CtCI-6th-Edition-Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mosbasik/CtCI-6th-Edition-Rust/Cargo.toml
[INFO] crate mosbasik/CtCI-6th-Edition-Rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mosbasik/CtCI-6th-Edition-Rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mosbasik/CtCI-6th-Edition-Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1b40e49d5ffd655f5fda131146b235e98fca1faa38f49740e20b09317cb51315
[INFO] running `"docker" "start" "-a" "1b40e49d5ffd655f5fda131146b235e98fca1faa38f49740e20b09317cb51315"`
[INFO] [stderr]     Checking ctci_6th_edition_rust v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`.
[INFO] [stderr]  --> src/ch_01_arrays_and_strings/q_03_urlify.rs:6:14
[INFO] [stderr]   |
[INFO] [stderr] 6 |     for i in 0..true_length {
[INFO] [stderr]   |              ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]   |
[INFO] [stderr] 6 |     for <item> in bytes.iter().take(true_length) {
[INFO] [stderr]   |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]  --> src/ch_01_arrays_and_strings/q_03_urlify.rs:7:24
[INFO] [stderr]   |
[INFO] [stderr] 7 |         if bytes[i] == " ".as_bytes()[0] {
[INFO] [stderr]   |                        ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" "`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/ch_01_arrays_and_strings/q_03_urlify.rs:15:31
[INFO] [stderr]    |
[INFO] [stderr] 15 |         if bytes[read_idx] == " ".as_bytes()[0] {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" "`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/ch_01_arrays_and_strings/q_03_urlify.rs:16:36
[INFO] [stderr]    |
[INFO] [stderr] 16 |             bytes[write_idx - 1] = "0".as_bytes()[0];
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"0"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/ch_01_arrays_and_strings/q_03_urlify.rs:17:36
[INFO] [stderr]    |
[INFO] [stderr] 17 |             bytes[write_idx - 2] = "2".as_bytes()[0];
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/ch_01_arrays_and_strings/q_03_urlify.rs:18:36
[INFO] [stderr]    |
[INFO] [stderr] 18 |             bytes[write_idx - 3] = "%".as_bytes()[0];
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"%"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`.
[INFO] [stderr]  --> src/ch_01_arrays_and_strings/q_03_urlify.rs:6:14
[INFO] [stderr]   |
[INFO] [stderr] 6 |     for i in 0..true_length {
[INFO] [stderr]   |              ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]   |
[INFO] [stderr] 6 |     for <item> in bytes.iter().take(true_length) {
[INFO] [stderr]   |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]  --> src/ch_01_arrays_and_strings/q_03_urlify.rs:7:24
[INFO] [stderr]   |
[INFO] [stderr] 7 |         if bytes[i] == " ".as_bytes()[0] {
[INFO] [stderr]   |                        ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" "`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/ch_01_arrays_and_strings/q_03_urlify.rs:15:31
[INFO] [stderr]    |
[INFO] [stderr] 15 |         if bytes[read_idx] == " ".as_bytes()[0] {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" "`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/ch_01_arrays_and_strings/q_03_urlify.rs:16:36
[INFO] [stderr]    |
[INFO] [stderr] 16 |             bytes[write_idx - 1] = "0".as_bytes()[0];
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"0"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/ch_01_arrays_and_strings/q_03_urlify.rs:17:36
[INFO] [stderr]    |
[INFO] [stderr] 17 |             bytes[write_idx - 2] = "2".as_bytes()[0];
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/ch_01_arrays_and_strings/q_03_urlify.rs:18:36
[INFO] [stderr]    |
[INFO] [stderr] 18 |             bytes[write_idx - 3] = "%".as_bytes()[0];
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"%"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.86s
[INFO] running `"docker" "inspect" "1b40e49d5ffd655f5fda131146b235e98fca1faa38f49740e20b09317cb51315"`
[INFO] running `"docker" "rm" "-f" "1b40e49d5ffd655f5fda131146b235e98fca1faa38f49740e20b09317cb51315"`
[INFO] [stdout] 1b40e49d5ffd655f5fda131146b235e98fca1faa38f49740e20b09317cb51315