[INFO] updating cached repository moratorium08/moo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/moratorium08/moo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/moratorium08/moo" "work/ex/clippy-test-run/sources/stable/gh/moratorium08/moo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/moratorium08/moo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/moratorium08/moo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moratorium08/moo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moratorium08/moo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] afb34d135dea862de6ba19a665216f579ee24bb8 [INFO] sha for GitHub repo moratorium08/moo: afb34d135dea862de6ba19a665216f579ee24bb8 [INFO] validating manifest of moratorium08/moo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of moratorium08/moo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing moratorium08/moo [INFO] finished frobbing moratorium08/moo [INFO] frobbed toml for moratorium08/moo written to work/ex/clippy-test-run/sources/stable/gh/moratorium08/moo/Cargo.toml [INFO] started frobbing moratorium08/moo [INFO] finished frobbing moratorium08/moo [INFO] frobbed toml for moratorium08/moo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moratorium08/moo/Cargo.toml [INFO] crate moratorium08/moo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting moratorium08/moo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/moratorium08/moo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d1cd541c1fb0fab4c4dbd5b538a34d39783786bb87547b076fda727637d8e9d [INFO] running `"docker" "start" "-a" "1d1cd541c1fb0fab4c4dbd5b538a34d39783786bb87547b076fda727637d8e9d"` [INFO] [stderr] Compiling memchr v2.1.0 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking stst v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:380:29 [INFO] [stderr] | [INFO] [stderr] 380 | let x = if c == 0 { b } else { a }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:387:37 [INFO] [stderr] | [INFO] [stderr] 387 | let e = &entry.env; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:380:29 [INFO] [stderr] | [INFO] [stderr] 380 | let x = if c == 0 { b } else { a }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:387:37 [INFO] [stderr] | [INFO] [stderr] 387 | let e = &entry.env; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::Chars` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::str::Chars; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc::getchar` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use libc::getchar; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | f [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | let f = Function { env, ip, name, id }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/main.rs:357:39 [INFO] [stderr] | [INFO] [stderr] 357 | eip = (&entry).ip; [INFO] [stderr] | ^^^^^^^^ help: try this: `entry.ip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/main.rs:389:39 [INFO] [stderr] | [INFO] [stderr] 389 | eip = (&entry).ip; [INFO] [stderr] | ^^^^^^^^ help: try this: `entry.ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::Chars` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::str::Chars; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc::getchar` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use libc::getchar; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | f [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | let f = Function { env, ip, name, id }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/main.rs:357:39 [INFO] [stderr] | [INFO] [stderr] 357 | eip = (&entry).ip; [INFO] [stderr] | ^^^^^^^^ help: try this: `entry.ip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/main.rs:389:39 [INFO] [stderr] | [INFO] [stderr] 389 | eip = (&entry).ip; [INFO] [stderr] | ^^^^^^^^ help: try this: `entry.ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `frame` [INFO] [stderr] --> src/main.rs:164:21 [INFO] [stderr] | [INFO] [stderr] 164 | let frame: &mut Frame = &mut env[n - 1]; [INFO] [stderr] | ^^^^^ help: consider using `_frame` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/main.rs:354:41 [INFO] [stderr] | [INFO] [stderr] 354 | let mut v: Vec<(ID, ID)> = Vec::new(); [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/main.rs:366:38 [INFO] [stderr] | [INFO] [stderr] 366 | Some(Value::List(c)) => { [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] [INFO] [stderr] warning: variable `nest` is assigned to, but never used [INFO] [stderr] --> src/main.rs:512:13 [INFO] [stderr] | [INFO] [stderr] 512 | let mut nest = 0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_nest` instead [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | fn to_usize(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn clone(&self) -> Value { [INFO] [stderr] 73 | | match &self { [INFO] [stderr] 74 | | Value::Int(ref x) => Value::Int(*x), [INFO] [stderr] 75 | | Value::List(ref l) => { [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | ((c as u8) - ('0' as u8)) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((c as u8) - ('0' as u8))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | ((c as u8) - ('0' as u8)) as i64 [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:116:29 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn search_by_id(fs: &Vec<(ID, ID)>, id: &ID) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[(ID, ID)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:116:49 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn search_by_id(fs: &Vec<(ID, ID)>, id: &ID) -> Option { [INFO] [stderr] | ^^^ help: consider passing by value instead: `ID` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:130:65 [INFO] [stderr] | [INFO] [stderr] 130 | fn run(code: &[u8], functions: & HashMap, global: & Vec<(ID, ID)>, setting: &Setting, stack: &mut Vec, entry_point: IP) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[(ID, ID)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/main.rs:130:1 [INFO] [stderr] | [INFO] [stderr] 130 | / fn run(code: &[u8], functions: & HashMap, global: & Vec<(ID, ID)>, setting: &Setting, stack: &mut Vec, entry_point: IP) -> Option { [INFO] [stderr] 131 | | let mut eip = entry_point; [INFO] [stderr] 132 | | let mut env = Vec::new(); [INFO] [stderr] 133 | | let mut num_state = false; [INFO] [stderr] ... | [INFO] [stderr] 501 | | } [INFO] [stderr] 502 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | assert!(env.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!env.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:191:20 [INFO] [stderr] | [INFO] [stderr] 191 | if env.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!env.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:318:47 [INFO] [stderr] | [INFO] [stderr] 318 | stack.push(Value::Int(c as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:423:28 [INFO] [stderr] | [INFO] [stderr] 423 | if l.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:481:37 [INFO] [stderr] | [INFO] [stderr] 481 | / match ret { [INFO] [stderr] 482 | | Some(x) => vec.push(x), [INFO] [stderr] 483 | | None => {}, [INFO] [stderr] 484 | | } [INFO] [stderr] | |_____________________________________^ help: try this: `if let Some(x) = ret { vec.push(x) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:604:13 [INFO] [stderr] | [INFO] [stderr] 604 | / match v as &str { [INFO] [stderr] 605 | | "d" => set.debug = true, [INFO] [stderr] 606 | | _ => {}, [INFO] [stderr] 607 | | } [INFO] [stderr] | |_____________^ help: try this: `if let "d" = v as &str { set.debug = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:623:5 [INFO] [stderr] | [INFO] [stderr] 623 | f.read_to_string(&mut code); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `frame` [INFO] [stderr] --> src/main.rs:164:21 [INFO] [stderr] | [INFO] [stderr] 164 | let frame: &mut Frame = &mut env[n - 1]; [INFO] [stderr] | ^^^^^ help: consider using `_frame` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/main.rs:354:41 [INFO] [stderr] | [INFO] [stderr] 354 | let mut v: Vec<(ID, ID)> = Vec::new(); [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/main.rs:366:38 [INFO] [stderr] | [INFO] [stderr] 366 | Some(Value::List(c)) => { [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] [INFO] [stderr] warning: variable `nest` is assigned to, but never used [INFO] [stderr] --> src/main.rs:512:13 [INFO] [stderr] | [INFO] [stderr] 512 | let mut nest = 0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_nest` instead [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | fn to_usize(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn clone(&self) -> Value { [INFO] [stderr] 73 | | match &self { [INFO] [stderr] 74 | | Value::Int(ref x) => Value::Int(*x), [INFO] [stderr] 75 | | Value::List(ref l) => { [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | ((c as u8) - ('0' as u8)) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((c as u8) - ('0' as u8))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | ((c as u8) - ('0' as u8)) as i64 [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:116:29 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn search_by_id(fs: &Vec<(ID, ID)>, id: &ID) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[(ID, ID)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:116:49 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn search_by_id(fs: &Vec<(ID, ID)>, id: &ID) -> Option { [INFO] [stderr] | ^^^ help: consider passing by value instead: `ID` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:130:65 [INFO] [stderr] | [INFO] [stderr] 130 | fn run(code: &[u8], functions: & HashMap, global: & Vec<(ID, ID)>, setting: &Setting, stack: &mut Vec, entry_point: IP) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[(ID, ID)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/main.rs:130:1 [INFO] [stderr] | [INFO] [stderr] 130 | / fn run(code: &[u8], functions: & HashMap, global: & Vec<(ID, ID)>, setting: &Setting, stack: &mut Vec, entry_point: IP) -> Option { [INFO] [stderr] 131 | | let mut eip = entry_point; [INFO] [stderr] 132 | | let mut env = Vec::new(); [INFO] [stderr] 133 | | let mut num_state = false; [INFO] [stderr] ... | [INFO] [stderr] 501 | | } [INFO] [stderr] 502 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | assert!(env.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!env.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:191:20 [INFO] [stderr] | [INFO] [stderr] 191 | if env.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!env.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:318:47 [INFO] [stderr] | [INFO] [stderr] 318 | stack.push(Value::Int(c as i64)); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:423:28 [INFO] [stderr] | [INFO] [stderr] 423 | if l.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:481:37 [INFO] [stderr] | [INFO] [stderr] 481 | / match ret { [INFO] [stderr] 482 | | Some(x) => vec.push(x), [INFO] [stderr] 483 | | None => {}, [INFO] [stderr] 484 | | } [INFO] [stderr] | |_____________________________________^ help: try this: `if let Some(x) = ret { vec.push(x) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:604:13 [INFO] [stderr] | [INFO] [stderr] 604 | / match v as &str { [INFO] [stderr] 605 | | "d" => set.debug = true, [INFO] [stderr] 606 | | _ => {}, [INFO] [stderr] 607 | | } [INFO] [stderr] | |_____________^ help: try this: `if let "d" = v as &str { set.debug = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:623:5 [INFO] [stderr] | [INFO] [stderr] 623 | f.read_to_string(&mut code); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.30s [INFO] running `"docker" "inspect" "1d1cd541c1fb0fab4c4dbd5b538a34d39783786bb87547b076fda727637d8e9d"` [INFO] running `"docker" "rm" "-f" "1d1cd541c1fb0fab4c4dbd5b538a34d39783786bb87547b076fda727637d8e9d"` [INFO] [stdout] 1d1cd541c1fb0fab4c4dbd5b538a34d39783786bb87547b076fda727637d8e9d