[INFO] updating cached repository moonglum/explore [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/moonglum/explore [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/moonglum/explore" "work/ex/clippy-test-run/sources/stable/gh/moonglum/explore"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/moonglum/explore'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/moonglum/explore" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moonglum/explore"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moonglum/explore'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] edbf4c09994b7a0e8538503ac41d66015ba4c4d3 [INFO] sha for GitHub repo moonglum/explore: edbf4c09994b7a0e8538503ac41d66015ba4c4d3 [INFO] validating manifest of moonglum/explore on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of moonglum/explore on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing moonglum/explore [INFO] finished frobbing moonglum/explore [INFO] frobbed toml for moonglum/explore written to work/ex/clippy-test-run/sources/stable/gh/moonglum/explore/Cargo.toml [INFO] started frobbing moonglum/explore [INFO] finished frobbing moonglum/explore [INFO] frobbed toml for moonglum/explore written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moonglum/explore/Cargo.toml [INFO] crate moonglum/explore has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting moonglum/explore against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/moonglum/explore:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 55e92e4748ec195d7d489df692a2877843698214ad13aa3f3c0ff71b6a47594b [INFO] running `"docker" "start" "-a" "55e92e4748ec195d7d489df692a2877843698214ad13aa3f3c0ff71b6a47594b"` [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking explore v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | modified: modified, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `modified` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | nlink: nlink, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nlink` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | file_name: file_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | modified: modified, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `modified` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | nlink: nlink, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nlink` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | file_name: file_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/entry.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | Err(_) => panic!("An Error Occurred!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/entry.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | Err(_) => panic!("An Error Occurred!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/entry.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match (self.permissions / (2u32.pow(8 - position))) % 2 == 1 { [INFO] [stderr] 95 | | true => permission_type, [INFO] [stderr] 96 | | false => '-', [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if (self.permissions / (2u32.pow(8 - position))) % 2 == 1 { permission_type } else { '-' }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | format!("{}", "./") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"./".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | format!("{}", args[1]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `args[1].to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/entry.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match (self.permissions / (2u32.pow(8 - position))) % 2 == 1 { [INFO] [stderr] 95 | | true => permission_type, [INFO] [stderr] 96 | | false => '-', [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if (self.permissions / (2u32.pow(8 - position))) % 2 == 1 { permission_type } else { '-' }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | format!("{}", "./") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"./".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | format!("{}", args[1]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `args[1].to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.50s [INFO] running `"docker" "inspect" "55e92e4748ec195d7d489df692a2877843698214ad13aa3f3c0ff71b6a47594b"` [INFO] running `"docker" "rm" "-f" "55e92e4748ec195d7d489df692a2877843698214ad13aa3f3c0ff71b6a47594b"` [INFO] [stdout] 55e92e4748ec195d7d489df692a2877843698214ad13aa3f3c0ff71b6a47594b