[INFO] updating cached repository moon-project/refl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/moon-project/refl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/moon-project/refl" "work/ex/clippy-test-run/sources/stable/gh/moon-project/refl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/moon-project/refl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/moon-project/refl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moon-project/refl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moon-project/refl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bd3c2362acd4353227128b3b94f99331c36daac9 [INFO] sha for GitHub repo moon-project/refl: bd3c2362acd4353227128b3b94f99331c36daac9 [INFO] validating manifest of moon-project/refl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of moon-project/refl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing moon-project/refl [INFO] finished frobbing moon-project/refl [INFO] frobbed toml for moon-project/refl written to work/ex/clippy-test-run/sources/stable/gh/moon-project/refl/Cargo.toml [INFO] started frobbing moon-project/refl [INFO] finished frobbing moon-project/refl [INFO] frobbed toml for moon-project/refl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/moon-project/refl/Cargo.toml [INFO] crate moon-project/refl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting moon-project/refl against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/moon-project/refl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4fe693451cca95c028a743e717825b71e27ffb898ca73cf374244c8446c7e868 [INFO] running `"docker" "start" "-a" "4fe693451cca95c028a743e717825b71e27ffb898ca73cf374244c8446c7e868"` [INFO] [stderr] Checking tempfile v3.0.2 [INFO] [stderr] Checking x11-dl v2.17.5 [INFO] [stderr] Compiling glutin v0.15.0 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.13.1 [INFO] [stderr] Checking refl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | const VS_SRC: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | const FS_SRC: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | const VS_SRC: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | const FS_SRC: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:14:33 [INFO] [stderr] | [INFO] [stderr] 14 | duration.as_secs() as f64 + duration.subsec_nanos() as f64 * 1e-9 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `y * w * 4 + x * 4` [INFO] [stderr] --> src/main.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | buffer[(y * w * 4 + x * 4 + 0) as usize] = (x * 256 / w) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | / match event { [INFO] [stderr] 120 | | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] 121 | | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 122 | | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] ... | [INFO] [stderr] 125 | | _ => () [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | if let glutin::Event::WindowEvent{ event, .. } = event { match event { [INFO] [stderr] 120 | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 121 | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] 122 | _ => () [INFO] [stderr] 123 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:14:33 [INFO] [stderr] | [INFO] [stderr] 14 | duration.as_secs() as f64 + duration.subsec_nanos() as f64 * 1e-9 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `y * w * 4 + x * 4` [INFO] [stderr] --> src/main.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | buffer[(y * w * 4 + x * 4 + 0) as usize] = (x * 256 / w) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | / match event { [INFO] [stderr] 120 | | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] 121 | | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 122 | | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] ... | [INFO] [stderr] 125 | | _ => () [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | if let glutin::Event::WindowEvent{ event, .. } = event { match event { [INFO] [stderr] 120 | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 121 | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] 122 | _ => () [INFO] [stderr] 123 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.96s [INFO] running `"docker" "inspect" "4fe693451cca95c028a743e717825b71e27ffb898ca73cf374244c8446c7e868"` [INFO] running `"docker" "rm" "-f" "4fe693451cca95c028a743e717825b71e27ffb898ca73cf374244c8446c7e868"` [INFO] [stdout] 4fe693451cca95c028a743e717825b71e27ffb898ca73cf374244c8446c7e868