[INFO] updating cached repository mookid/rust-adventofcode2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mookid/rust-adventofcode2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mookid/rust-adventofcode2017" "work/ex/clippy-test-run/sources/stable/gh/mookid/rust-adventofcode2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mookid/rust-adventofcode2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mookid/rust-adventofcode2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mookid/rust-adventofcode2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mookid/rust-adventofcode2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6b8300aacb3f428811d0d7aec97f699039a07fe3 [INFO] sha for GitHub repo mookid/rust-adventofcode2017: 6b8300aacb3f428811d0d7aec97f699039a07fe3 [INFO] validating manifest of mookid/rust-adventofcode2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mookid/rust-adventofcode2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mookid/rust-adventofcode2017 [INFO] finished frobbing mookid/rust-adventofcode2017 [INFO] frobbed toml for mookid/rust-adventofcode2017 written to work/ex/clippy-test-run/sources/stable/gh/mookid/rust-adventofcode2017/Cargo.toml [INFO] started frobbing mookid/rust-adventofcode2017 [INFO] finished frobbing mookid/rust-adventofcode2017 [INFO] frobbed toml for mookid/rust-adventofcode2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mookid/rust-adventofcode2017/Cargo.toml [INFO] crate mookid/rust-adventofcode2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mookid/rust-adventofcode2017 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mookid/rust-adventofcode2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8da5afa6f2044317b00fd3832a5bceba3614860e85d69cf60e7864ba6f798ec8 [INFO] running `"docker" "start" "-a" "8da5afa6f2044317b00fd3832a5bceba3614860e85d69cf60e7864ba6f798ec8"` [INFO] [stderr] Checking advent-of-code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day8-registers.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | const CMP_TABLE : [(&'static str, Cmp); 6] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day8-registers.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | const OP_TABLE : [(&'static str, Op); 2] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day8-registers.rs:59:34 [INFO] [stderr] | [INFO] [stderr] 59 | fn largest_register_value(input: &Vec, safe: bool) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/day14-disk-defragmentation.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | / if to_2d(y).is_some() { [INFO] [stderr] 70 | | if !visited[y] && grid[y] == b'1' { [INFO] [stderr] 71 | | todo.extend_from_slice(&neighbours(y)); [INFO] [stderr] 72 | | visited[y] = true; [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 69 | if to_2d(y).is_some() && !visited[y] && grid[y] == b'1' { [INFO] [stderr] 70 | todo.extend_from_slice(&neighbours(y)); [INFO] [stderr] 71 | visited[y] = true; [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day15-dueling-generators.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | factor: factor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `factor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/day14-disk-defragmentation.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | .unwrap_or(vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/day7-recursive-circus.rs:78:30 [INFO] [stderr] | [INFO] [stderr] 78 | T {name: name2, nb: _, value: value2,}) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `T { name: name2, value: value2, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day10-knot-hash.rs:4:36 [INFO] [stderr] | [INFO] [stderr] 4 | let input = input.trim().split(",").map(lib::parse_i32); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2-corruption-checksum.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | fn solve_line2(numbers: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `numbers` [INFO] [stderr] --> src/day2-corruption-checksum.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | for j in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for (j, ) in numbers.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/day2-corruption-checksum.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | while let Some(x) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for x in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day15-dueling-generators.rs:26:37 [INFO] [stderr] | [INFO] [stderr] 26 | let cur = ((factor * cur) % 2147483647) as i32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/day7-recursive-circus.rs:19:58 [INFO] [stderr] | [INFO] [stderr] 19 | let mut iter = line.split(is_delimiter).filter(|str| 0 < str.len()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day7-recursive-circus.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | fn find_root<'a>(items : &'a Vec) -> Option<&'a str> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day7-recursive-circus.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | fn find_by_name<'a>(items : &'a Vec, x: &str) -> Option<&'a Item<'a>> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day7-recursive-circus.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | items : &'a Vec, name: &'a str) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day7-recursive-circus.rs:62:33 [INFO] [stderr] | [INFO] [stderr] 62 | fn find_adjusted_weight(items : &Vec, root: &str) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day16-permutation-promenade.rs:112:36 [INFO] [stderr] | [INFO] [stderr] 112 | let input = input.trim().split(",").map(|line| parse_line(line).unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/day3-spiral-memory.rs:20:55 [INFO] [stderr] | [INFO] [stderr] 20 | CornerKind::DL, CornerKind::DR].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/day3-spiral-memory.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / for i in 2.. { [INFO] [stderr] 65 | | let cur = manhattan_from_linear(i); [INFO] [stderr] 66 | | let (x,y) = cur; [INFO] [stderr] 67 | | let res = [(x-1, y-1), (x-1, y+0), (x-1, y+1), [INFO] [stderr] ... | [INFO] [stderr] 74 | | tbl.insert(cur, res); [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/day3-spiral-memory.rs:70:14 [INFO] [stderr] | [INFO] [stderr] 70 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `y` [INFO] [stderr] --> src/day3-spiral-memory.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | let res = [(x-1, y-1), (x-1, y+0), (x-1, y+1), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/day3-spiral-memory.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | (x+0, y-1), (x+0, y+1), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/day3-spiral-memory.rs:68:33 [INFO] [stderr] | [INFO] [stderr] 68 | (x+0, y-1), (x+0, y+1), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `y` [INFO] [stderr] --> src/day3-spiral-memory.rs:69:38 [INFO] [stderr] | [INFO] [stderr] 69 | (x+1, y-1), (x+1, y+0), (x+1, y+1)] [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/day3-spiral-memory.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | n < res && return res; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/day3-spiral-memory.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | n < res && return res; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `if n < res { return res; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::short_circuit_statement)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/day3-spiral-memory.rs:73:20 [INFO] [stderr] | [INFO] [stderr] 73 | n < res && return res; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::diverging_sub_expression)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent-of-code`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day22-virus.rs:26:39 [INFO] [stderr] | [INFO] [stderr] 26 | println!("{}", nb_infections(map, 10000000, true)); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day8-registers.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | const CMP_TABLE : [(&'static str, Cmp); 6] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day8-registers.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | const OP_TABLE : [(&'static str, Op); 2] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day5-twisty-trampolines.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | fn solve(ns : &Vec, complex_jump: bool) -> i32 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 11 | fn solve(ns : &[i32], complex_jump: bool) -> i32 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `ns.clone()` to [INFO] [stderr] | [INFO] [stderr] 12 | let mut ns = ns.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day8-registers.rs:59:34 [INFO] [stderr] | [INFO] [stderr] 59 | fn largest_register_value(input: &Vec, safe: bool) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/day22-virus.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | / match ch { [INFO] [stderr] 69 | | &b'.' => (), [INFO] [stderr] 70 | | &b'#' => v.push((i as i32, j as i32)), [INFO] [stderr] 71 | | &c => panic!("unexpected character: {}", c), [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 68 | match *ch { [INFO] [stderr] 69 | b'.' => (), [INFO] [stderr] 70 | b'#' => v.push((i as i32, j as i32)), [INFO] [stderr] 71 | c => panic!("unexpected character: {}", c), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day17-spinlock.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | find_after((1..nb_reps+1).fold(new(), |st, i| insert(advance(st, nsteps), i)), target) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(1..=nb_reps)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day21-fractal.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | for (i, row) in str.split("/").enumerate() { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day6-memory-reallocation.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | for i in idx_max + 1 .. idx_max + k + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `idx_max + 1..=idx_max + k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day6-memory-reallocation.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | fn solve(blocks : &Vec, loop_size: bool) -> Option { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 13 | fn solve(blocks : &[i32], loop_size: bool) -> Option { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `blocks.clone()` to [INFO] [stderr] | [INFO] [stderr] 14 | let mut blocks = blocks.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/day6-memory-reallocation.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match tbl.insert(blocks.clone(), i) { [INFO] [stderr] 18 | | Some(first_encounter) => [INFO] [stderr] 19 | | return Some(if loop_size { [INFO] [stderr] 20 | | i - first_encounter [INFO] [stderr] ... | [INFO] [stderr] 24 | | None => (), [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | if let Some(first_encounter) = tbl.insert(blocks.clone(), i) { return Some(if loop_size { [INFO] [stderr] 18 | i - first_encounter [INFO] [stderr] 19 | } else { [INFO] [stderr] 20 | i [INFO] [stderr] 21 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(("parse_from: ".to_owned() + &input.to_owned()).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = ("parse_from: ".to_owned() + &input.to_owned()).as_str(); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:51 [INFO] [stderr] | [INFO] [stderr] 64 | let mut input = input.iter().cloned().map(|b| b as i32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day16-permutation-promenade.rs:112:36 [INFO] [stderr] | [INFO] [stderr] 112 | let input = input.trim().split(",").map(|line| parse_line(line).unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "8da5afa6f2044317b00fd3832a5bceba3614860e85d69cf60e7864ba6f798ec8"` [INFO] running `"docker" "rm" "-f" "8da5afa6f2044317b00fd3832a5bceba3614860e85d69cf60e7864ba6f798ec8"` [INFO] [stdout] 8da5afa6f2044317b00fd3832a5bceba3614860e85d69cf60e7864ba6f798ec8