[INFO] updating cached repository monjohn/prufen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/monjohn/prufen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/monjohn/prufen" "work/ex/clippy-test-run/sources/stable/gh/monjohn/prufen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/monjohn/prufen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/monjohn/prufen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/monjohn/prufen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/monjohn/prufen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dd8402a6b51cb53a3ad6827fd9944c5894f647a8 [INFO] sha for GitHub repo monjohn/prufen: dd8402a6b51cb53a3ad6827fd9944c5894f647a8 [INFO] validating manifest of monjohn/prufen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of monjohn/prufen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing monjohn/prufen [INFO] finished frobbing monjohn/prufen [INFO] frobbed toml for monjohn/prufen written to work/ex/clippy-test-run/sources/stable/gh/monjohn/prufen/Cargo.toml [INFO] started frobbing monjohn/prufen [INFO] finished frobbing monjohn/prufen [INFO] frobbed toml for monjohn/prufen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/monjohn/prufen/Cargo.toml [INFO] crate monjohn/prufen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting monjohn/prufen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/monjohn/prufen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f998fe98c697a84accbf45ce798613fa6f0cb7f118df051cb496fcf3f8846cc3 [INFO] running `"docker" "start" "-a" "f998fe98c697a84accbf45ce798613fa6f0cb7f118df051cb496fcf3f8846cc3"` [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking prufen v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:100:41 [INFO] [stderr] | [INFO] [stderr] 100 | fn print_options(words: &Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:100:41 [INFO] [stderr] | [INFO] [stderr] 100 | fn print_options(words: &Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | fn only_nouns(word_pairs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[WordPair]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pairs.map(|noun| noun.clone()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `pairs.cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:31:27 [INFO] [stderr] | [INFO] [stderr] 31 | fn only_verbs(word_pairs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[WordPair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pairs.map(|noun| noun.clone()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `pairs.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:72:22 [INFO] [stderr] | [INFO] [stderr] 72 | fn pick_one(coll: &Vec) -> T [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:79:33 [INFO] [stderr] | [INFO] [stderr] 79 | fn select_nouns_or_verbs(words: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[WordPair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / match random_pick { [INFO] [stderr] 82 | | true => only_verbs(words), [INFO] [stderr] 83 | | false => only_nouns(words), [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if random_pick { only_verbs(words) } else { only_nouns(words) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:87:23 [INFO] [stderr] | [INFO] [stderr] 87 | fn select_four(words: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 87 | fn select_four(words: &[WordPair]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] help: change `words.clone()` to [INFO] [stderr] | [INFO] [stderr] 89 | let mut copied = words.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:100:25 [INFO] [stderr] | [INFO] [stderr] 100 | fn print_options(words: &Vec) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[WordPair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:107:19 [INFO] [stderr] | [INFO] [stderr] 107 | fn guess(options: &Vec, answer: &String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[WordPair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:107:43 [INFO] [stderr] | [INFO] [stderr] 107 | fn guess(options: &Vec, answer: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | let ref german = options[(guess_num - 1) as usize].german; [INFO] [stderr] | ----^^^^^^^^^^-------------------------------------------- help: try: `let german = &options[(guess_num - 1) as usize].german;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:144:20 [INFO] [stderr] | [INFO] [stderr] 144 | let keys = root_keys.map(|noun| noun.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `root_keys.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:151:12 [INFO] [stderr] | [INFO] [stderr] 151 | if options.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `options.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | / match guess(&options, &word_pair.german) { [INFO] [stderr] 164 | | true => { [INFO] [stderr] 165 | | println!("{}", Green.paint("You are correct!")); [INFO] [stderr] 166 | | break; [INFO] [stderr] ... | [INFO] [stderr] 171 | | } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 163 | if guess(&options, &word_pair.german) { [INFO] [stderr] 164 | println!("{}", Green.paint("You are correct!")); [INFO] [stderr] 165 | break; [INFO] [stderr] 166 | } else { [INFO] [stderr] 167 | println!("{}", Red.paint("That is incorrect!")); [INFO] [stderr] 168 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | fn only_nouns(word_pairs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[WordPair]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pairs.map(|noun| noun.clone()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `pairs.cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:31:27 [INFO] [stderr] | [INFO] [stderr] 31 | fn only_verbs(word_pairs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[WordPair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pairs.map(|noun| noun.clone()).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `pairs.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:72:22 [INFO] [stderr] | [INFO] [stderr] 72 | fn pick_one(coll: &Vec) -> T [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:79:33 [INFO] [stderr] | [INFO] [stderr] 79 | fn select_nouns_or_verbs(words: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[WordPair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / match random_pick { [INFO] [stderr] 82 | | true => only_verbs(words), [INFO] [stderr] 83 | | false => only_nouns(words), [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if random_pick { only_verbs(words) } else { only_nouns(words) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:87:23 [INFO] [stderr] | [INFO] [stderr] 87 | fn select_four(words: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 87 | fn select_four(words: &[WordPair]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] help: change `words.clone()` to [INFO] [stderr] | [INFO] [stderr] 89 | let mut copied = words.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:100:25 [INFO] [stderr] | [INFO] [stderr] 100 | fn print_options(words: &Vec) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[WordPair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:107:19 [INFO] [stderr] | [INFO] [stderr] 107 | fn guess(options: &Vec, answer: &String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[WordPair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:107:43 [INFO] [stderr] | [INFO] [stderr] 107 | fn guess(options: &Vec, answer: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | let ref german = options[(guess_num - 1) as usize].german; [INFO] [stderr] | ----^^^^^^^^^^-------------------------------------------- help: try: `let german = &options[(guess_num - 1) as usize].german;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:144:20 [INFO] [stderr] | [INFO] [stderr] 144 | let keys = root_keys.map(|noun| noun.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `root_keys.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:151:12 [INFO] [stderr] | [INFO] [stderr] 151 | if options.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `options.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | / match guess(&options, &word_pair.german) { [INFO] [stderr] 164 | | true => { [INFO] [stderr] 165 | | println!("{}", Green.paint("You are correct!")); [INFO] [stderr] 166 | | break; [INFO] [stderr] ... | [INFO] [stderr] 171 | | } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 163 | if guess(&options, &word_pair.german) { [INFO] [stderr] 164 | println!("{}", Green.paint("You are correct!")); [INFO] [stderr] 165 | break; [INFO] [stderr] 166 | } else { [INFO] [stderr] 167 | println!("{}", Red.paint("That is incorrect!")); [INFO] [stderr] 168 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.16s [INFO] running `"docker" "inspect" "f998fe98c697a84accbf45ce798613fa6f0cb7f118df051cb496fcf3f8846cc3"` [INFO] running `"docker" "rm" "-f" "f998fe98c697a84accbf45ce798613fa6f0cb7f118df051cb496fcf3f8846cc3"` [INFO] [stdout] f998fe98c697a84accbf45ce798613fa6f0cb7f118df051cb496fcf3f8846cc3