[INFO] updating cached repository mokomull/adventofcode_2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mokomull/adventofcode_2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mokomull/adventofcode_2018" "work/ex/clippy-test-run/sources/stable/gh/mokomull/adventofcode_2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mokomull/adventofcode_2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mokomull/adventofcode_2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mokomull/adventofcode_2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mokomull/adventofcode_2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 764bdc3b0b39b86d774374de1da9736c222e5bed [INFO] sha for GitHub repo mokomull/adventofcode_2018: 764bdc3b0b39b86d774374de1da9736c222e5bed [INFO] validating manifest of mokomull/adventofcode_2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mokomull/adventofcode_2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mokomull/adventofcode_2018 [INFO] finished frobbing mokomull/adventofcode_2018 [INFO] frobbed toml for mokomull/adventofcode_2018 written to work/ex/clippy-test-run/sources/stable/gh/mokomull/adventofcode_2018/Cargo.toml [INFO] started frobbing mokomull/adventofcode_2018 [INFO] finished frobbing mokomull/adventofcode_2018 [INFO] frobbed toml for mokomull/adventofcode_2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mokomull/adventofcode_2018/Cargo.toml [INFO] crate mokomull/adventofcode_2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mokomull/adventofcode_2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mokomull/adventofcode_2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d445c1ce0b74a5ec8fbeab16ca32cdbe595f97245acc279022c587ae8b2843aa [INFO] running `"docker" "start" "-a" "d445c1ce0b74a5ec8fbeab16ca32cdbe595f97245acc279022c587ae8b2843aa"` [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking adventofcode_2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `y` is only used to index `board`. [INFO] [stderr] --> src/bin/day_06.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | for y in 0..=max_y { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 13 | for in board.iter_mut().take(max_y + 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/day_06.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | if distances.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!distances.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day_06.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | fn largest_area(placed: &Vec>>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day_06.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | l.split(",").nth(0).unwrap().parse::().unwrap(), [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day_06.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | l.split(" ").nth(1).unwrap().parse::().unwrap(), [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is only used to index `board`. [INFO] [stderr] --> src/bin/day_06.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | for y in 0..=max_y { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 13 | for in board.iter_mut().take(max_y + 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/day_06.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | if distances.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!distances.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day_06.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | fn largest_area(placed: &Vec>>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day_06.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | l.split(",").nth(0).unwrap().parse::().unwrap(), [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day_06.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | l.split(" ").nth(1).unwrap().parse::().unwrap(), [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.25s [INFO] running `"docker" "inspect" "d445c1ce0b74a5ec8fbeab16ca32cdbe595f97245acc279022c587ae8b2843aa"` [INFO] running `"docker" "rm" "-f" "d445c1ce0b74a5ec8fbeab16ca32cdbe595f97245acc279022c587ae8b2843aa"` [INFO] [stdout] d445c1ce0b74a5ec8fbeab16ca32cdbe595f97245acc279022c587ae8b2843aa