[INFO] updating cached repository mohd-akram/sw [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mohd-akram/sw [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mohd-akram/sw" "work/ex/clippy-test-run/sources/stable/gh/mohd-akram/sw"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mohd-akram/sw'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mohd-akram/sw" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mohd-akram/sw"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mohd-akram/sw'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 28a59e8a6825db322018c0dcd9a3610f903ac2af [INFO] sha for GitHub repo mohd-akram/sw: 28a59e8a6825db322018c0dcd9a3610f903ac2af [INFO] validating manifest of mohd-akram/sw on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mohd-akram/sw on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mohd-akram/sw [INFO] finished frobbing mohd-akram/sw [INFO] frobbed toml for mohd-akram/sw written to work/ex/clippy-test-run/sources/stable/gh/mohd-akram/sw/Cargo.toml [INFO] started frobbing mohd-akram/sw [INFO] finished frobbing mohd-akram/sw [INFO] frobbed toml for mohd-akram/sw written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mohd-akram/sw/Cargo.toml [INFO] crate mohd-akram/sw has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mohd-akram/sw against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mohd-akram/sw:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 980b2ef538590cc251933f812bde40de991a17b7820134535eb481e117fa3400 [INFO] running `"docker" "start" "-a" "980b2ef538590cc251933f812bde40de991a17b7820134535eb481e117fa3400"` [INFO] [stderr] Checking appdirs v0.2.0 [INFO] [stderr] Compiling sw v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | Ok(Time {label: label, split: split_time, lap: lap_time}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | Ok(Time {label: label, split: split_time, lap: lap_time}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:108:25 [INFO] [stderr] | [INFO] [stderr] 108 | StoredTime {label: label, nanoseconds: nanoseconds} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:108:39 [INFO] [stderr] | [INFO] [stderr] 108 | StoredTime {label: label, nanoseconds: nanoseconds} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nanoseconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:108:25 [INFO] [stderr] | [INFO] [stderr] 108 | StoredTime {label: label, nanoseconds: nanoseconds} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:108:39 [INFO] [stderr] | [INFO] [stderr] 108 | StoredTime {label: label, nanoseconds: nanoseconds} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nanoseconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | / match sub_m.is_present("lap") { [INFO] [stderr] 177 | | true => Ok(Some(format!("{}", time.lap))), [INFO] [stderr] 178 | | false => Ok(Some(format!("{}", time.split))) [INFO] [stderr] 179 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if sub_m.is_present("lap") { Ok(Some(format!("{}", time.lap))) } else { Ok(Some(format!("{}", time.split))) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:204:30 [INFO] [stderr] | [INFO] [stderr] 204 | fs::create_dir_all(&dir).expect( [INFO] [stderr] | ______________________________^ [INFO] [stderr] 205 | | &format!("Could not create directory {}", dir.to_str().unwrap()) [INFO] [stderr] 206 | | ); [INFO] [stderr] | |_____^ help: try this: `unwrap_or_else(|_| panic!("Could not create directory {}", dir.to_str().unwrap()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:244:18 [INFO] [stderr] | [INFO] [stderr] 244 | Ok(s) => match s { [INFO] [stderr] | __________________^ [INFO] [stderr] 245 | | Some(s) => match matches.is_present("stdout") { [INFO] [stderr] 246 | | true => println!("{}", s), [INFO] [stderr] 247 | | false => eprintln!("{}", s), [INFO] [stderr] 248 | | }, [INFO] [stderr] 249 | | None => {} [INFO] [stderr] 250 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 244 | Ok(s) => if let Some(s) = s { match matches.is_present("stdout") { [INFO] [stderr] 245 | true => println!("{}", s), [INFO] [stderr] 246 | false => eprintln!("{}", s), [INFO] [stderr] 247 | } }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:245:24 [INFO] [stderr] | [INFO] [stderr] 245 | Some(s) => match matches.is_present("stdout") { [INFO] [stderr] | ________________________^ [INFO] [stderr] 246 | | true => println!("{}", s), [INFO] [stderr] 247 | | false => eprintln!("{}", s), [INFO] [stderr] 248 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if matches.is_present("stdout") { println!("{}", s) } else { eprintln!("{}", s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | / match sub_m.is_present("lap") { [INFO] [stderr] 177 | | true => Ok(Some(format!("{}", time.lap))), [INFO] [stderr] 178 | | false => Ok(Some(format!("{}", time.split))) [INFO] [stderr] 179 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if sub_m.is_present("lap") { Ok(Some(format!("{}", time.lap))) } else { Ok(Some(format!("{}", time.split))) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:204:30 [INFO] [stderr] | [INFO] [stderr] 204 | fs::create_dir_all(&dir).expect( [INFO] [stderr] | ______________________________^ [INFO] [stderr] 205 | | &format!("Could not create directory {}", dir.to_str().unwrap()) [INFO] [stderr] 206 | | ); [INFO] [stderr] | |_____^ help: try this: `unwrap_or_else(|_| panic!("Could not create directory {}", dir.to_str().unwrap()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:244:18 [INFO] [stderr] | [INFO] [stderr] 244 | Ok(s) => match s { [INFO] [stderr] | __________________^ [INFO] [stderr] 245 | | Some(s) => match matches.is_present("stdout") { [INFO] [stderr] 246 | | true => println!("{}", s), [INFO] [stderr] 247 | | false => eprintln!("{}", s), [INFO] [stderr] 248 | | }, [INFO] [stderr] 249 | | None => {} [INFO] [stderr] 250 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 244 | Ok(s) => if let Some(s) = s { match matches.is_present("stdout") { [INFO] [stderr] 245 | true => println!("{}", s), [INFO] [stderr] 246 | false => eprintln!("{}", s), [INFO] [stderr] 247 | } }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:245:24 [INFO] [stderr] | [INFO] [stderr] 245 | Some(s) => match matches.is_present("stdout") { [INFO] [stderr] | ________________________^ [INFO] [stderr] 246 | | true => println!("{}", s), [INFO] [stderr] 247 | | false => eprintln!("{}", s), [INFO] [stderr] 248 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if matches.is_present("stdout") { println!("{}", s) } else { eprintln!("{}", s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.24s [INFO] running `"docker" "inspect" "980b2ef538590cc251933f812bde40de991a17b7820134535eb481e117fa3400"` [INFO] running `"docker" "rm" "-f" "980b2ef538590cc251933f812bde40de991a17b7820134535eb481e117fa3400"` [INFO] [stdout] 980b2ef538590cc251933f812bde40de991a17b7820134535eb481e117fa3400