[INFO] updating cached repository mogrein/RSA_parity_oracle
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mogrein/RSA_parity_oracle
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mogrein/RSA_parity_oracle" "work/ex/clippy-test-run/sources/stable/gh/mogrein/RSA_parity_oracle"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mogrein/RSA_parity_oracle'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mogrein/RSA_parity_oracle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mogrein/RSA_parity_oracle"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mogrein/RSA_parity_oracle'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e51b0e8c04dc9e05ba7f838b770929ef2ef420e8
[INFO] sha for GitHub repo mogrein/RSA_parity_oracle: e51b0e8c04dc9e05ba7f838b770929ef2ef420e8
[INFO] validating manifest of mogrein/RSA_parity_oracle on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mogrein/RSA_parity_oracle on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mogrein/RSA_parity_oracle
[INFO] finished frobbing mogrein/RSA_parity_oracle
[INFO] frobbed toml for mogrein/RSA_parity_oracle written to work/ex/clippy-test-run/sources/stable/gh/mogrein/RSA_parity_oracle/Cargo.toml
[INFO] started frobbing mogrein/RSA_parity_oracle
[INFO] finished frobbing mogrein/RSA_parity_oracle
[INFO] frobbed toml for mogrein/RSA_parity_oracle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mogrein/RSA_parity_oracle/Cargo.toml
[INFO] crate mogrein/RSA_parity_oracle has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mogrein/RSA_parity_oracle against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mogrein/RSA_parity_oracle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c9806cc7a95b1b3ae7d71d12d812e52f4632bfbf8a91a17aa00570ed4fd1b4ca
[INFO] running `"docker" "start" "-a" "c9806cc7a95b1b3ae7d71d12d812e52f4632bfbf8a91a17aa00570ed4fd1b4ca"`
[INFO] [stderr]    Compiling actix-web v0.7.4
[INFO] [stderr]    Compiling brotli-sys v0.3.2
[INFO] [stderr]    Compiling miniz-sys v0.1.10
[INFO] [stderr]    Compiling ring v0.13.2
[INFO] [stderr]    Compiling rand v0.5.5
[INFO] [stderr]    Compiling openssl v0.10.11
[INFO] [stderr]     Checking serde_json v1.0.26
[INFO] [stderr]    Compiling phf_shared v0.7.23
[INFO] [stderr]     Checking backtrace v0.2.3
[INFO] [stderr]    Compiling syn v0.14.9
[INFO] [stderr]     Checking serde_urlencoded v0.5.3
[INFO] [stderr]     Checking tokio-reactor v0.1.5
[INFO] [stderr]     Checking crossbeam-channel v0.2.4
[INFO] [stderr]     Checking phf v0.7.23
[INFO] [stderr]     Checking error-chain v0.1.12
[INFO] [stderr]     Checking tokio-udp v0.1.2
[INFO] [stderr]     Checking tokio-tcp v0.1.1
[INFO] [stderr]     Checking tokio-uds v0.2.1
[INFO] [stderr]     Checking tokio-signal v0.2.5
[INFO] [stderr]    Compiling phf_generator v0.7.23
[INFO] [stderr]     Checking flate2 v1.0.2
[INFO] [stderr]     Checking trust-dns-proto v0.4.0
[INFO] [stderr]     Checking tokio v0.1.8
[INFO] [stderr]    Compiling phf_codegen v0.7.23
[INFO] [stderr]    Compiling mime_guess v2.0.0-alpha.6
[INFO] [stderr]     Checking tokio-openssl v0.2.1
[INFO] [stderr]     Checking cookie v0.11.0
[INFO] [stderr]     Checking brotli2 v0.3.2
[INFO] [stderr]     Checking trust-dns-resolver v0.9.1
[INFO] [stderr]    Compiling synstructure v0.9.0
[INFO] [stderr]    Compiling actix_derive v0.3.0
[INFO] [stderr]    Compiling serde_derive v1.0.76
[INFO] [stderr]    Compiling failure_derive v0.1.2
[INFO] [stderr]     Checking failure v0.1.2
[INFO] [stderr]     Checking actix v0.7.4
[INFO] [stderr]     Checking padding_oracle v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/crypto.rs:23:27
[INFO] [stderr]    |
[INFO] [stderr] 23 |         RSACryptoService {rsa: rsa, pad: Padding::NONE}
[INFO] [stderr]    |                           ^^^^^^^^ help: replace it with: `rsa`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:42:23
[INFO] [stderr]    |
[INFO] [stderr] 42 |     Ok(Json(SecretMsg{secret: secret}))
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^ help: replace it with: `secret`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:53:32
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return Ok(Json(OracleRsp { parity: parity }));
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^ help: replace it with: `parity`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/crypto.rs:23:27
[INFO] [stderr]    |
[INFO] [stderr] 23 |         RSACryptoService {rsa: rsa, pad: Padding::NONE}
[INFO] [stderr]    |                           ^^^^^^^^ help: replace it with: `rsa`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:42:23
[INFO] [stderr]    |
[INFO] [stderr] 42 |     Ok(Json(SecretMsg{secret: secret}))
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^ help: replace it with: `secret`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:53:32
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return Ok(Json(OracleRsp { parity: parity }));
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^ help: replace it with: `parity`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return Ok(Json(OracleRsp { parity: parity }));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Json(OracleRsp { parity: parity }))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     pubkey
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:57:18
[INFO] [stderr]    |
[INFO] [stderr] 57 |     let pubkey = CRYPTO_SERVICE.pubkey_pem();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return Ok(Json(OracleRsp { parity: parity }));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Json(OracleRsp { parity: parity }))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     pubkey
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:57:18
[INFO] [stderr]    |
[INFO] [stderr] 57 |     let pubkey = CRYPTO_SERVICE.pubkey_pem();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:35:40
[INFO] [stderr]    |
[INFO] [stderr] 35 |     let plaintext = env::var("SECRET").unwrap_or(String::from("SECRETSECRETSECRET"));
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("SECRETSECRETSECRET"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:35:40
[INFO] [stderr]    |
[INFO] [stderr] 35 |     let plaintext = env::var("SECRET").unwrap_or(String::from("SECRETSECRETSECRET"));
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("SECRETSECRETSECRET"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 08s
[INFO] running `"docker" "inspect" "c9806cc7a95b1b3ae7d71d12d812e52f4632bfbf8a91a17aa00570ed4fd1b4ca"`
[INFO] running `"docker" "rm" "-f" "c9806cc7a95b1b3ae7d71d12d812e52f4632bfbf8a91a17aa00570ed4fd1b4ca"`
[INFO] [stdout] c9806cc7a95b1b3ae7d71d12d812e52f4632bfbf8a91a17aa00570ed4fd1b4ca