[INFO] updating cached repository mockersf/beast-glatisant [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mockersf/beast-glatisant [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mockersf/beast-glatisant" "work/ex/clippy-test-run/sources/stable/gh/mockersf/beast-glatisant"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mockersf/beast-glatisant'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mockersf/beast-glatisant" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mockersf/beast-glatisant"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mockersf/beast-glatisant'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 89203d6f6021bef7ffe02da2828983a01ad96cdc [INFO] sha for GitHub repo mockersf/beast-glatisant: 89203d6f6021bef7ffe02da2828983a01ad96cdc [INFO] validating manifest of mockersf/beast-glatisant on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mockersf/beast-glatisant on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mockersf/beast-glatisant [INFO] finished frobbing mockersf/beast-glatisant [INFO] frobbed toml for mockersf/beast-glatisant written to work/ex/clippy-test-run/sources/stable/gh/mockersf/beast-glatisant/Cargo.toml [INFO] started frobbing mockersf/beast-glatisant [INFO] finished frobbing mockersf/beast-glatisant [INFO] frobbed toml for mockersf/beast-glatisant written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mockersf/beast-glatisant/Cargo.toml [INFO] crate mockersf/beast-glatisant has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mockersf/beast-glatisant against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mockersf/beast-glatisant:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dfba0908f9128448384dac220ba9618a30a2c0ab39079d24d4c28f8936426cfd [INFO] running `"docker" "start" "-a" "dfba0908f9128448384dac220ba9618a30a2c0ab39079d24d4c28f8936426cfd"` [INFO] [stderr] Compiling proc-macro2 v0.4.13 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking socket2 v0.3.5 [INFO] [stderr] Checking encoding_rs v0.8.6 [INFO] [stderr] Compiling actix-web v0.7.8 [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Checking tokio-executor v0.1.2 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking linkify v0.3.1 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking lock_api v0.1.3 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking http v0.1.13 [INFO] [stderr] Checking tokio-timer v0.2.5 [INFO] [stderr] Checking tokio-current-thread v0.1.1 [INFO] [stderr] Checking regex v1.0.3 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking miniz-sys v0.1.10 [INFO] [stderr] Checking brotli-sys v0.3.2 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking serde_json v1.0.27 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking env_logger v0.6.0 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Checking h2 v0.1.9 [INFO] [stderr] Checking comrak v0.3.1 [INFO] [stderr] Checking crossbeam-channel v0.2.4 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-signal v0.2.2 [INFO] [stderr] Compiling syn v0.15.3 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking trust-dns-proto v0.4.3 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Compiling synstructure v0.10.0 [INFO] [stderr] Compiling structopt-derive v0.2.13 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling actix_derive v0.3.0 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking structopt v0.2.13 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking actix v0.7.3 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking beast_glatisant v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/github/mod.rs:30:33 [INFO] [stderr] | [INFO] [stderr] 30 | etag_cache: &'static RwLock>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 27 | pub fn get_object( [INFO] [stderr] 28 | url: &str, [INFO] [stderr] 29 | token: Option, [INFO] [stderr] 30 | etag_cache: &'static RwLock>, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/web.rs:132:25 [INFO] [stderr] | [INFO] [stderr] 132 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/web.rs:134:25 [INFO] [stderr] | [INFO] [stderr] 134 | clippy: clippy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `clippy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/web.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/web.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | clippy: clippy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `clippy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/web.rs:132:25 [INFO] [stderr] | [INFO] [stderr] 132 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/web.rs:134:25 [INFO] [stderr] | [INFO] [stderr] 134 | clippy: clippy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `clippy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/web.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/web.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | clippy: clippy, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `clippy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/github/mod.rs:30:33 [INFO] [stderr] | [INFO] [stderr] 30 | etag_cache: &'static RwLock>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 27 | pub fn get_object( [INFO] [stderr] 28 | url: &str, [INFO] [stderr] 29 | token: Option, [INFO] [stderr] 30 | etag_cache: &'static RwLock>, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/web.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/web.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/web.rs:160:34 [INFO] [stderr] | [INFO] [stderr] 160 | let update = comm.last_update.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `comm.last_update` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/web.rs:183:38 [INFO] [stderr] | [INFO] [stderr] 183 | let updated_at = updated_at.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*updated_at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/web.rs:252:19 [INFO] [stderr] | [INFO] [stderr] 252 | ).map(|v| Some(v)), [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/web.rs:160:34 [INFO] [stderr] | [INFO] [stderr] 160 | let update = comm.last_update.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `comm.last_update` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/web.rs:183:38 [INFO] [stderr] | [INFO] [stderr] 183 | let updated_at = updated_at.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*updated_at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/web.rs:252:19 [INFO] [stderr] | [INFO] [stderr] 252 | ).map(|v| Some(v)), [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 09s [INFO] running `"docker" "inspect" "dfba0908f9128448384dac220ba9618a30a2c0ab39079d24d4c28f8936426cfd"` [INFO] running `"docker" "rm" "-f" "dfba0908f9128448384dac220ba9618a30a2c0ab39079d24d4c28f8936426cfd"` [INFO] [stdout] dfba0908f9128448384dac220ba9618a30a2c0ab39079d24d4c28f8936426cfd